From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0668DC982D0 for ; Sun, 20 Sep 2026 04:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xzyP2lP6mDo2Tguvti7VeQ501kHVG6IAx4yYOdJMaeY=; b=IO3flfRFTcJ0OW5G6zZ7ijLOwS 8h0jzkNuwNXZpL1VpgUunYG5DLgdPbGW9q2wbI1YwYthMimKswLOJ8+ewyl/nvcMulGG045YxSqoe hwlwjr85Hmx/Pz8B+VtfUsCbAfLL0ZGVcdCHjRCu6g4LtaW3fo6GQYX1TP+lvVbphZzMoPDS9OT4Q wri7O0Aww7GEQgvO1i7JmMHr0THxHQPK6trDc4BxRn9MczLzzaoOwr7+r0wMoHtk6fY5H1/Gc+QTC oPv0yz/+m+VS+Liy1Zu3HakAqZrtTvO93HxaWFX2x43vRTGJEI25tzP5ScbUDtgiYC2NRMuHgXYSO 3CoeAWpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x89ao-0000000GsFZ-4BAx; Sun, 20 Sep 2026 04:55:59 +0000 Received: from mail-pj2-x11.google.com ([2607:f8b0:4864:39::11]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x89am-0000000GsDD-11Ve for linux-mediatek@lists.infradead.org; Sun, 20 Sep 2026 04:55:57 +0000 Received: by mail-pj2-x11.google.com with SMTP id d9443c01a7336-2d747f066d8so6962485ad.1 for ; Sat, 19 Sep 2026 21:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789880155; x=1790484955; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xzyP2lP6mDo2Tguvti7VeQ501kHVG6IAx4yYOdJMaeY=; b=bl3TqjHlnWHxK2pFcMqN+IG9EA0kZM4sG4fSsP5SoGw0VOxPAEC5cSjr5kSPjCBknU +JDcbJVtfa9IjC9J3EXu+OJDH2RACfxs1SUutr0S55XZRX22GtDXk1fSoO9tIX0VkdZ+ BYR7xQ01sarK+2FGg8rVcOUAtpVHZu5RSScNXe7SuYQscuMLbBwwa5chBcIqDvocfAzt mm7EsuICpAOa4QZSl+lfYGjNJqqMJYR4eTJ5Rmpb033nZBUbLbhTHJUg0zr4/5H9ZHyU Ks6fNNNHkYo9TpfGFuo6OdE23fvLmRAnm5Rw0AWbNkHlxH95iFcHMPnjncr24Wpxj1Nm WTbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789880155; x=1790484955; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xzyP2lP6mDo2Tguvti7VeQ501kHVG6IAx4yYOdJMaeY=; b=Vnoa6ET+kyvdzCnPOJWhdBekzxUjV0zpzqkeO3ZAu7NdjvpeZVwrcM8Kms6+kHPwOA RDhOluh5wuthSwm2Xokb412gzwCL+DvDLJ22RFiGP3bCcoJzY5a4DgFA3na4J6KQTuiH sHvBq9N3HSr/7EpnlJH4Xi+eJicuzvKnthsZi710u7+KYrKsvDDUu7QL4OEvio4IrJOh E+p1xCVYGVNUrtkmJbPytB4LIW+2AvOYhRAtkoi9M647/rf/rxLyNTuq9lyC7DwixTTX Y1nKifRkBY/vG1TpMmBKpol5ztsktPa4ZJR9aL4WHbLSJPeOofRBpGFh0pLqFI7oD4u+ dRHQ== X-Forwarded-Encrypted: i=1; AKwUvByqZK+15IFq1OelccEKimdDQCM9YMDOFIY5qr5v4vxx8WlceBfsfRgitByNzYVY4Oix8O89POP4bENCgBSnAg==@lists.infradead.org X-Gm-Message-State: AFuF++mWKuuQZ4gnK9t67SsiQcVe9dsSXZH3EGlWeW4ylDBah4ektzQ/ daG296gEK0Qu54Prqh8OVFDHGGLxPR/t4cZNzo2uFnzQT+3ovEnwU0bt X-Gm-Gg: AYBFou0uogTkPOsHze5rS7+jgh19vcm3i3jbiAR1pmEI8sr3KjCg0ouZ7oYC/lfBGY/ P3Yo6w3N6qwZTfDA3k/LLqxGYjQBzo8OoH0HQq2xRom/DK0LIbUCEm6XNRa8C8JaU3hvoKxskTm i5k2iR8RxXn7MN6X2zyYMkOSeV1gVp2THmBWfhT87G7WjOgkgkr1vpbDebdGEpio+P3B9Dy/grx v/nhT+6xIUCNb24v7+INpe8mOJf58Z80wVnZKYg6hxiN25NeNJmAHULOZEEdnuIlRlALR3h3uQB aEFv9jmUe0or6kv25YASgYJmjm/M0kuJkK5pbRcvBcjwbfF+d6t8/c5Af+ssXJuQ1vdAwPRstIT fJxRPnfx54IBzhDAfRVDoCLc8gvRtPqfwzpnAEQ2oThZIWLbyz/Lwfa3URM7oPoz3fGqtXlTewX 1LbOaWSCTbrDpys7Tl9rkjKtf6Dpfu84caUljcieQKG12RlBH/0Se7Hd5Ei/cP2reZjiM3OEDIF O9xA9a9jYQJ3xObPw2Qb5WKWAg6FCVT74EGKu6MhsYn/PidjR/OpcPT6tLYU2P4ofb3eV5eZKu9 lhrnn6FJeZ6T0GMGrPPcH9Gw4OZdfKt02/fBT+EzMVuw2Dc= X-Received: by 2002:a17:902:d2d2:b0:2dd:ad73:5b5a with SMTP id d9443c01a7336-2ddb224f33bmr80978895ad.21.1789880155541; Sat, 19 Sep 2026 21:55:55 -0700 (PDT) Received: from [192.168.2.3] ([2403:581e:d87e:0:fc2d:ed31:e80e:412d]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ddc17d712dsm16026765ad.64.2026.09.19.21.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Sep 2026 21:55:55 -0700 (PDT) From: James Calligeros Date: Sun, 20 Sep 2026 14:53:44 +1000 Subject: [PATCH 05/28] alsa: pcm: Remove the qos request only if active MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260920-macaudio-v1-5-741cc20a74e5@gmail.com> References: <20260920-macaudio-v1-0-741cc20a74e5@gmail.com> In-Reply-To: <20260920-macaudio-v1-0-741cc20a74e5@gmail.com> To: =?utf-8?q?Martin_Povi=C5=A1er?= , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sven Peter , Janne Grunau , Neal Gompa , David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , Ulf Hansson , Amit Kucheria , "Rafael J. Wysocki" , Lars-Peter Clausen , Vinod Koul , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , James Calligeros , James Schulman Cc: asahi@lists.linux.dev, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, Takashi Iwai , linux-mediatek@lists.infradead.org, Hector Martin X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1854; i=jcalligeros99@gmail.com; h=from:subject:message-id; bh=sB9amKGCujymCV5dzhnXLQgtXCZDFSeONKc8RiAMJk8=; b=owGbwMvMwCV2xczoYuD3ygTG02pJDFnr0+UN5p3NCRDcX2rwtCeY+U1o1BqxOV9aeCT2Pg2+s cW76L9px0QWBjEuBksxRZYNTUIes43YbvaLVO6FmcPKBDJEWqSBAQhYGPhyE/NKjXSM9Ey1DfUM jXSMdYwYuDgFYKojPRn+adW6m8+Zu2WmcdojE37fL2mVgR13MvV2nf3JeWLWmeYpRxj+mShcjNp sw+Q7MyPW1PitzbHnSd8+notYbJv1bMt81fmGPAA= X-Developer-Key: i=jcalligeros99@gmail.com; a=openpgp; fpr=B08212489B3206D98F1479BDD43632D151F77960 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260919_215556_302887_8EFF09CB X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Hector Martin Fixes warning: [ 8.502802] ------------[ cut here ]------------ [ 8.503445] cpu_latency_qos_remove_request called for unknown object [ 8.504269] WARNING: CPU: 5 PID: 2790 at kernel/power/qos.c:322 cpu_latency_qos_remove_request+0x48/0x98 [ 8.505499] CPU: 5 PID: 2790 Comm: wireplumber Tainted: G W 6.5.0-asahi-00708-gb9b88240f7ae #2291 [ 8.506777] Hardware name: Apple MacBook Air (13-inch, M2, 2022) (DT) [ 8.519099] Call trace: [ 8.519402] cpu_latency_qos_remove_request+0x48/0x98 [ 8.520027] snd_pcm_ioctl+0x86c/0x182c [ 8.520519] __arm64_sys_ioctl+0xf8/0xbd0 [ 8.521020] invoke_syscall.constprop.0+0x78/0xc8 [ 8.521604] do_el0_svc+0x58/0x154 [ 8.522026] el0_svc+0x34/0xe4 [ 8.522409] el0t_64_sync_handler+0x120/0x12c [ 8.522951] el0t_64_sync+0x190/0x194 [ 8.523408] ---[ end trace 0000000000000000 ]--- Fixes: 5371a79be97c ("sound: Call cpu_latency_qos_*() instead of pm_qos_*()") Signed-off-by: Hector Martin Signed-off-by: James Calligeros --- sound/core/pcm_native.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 6d32c12fb79b..88c83e5fd6cf 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -971,8 +971,9 @@ static int snd_pcm_hw_free(struct snd_pcm_substream *substream) goto unlock; result = do_hw_free(substream); snd_pcm_set_state(substream, SNDRV_PCM_STATE_OPEN); - cpu_latency_qos_remove_request(&substream->latency_pm_qos_req); - unlock: + if (cpu_latency_qos_request_active(&substream->latency_pm_qos_req)) + cpu_latency_qos_remove_request(&substream->latency_pm_qos_req); +unlock: snd_pcm_buffer_access_unlock(runtime); return result; } -- 2.55.0