From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B5EAC982EA for ; Wed, 23 Sep 2026 08:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HYaEdoE2D6DyNBSjY/HES0QFzpXfE7VbCmeXXdvItDA=; b=qKil26pGowA1JecYL6tAkUdd11 Tgzkw2zauhpfqdFoaz5ANsWndn35ya0pqbwNUD+LSVUpDkgscm8nV6ijqn8jrNWJq9Oh3xZMsNBGG u43RfNrh0dl00afSgDMggI9bIpEM2OiHsmEo0uy2ZQBUnTMQIFPbZNUOxOMX/euG4dR90vxZ6IzUZ tzYU6CYs7g102xTQBCVxx27CzXa+oy5lFGj2aP9zTJdEut4kFCVxJj9vdgq1RHOhllSJbEfTk6nwA plonN5WVQhtD3wL9fsDlWOJ3C5fpPxILHGKg6x35+5mIfpqjax2oZHvHdW3KnNbd4TMu3fDqwFu7O +a+rgtgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9I6u-00000007UCi-2dD7; Wed, 23 Sep 2026 08:13:48 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9I6t-00000007UBs-2xYu; Wed, 23 Sep 2026 08:13:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=HYaEdoE2D6DyNBSjY/HES0QFzpXfE7VbCmeXXdvItDA=; b=Mti8DzzLyJagQ2/7OxjGzGRaln ZnHMJhXCeVweFGJsr4nc5FQNPPUJz944Z8YjiGKh5SgELagvgxFdBnDynj2qSqYpa55RYCF4gdgGy RQ02NV8HPtsiXNEh/6JEiLqZK+udUdcZbAF3gK42R694UIQgeRl2wqKEquFTfgGybxRMZMbPmqzqq caEUBe6PU0gZKaD2RH2ynG0C1MiFUuV7UJta22YQzuSpG5RBh9KSZIDFvV6cp+XiPxXbIlDbOW3aY B1yNr/X/1kcLcbhfTC+iAedOvkFtpiR2JI0T70VdHoGSsCTH7spyciWRFt6FpSulOdIWrjOqcZ4Ak C9WJkifw==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x9I6m-0000000EVl3-3hSK; Wed, 23 Sep 2026 08:13:44 +0000 X-UUID: ab0297a8b72611f1afed4741b24580c9-20260923 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=HYaEdoE2D6DyNBSjY/HES0QFzpXfE7VbCmeXXdvItDA=; b=XRWaGK4MLU82FXDXM4R5u7FmcmCYujwNHe7hXYfPciyHHeNaKx3A+A0Xh0M6cfrh+G8XKyclmu0AYbdPxtd7yc9ibQVSv0+0GjL9oNJ6lPy66aDRmjCyyzs1/CTippK2wvIGK040ISjsre4F0N0lhjmNzkBEgI7ecwT+HlS+7V4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.19,REQID:5c743c9a-da8b-4d20-9817-55940d5918e0,IP:0,U RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-25 X-CID-META: VersionHash:7db8b62,CLOUDID:a3003003-5a2a-4553-bb50-070593e932a7,B ulkID:nil,BulkQuantity:0,SF:81|82|102|836|865|888|898,TC:-5,Content:0|15|5 0|99,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL:0,OSI:0, OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: ab0297a8b72611f1afed4741b24580c9-20260923 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1497720161; Wed, 23 Sep 2026 01:13:33 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Wed, 23 Sep 2026 16:13:27 +0800 Received: from gcnsap21.gcn.mediatek.inc (10.17.81.22) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Wed, 23 Sep 2026 16:13:18 +0800 From: Kyrie Wu To: Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Kyrie Wu , Hans Verkuil , Nicolas Dufresne , Nathan Hebert , Arnd Bergmann , Irui Wang , George Sun , , , , , CC: Neil Armstrong , Andrzej Pietrasiewicz , Yilong Zhou Subject: [PATCH v10 05/10] media: mediatek: vcodec: Add VP9 Probability Size Configuration Date: Wed, 23 Sep 2026 16:12:41 +0800 Message-ID: <20260923081246.268182-6-kyrie.wu@mediatek.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260923081246.268182-1-kyrie.wu@mediatek.com> References: <20260923081246.268182-1-kyrie.wu@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260923_091341_946673_502CA088 X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Introduce support for using different probability buffer sizes for different stateless decoders: in particular, the VP9 decoder can use a different size on different SoCs because of different hardware capabilities. Move the hardcoded single probability buffer size value to decoder params, introduce a new VP9_4K_PROB_BUF_SIZE and assign: - VP9_PROB_BUF_SIZE (2560 lines) to legacy SoCs; - VP9_4K_PROB_BUF_SIZE (3840 lines) to newer SoCs (MT8196, MT8189). Signed-off-by: Kyrie Wu Reviewed-by: AngeloGioacchino Del Regno --- .../mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h | 2 ++ .../mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.c | 1 + .../mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c | 9 +++++++++ .../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 4 ++-- 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h index bbfa6954d616..0bde1c5b5aa0 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h @@ -82,10 +82,12 @@ struct vdec_pic_info { * struct mtk_vcodec_dec_params - decoder supported parameters * @level: decoder supported vcodec level * @profile: decoder supported vcodec profile + * @prob_size: vp9 decoder probability size */ struct mtk_vcodec_dec_params { s64 level; s64 profile; + size_t prob_size; }; /** diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.c index bf3569e6b559..bfa62974b1a7 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateful.c @@ -632,5 +632,6 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8173_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_4_0, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_1, + .prob_size = 2560, }, }; diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c index cbea445e5c2b..56656222d0f1 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_stateless.c @@ -10,6 +10,9 @@ #include "mtk_vcodec_dec_pm.h" #include "vdec_drv_if.h" +#define VP9_PROB_BUF_SIZE 2560 +#define VP9_4K_PROB_BUF_SIZE 3840 + /** * struct mtk_stateless_control - CID control type * @cfg: control configuration @@ -892,6 +895,7 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8183_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_4_0, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_1, + .prob_size = VP9_PROB_BUF_SIZE, }, }; @@ -945,6 +949,7 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8188_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_5_1, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_2, + .prob_size = VP9_PROB_BUF_SIZE, }, }; @@ -965,6 +970,7 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8192_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_5_1, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_2, + .prob_size = VP9_PROB_BUF_SIZE, }, }; @@ -985,6 +991,7 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8195_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_5_1, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_1, + .prob_size = VP9_PROB_BUF_SIZE, }, }; @@ -1005,6 +1012,7 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8196_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_5_2, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_2, + .prob_size = VP9_4K_PROB_BUF_SIZE, }, }; @@ -1042,5 +1050,6 @@ const struct mtk_vcodec_dec_pdata mtk_vdec_8186_pdata = { .vp9_params = { .level = V4L2_MPEG_VIDEO_VP9_LEVEL_4_1, .profile = V4L2_MPEG_VIDEO_VP9_PROFILE_1, + .prob_size = VP9_PROB_BUF_SIZE, }, }; diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c index ee4d1cd82426..d08be051d0ab 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c @@ -22,7 +22,6 @@ #define VP9_RESET_FRAME_CONTEXT_ALL 3 #define VP9_TILE_BUF_SIZE 4096 -#define VP9_PROB_BUF_SIZE 2560 #define VP9_COUNTS_BUF_SIZE 16384 #define HDR_FLAG(x) (!!((hdr)->flags & V4L2_VP9_FRAME_FLAG_##x)) @@ -551,6 +550,7 @@ static int vdec_vp9_slice_alloc_working_buffer(struct vdec_vp9_slice_instance *i struct vdec_vp9_slice_vsi *vsi) { struct mtk_vcodec_dec_ctx *ctx = instance->ctx; + struct mtk_vcodec_dec_dev *pdev = ctx->dev; enum vdec_vp9_slice_resolution_level level; /* super blocks */ unsigned int max_sb_w; @@ -621,7 +621,7 @@ static int vdec_vp9_slice_alloc_working_buffer(struct vdec_vp9_slice_instance *i } if (!instance->prob.va) { - instance->prob.size = VP9_PROB_BUF_SIZE; + instance->prob.size = pdev->vdec_pdata->vp9_params.prob_size; if (mtk_vcodec_mem_alloc(ctx, &instance->prob)) goto err; } -- 2.51.0.windows.2