From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E82EC98321 for ; Fri, 25 Sep 2026 04:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U1o0Fr3SsImGt+aqLrFKoD5OlJOoiuIdG7+nqMI1YN8=; b=04aVOxytXEb1ku0unRj9pTh5Ij J6eCA8qhXSxIQKEoratjpZ9pFTOohNAjwlzbjZT+YbIwKO4v3dPp0PFQf/mhBNB9DMf0GL4zVWkUY SjRYA5jgmZIN4WEg3XAtm/uXSmLZSJGV0Wv38cEcshlAW/LWKSvh1XmsSGugftpYkD3Ox5WUTXnns LT2nmLH20vUIfs1fsJ2BzFVnRk2Uupfkjv/ChDN3Eo7UxkKIHCvQlFGz5GPSkbMqy4v8uogZzS/hx mHdDGYpOByErNZz37AVmzcR8JRL37jcz1xoXIytHAq2JB0XlUi46fkSY4YdH1Ru8mHVivFhFDWPPB Lf29gtKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9xuB-0000000CeMJ-0qWB; Fri, 25 Sep 2026 04:51:27 +0000 Received: from mail-pj2-x0d.google.com ([2607:f8b0:4864:39::d]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9xtd-0000000Cdu7-03in for linux-mediatek@lists.infradead.org; Fri, 25 Sep 2026 04:50:54 +0000 Received: by mail-pj2-x0d.google.com with SMTP id 98e67ed59e1d1-3a0af40d240so292550a91.3 for ; Thu, 24 Sep 2026 21:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790311852; x=1790916652; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=U1o0Fr3SsImGt+aqLrFKoD5OlJOoiuIdG7+nqMI1YN8=; b=Jsf5UI/40WJF/D8X9lP5CHLc3uwvHrFoRESTQ6b+aTcF/Tg+Tcjtnbh/FtWQqMXeDp UreR5JquiWlUDBEhI9VWyNOxgU9WBZUKVd8165fGJfDr/JLfs54VtJtolHC0CNyCSZy9 37yn2mILpHFAbQ2AIDcdlIdAF529LgdLDgZkOc72nKFrnH6autp63u3AnJGpiVCOvCUf uc9fX4nrxpa0vkwXerKQpACTiEK2cjliIlHc/IO76GlgVqWi9JSC213zN9FmKn4e+/3W t0lmMP0SD66VeZ7Cceb9eaXgnGEkZaQiTsbYz3C9jZTvAeCbVzRHDxafR3UVC8ihBrcI cokg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790311852; x=1790916652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=U1o0Fr3SsImGt+aqLrFKoD5OlJOoiuIdG7+nqMI1YN8=; b=kty1LzHst9s+rhBd0gl+koGXRT+THqXBlS+eSaxp7tHgzG+FAKXHzEwYHvipo3EjRF Q4NVUdNyO4EZzwzEHi3rdXnnvMuadTx4o0TG6HYwf02VMD6gTccDjLX7sIphYCJDeRUW shVPWPqmsXIl0uIqrZgWmZQyp3A08Y9EnIUUWBWodWhoW0s0ngwN5yStfPI/hf0uWYRM nT/0zvTO/fYTAHPQSxEuvFZy5pNMH012Vhrwlv76CoZyIHtJRB1kRYFz/o7lYONOtDrq yvh3CDcV1nqWRtQnu6fCt7N9eVISiZ0YmCEbLD9Jv8GItrLkFcDu54CWVEPIpjpMyBpG XOqQ== X-Forwarded-Encrypted: i=1; AKwUvBz1VwvE2lnelanWa3LLVup9kNb8sgyJYkgsxqaE7B7zh8uhjruOx6/beRbIErlpNNoqPU0VV91nrmpXgprlXw==@lists.infradead.org X-Gm-Message-State: AFuF++mkVgg3arXYMG2bCLhmJGA+on5H/rk+fBCV3x/yCwLdP24u4+vN 2ZFv0F7xvQOe/ADxZjhYcMcOOZVeKcbAZgvPBVBzycFMYSvCcszFro5r X-Gm-Gg: AYBFou3c6tknrisLYWwAkeYwYdFDlIX4e9EoGXigzuXfrjaxX8ZVVoAruUwYh6b6Qe4 nQjsRLN1zitlzW82v5rmFPbLsr2K2BQBL48IkfQhOlaWeQ900m5AANt1MbkEKflwKWqM3X8AQMw lCliMF9BunRNlXEAqaHX7y2M+8qnJL4NGp4Y67Vhj0px7GMJdnzpqI6nxz+43qAPRWVzaIMxyDS a+kKw1MWzDZrXCeta4jdk0GuQLTkhWQ3R1gG5echrEwmeC5SI6HCuKcTnUXGCQ7QjouRqD139y+ fpx6z7dLqZYn43leEUEY7xVNSDn5+Jsfcz+PkJSZU7SdAc2D7m5YyAUqMM+7qkmNRZIxgbonIWK bhX/y5SsPCoqtjGw13Kd/BHglC8Ha4O4PVI7SMlz3VyS8TFsZDkJgoQz76eTrgxJZTUOruj2S1B LVM05km+TnLbWehhhCy/iHgBrJ4ouHaoO79KEuAnhvIuHVYMnixwRSV7AxACfotTJkry/WbqrTl PWQEVV3vp3g8RHH0k6tgvuH7ZvpHG56MB/ipDC+lavUdJeW3vnspm5sjJaoLY6GDHryFWth+mo+ WLK/1QnVx56ek2AQAOu4Jx7s X-Received: by 2002:a17:90b:17c6:b0:3a0:516d:9f88 with SMTP id 98e67ed59e1d1-3a098761df2mr3859051a91.26.1790311852041; Thu, 24 Sep 2026 21:50:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a0976cacbesm8151528a91.13.2026.09.24.21.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 21:50:51 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno , Trevor Wu Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , cassiogabrielcontato@gmail.com, Mukesh Ojha , Liviu Dudau , Haotian Zhang , HariKrishna Sagala , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 13/14] ASoC: mediatek: mt8195: Fix ETDM probe error handling Date: Fri, 25 Sep 2026 11:49:07 +0700 Message-ID: <20260925044908.450775-14-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260925044908.450775-1-phucduc.bui@gmail.com> References: <20260925044908.450775-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260924_215053_071692_7AE8BFF6 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: bui duc phuc Use pm_runtime_resume_and_get() to properly handle runtime PM errors during ETDM probe. Propagate errors from MCLK configuration and enabling instead of ignoring them. Fixes: 1de9a54acafb ("ASoC: mediatek: mt8195: support etdm in platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 27 ++++++++++++++------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c index 11317cdd14ab..8fa830a57502 100644 --- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c +++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c @@ -2503,6 +2503,7 @@ static int mtk_dai_etdm_probe(struct snd_soc_dai *dai) struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai); struct mt8195_afe_private *afe_priv = afe->platform_priv; struct mtk_dai_etdm_priv *etdm_data; + int ret; dev_dbg(dai->dev, "%s id %d\n", __func__, dai->id); @@ -2510,15 +2511,23 @@ static int mtk_dai_etdm_probe(struct snd_soc_dai *dai) return -EINVAL; etdm_data = afe_priv->dai_priv[dai->id]; - if (etdm_data->mclk_freq) { - dev_dbg(afe->dev, "MCLK always on, rate %d\n", - etdm_data->mclk_freq); - pm_runtime_get_sync(afe->dev); - mtk_dai_etdm_mclk_configure(afe, dai->id); - mtk_dai_etdm_enable_mclk(afe, dai->id); - pm_runtime_put_sync(afe->dev); - } - return 0; + if (!etdm_data->mclk_freq) + return 0; + + dev_dbg(afe->dev, "MCLK always on, rate %d\n", + etdm_data->mclk_freq); + ret = pm_runtime_resume_and_get(afe->dev); + if (ret) + return ret; + ret = mtk_dai_etdm_mclk_configure(afe, dai->id); + if (ret) + goto err_put_pm; + ret = mtk_dai_etdm_enable_mclk(afe, dai->id); + +err_put_pm: + pm_runtime_put_sync(afe->dev); + + return ret; } static const struct snd_soc_dai_ops mtk_dai_hdmitx_dptx_ops = { -- 2.43.0