Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liu <anthony.liu@mediatek.com>
To: <nbd@nbd.name>, <lorenzo@kernel.org>
Cc: <Sean.Wang@mediatek.com>, <Leon.Yen@mediatek.com>,
	<Quan.Zhou@mediatek.com>, <Ryder.lee@mediatek.com>,
	<litien.chang@mediatek.com>, <kun.wu@mediatek.com>,
	<jb.tsai@mediatek.com>, <emery.hsin@mediatek.com>,
	<linux-wireless@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	Anthony Liu <anthony.liu@mediatek.com>
Subject: [PATCH] wifi: mt76: logging FW return value when FW download fails
Date: Mon, 5 Oct 2026 16:38:55 +0800	[thread overview]
Message-ID: <20261005083855.107460-1-anthony.liu@mediatek.com> (raw)

Add log messages for pinpointing FW download failures.

Signed-off-by: Anthony Liu <anthony.liu@mediatek.com>
---
 drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
index eb4d02ec3ebe..9189ccdaa5e6 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
@@ -3225,7 +3225,7 @@ int mt76_connac2_load_ram(struct mt76_dev *dev, const char *fw_wm,
 
 	ret = mt76_connac_mcu_send_ram_firmware(dev, hdr, fw->data, false);
 	if (ret) {
-		dev_err(dev->dev, "Failed to start WM firmware\n");
+		dev_err(dev->dev, "Failed to start WM firmware %d\n", ret);
 		goto out;
 	}
 
@@ -3396,7 +3396,7 @@ int mt76_connac2_load_patch(struct mt76_dev *dev, const char *fw_name)
 
 	ret = mt76_connac_mcu_start_patch(dev);
 	if (ret)
-		dev_err(dev->dev, "Failed to start patch\n");
+		dev_err(dev->dev, "Failed to start patch %d\n", ret);
 
 out:
 	sem = mt76_connac_mcu_patch_sem_ctrl(dev, false);
@@ -3518,7 +3518,7 @@ int mt76_connac3_load_cb_patch(struct mt76_dev *dev, const char *fw_name)
 
 	ret = mt76_connac_cb_mcu_start_patch(dev);
 	if (ret)
-		dev_err(dev->dev, "Failed to start cb patch\n");
+		dev_err(dev->dev, "Failed to start cb patch %d\n", ret);
 
 out:
 	sem = mt76_connac_cb_mcu_patch_sem_ctrl(dev, false);
-- 
2.45.2



                 reply	other threads:[~2026-10-05  8:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005083855.107460-1-anthony.liu@mediatek.com \
    --to=anthony.liu@mediatek.com \
    --cc=Leon.Yen@mediatek.com \
    --cc=Quan.Zhou@mediatek.com \
    --cc=Ryder.lee@mediatek.com \
    --cc=Sean.Wang@mediatek.com \
    --cc=emery.hsin@mediatek.com \
    --cc=jb.tsai@mediatek.com \
    --cc=kun.wu@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=litien.chang@mediatek.com \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox