From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79975CA6007 for ; Thu, 8 Oct 2026 05:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=cBapcVUEPq2DV9/lbtDCUq2OC1ML+XYqyYlRGjTF2Cw=; b=HU7lNzAmyo4fX45VIVH/1MKjXP 5vuzJUs6phPnXmKjR0oznkveCa59oZnjRqZyO9W+ExWheuUBPIQ9NeRpwiha/Qj2YegKz5HtBBcBk yIMWxdT9tZjh6LEZ75ji4vbWPzrA1oh/NDRoEr2yh94zDq3uoaPMDpVKFrOTo0zgV6VH0eASzIIwE spLmnSeVRuqOUlZko+nP/MU1G+xVbk5tnPlH4r+phu9WbRTVeIV5/jHi5QECAbJ/vcWy5oiowGB97 gzklbECCu0uHEwPNh8QK2/igIw3p+aPxRVXXzsr2KsI6KbuFHupJ35QoE6/VSz2cYS0UtPUn2LOUl J+On+W3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEgcu-00000003XYd-3Gaj; Thu, 08 Oct 2026 05:25:08 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xEgcr-00000003XY0-3RyN for linux-mediatek@lists.infradead.org; Thu, 08 Oct 2026 05:25:06 +0000 X-UUID: 9afa497ec2d811f1afed4741b24580c9-20261007 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=cBapcVUEPq2DV9/lbtDCUq2OC1ML+XYqyYlRGjTF2Cw=; b=TGBx3jY4i3NoKFKGp/g/eA5xKJiB48GFZvP+xxuSlJtnD4DErTmc3/cao+KpnhKwUqQbKyQ27Qu14fT2YC8p94ELlN2J2YI6bK5KqbuTo2grk3vmpytaW/aqrw4C6lyNBQCOU17NzNfgvOKGSMoxKYDGsVngrXQo76TZVpUenx4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.20,REQID:03f76691-9de1-4d70-9760-b1f94d974b02,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:291e20b,CLOUDID:5b8b1a95-3103-4fdb-b79c-08de0e281a5d,B ulkID:nil,BulkQuantity:0,SF:102|836|865|888|898,TC:-5,Content:0|15|50|99,E DM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL:0,OSI:0,OSA:0, AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 9afa497ec2d811f1afed4741b24580c9-20261007 Received: from mtkmbs09n1.mediatek.inc [(172.21.101.35)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1426149497; Wed, 07 Oct 2026 22:24:59 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 8 Oct 2026 13:24:57 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Thu, 8 Oct 2026 13:24:57 +0800 From: Eason Lai To: , CC: , , , , , , , , , , , , Jeff Hsu Subject: [PATCH] wifi: mt76: mt7925: Fixes: Fix SER will panic when connect to AP Date: Thu, 8 Oct 2026 13:24:53 +0800 Message-ID: <20261008052453.3977058-1-eason.lai@mediatek.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261007_222505_876923_2FF6CC8D X-CRM114-Status: UNSURE ( 8.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Jeff Hsu MAC reset(mt7925e_mac_reset) not check all the RX Q and stop napi it will result racing then happen panic kernel: wlp1s0: associated kernel: wlp1s0: Limiting TX power to 30 (30 - 0) dBm as advertised by 02:0c:43:36:60:c8 kernel: ------------[ cut here ]------------ kernel: kernel BUG at net/core/dev.c:7436! kernel: Oops: invalid opcode: 0000 [#1] SMP NOPTI kernel: CPU: 1 UID: 0 PID: 459 Comm: kworker/u48:8 Tainted: G S OE 6.17.0-061700-generic #202509282239 PREEMPT(voluntary) kernel: Tainted: [S]=CPU_OUT_OF_SPEC, [O]=OOT_MODULE, [E]=UNSIGNED_MODULE kernel: Hardware name: HP HP ProDesk 600 G6 Microtower PC/8712, BIOS S02 Ver. 02.05.01 01/05/2021 kernel: Workqueue: mt76 mt7925_mac_reset_work [mt7925_common] kernel: RIP: 0010:napi_enable_locked+0x1cb/0x220 kernel: Code: 48 c7 c7 10 2c 1e 87 e8 93 c4 2f 00 4c 8b 6d e0 e9 e9 fe ff ff e8 75 31 ff ff 48 8b 45 e0 48 8d 53 10 a8 01 0f 85 02 ff ff ff <0f> 0b 8b bb a0 01 00 00 48 83 c6 18 e8 04 59 20 ff 48 8b b3 e8 01 kernel: RSP: 0018:ffffd1e8418afd48 EFLAGS: 00010246 kernel: RAX: 0000000000000110 RBX: ffff8a2921952cf8 RCX: 0000000000000000 kernel: RDX: ffff8a2921952d08 RSI: 0000000000000000 RDI: 0000000000000000 kernel: RBP: ffffd1e8418afd68 R08: 0000000000000000 R09: 0000000000000000 kernel: R10: 0000000000000000 R11: 0000000000000000 R12: ffff8a2921955658 kernel: R13: 0000000000000110 R14: ffff8a2921952918 R15: ffff8a2921955758 kernel: FS: 0000000000000000(0000) GS:ffff8a3088300000(0000) knlGS:0000000000000000 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 kernel: CR2: 0000561733e012d8 CR3: 000000011aa40005 CR4: 00000000003726f0 kernel: Call Trace: kernel: kernel: napi_enable+0x25/0x50 kernel: mt7925e_mac_reset+0x1a9/0x480 [mt7925e] kernel: mt7925_mac_reset_work+0x9a/0x1a0 [mt7925_common] kernel: ? __schedule+0x2f6/0x7c0 kernel: process_one_work+0x18d/0x370 kernel: worker_thread+0x33a/0x480 kernel: ? _raw_spin_lock_irqsave+0xe/0x20 kernel: ? __pfx_worker_thread+0x10/0x10 kernel: kthread+0x108/0x220 kernel: ? __pfx_kthread+0x10/0x10 kernel: ret_from_fork+0x124/0x140 kernel: ? __pfx_kthread+0x10/0x10 kernel: ret_from_fork_asm+0x1a/0x30 Fixes: c4edf9e3e0e5 ("wifi: mt76: mt7925: replace shared rx irq masks with per-chip definitions") Signed-off-by: Jeff Hsu --- .../net/wireless/mediatek/mt76/mt7925/pci_mac.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c b/drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c index 2549d4e9e3a4..c3db814b2788 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/pci_mac.c @@ -90,16 +90,11 @@ int mt7925e_mac_reset(struct mt792x_dev *dev) mt76_txq_schedule_all(&dev->mphy); mt76_worker_disable(&dev->mt76.tx_worker); - if (irq_map->rx.data_complete_mask) - napi_disable(&dev->mt76.napi[MT_RXQ_MAIN]); - if (irq_map->rx.wm_complete_mask) - napi_disable(&dev->mt76.napi[MT_RXQ_MCU]); - if (irq_map->rx.wm2_complete_mask) - napi_disable(&dev->mt76.napi[MT_RXQ_MCU_WA]); - if (is_mt7928(&dev->mt76) && (irq_map->rx.wm4_complete_mask)) - napi_disable(&dev->mt76.napi[MT_RXQ_ICS]); - if (irq_map->tx.all_complete_mask) - napi_disable(&dev->mt76.tx_napi); + + mt76_for_each_q_rx(&dev->mt76, i) + napi_disable(&dev->mt76.napi[i]); + + napi_disable(&dev->mt76.tx_napi); mt7925_tx_token_put(dev); idr_init(&dev->mt76.token); -- 2.45.2