From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36725CCA464 for ; Fri, 16 Oct 2026 09:13:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5N4qyFuyYUzsn7yKUmEA1eVXAS1dMHnjfF1B2UXe6bw=; b=RQr09Tm7cuH/TTjmwDxMs9SC85 Flpvj3HCeS8XCot784W2P8glvdMK9A2K7cvTwG0wfKhq9bVwWKvDxYZbiJ4jkbaRlbf0WXLaRYIG+ zy0hFc1CBYaVbnTovd+SwCqK3t72/eBrCBCF18tABuwaNCO+PC11gSX7gQQIe3uiIK0bAXb+PFaGG 1/mxfLXIVn5rF9STZLKM2mVwRrkLtmjM3SBSKY+PJu/z+rlaF0RLeZfwpwX5c4XTqNncYJGWj745Y rbo/TYzjq7fgkqyjnOFfzI6B5cnv8/b/oEC/Zs8PzLUKm5X/Pn4DPAKKErz5mEzU8VoQtfP9rojBr ay6i7hDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHe0A-00000002RgM-3wkX; Fri, 16 Oct 2026 09:13:22 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHe04-00000002RY0-1Pmk for linux-mediatek@lists.infradead.org; Fri, 16 Oct 2026 09:13:18 +0000 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-ccc6b11a19aso2851264a12.0 for ; Fri, 16 Oct 2026 02:13:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792141995; x=1792746795; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5N4qyFuyYUzsn7yKUmEA1eVXAS1dMHnjfF1B2UXe6bw=; b=qXy3GLqiHPbZ6nSzWSUIkC4s5ylJrH4cONgSxQlr1voAoOLoQXMyf0yYOj2fZLpuu6 yknw2l+ySIm6mHJRK60M2xDgqIbS1Dp0+kMtGaf8N4BeA/8V3S+fs5CM1nJ0S/b7OVja bRdtZHfMq86Lk7JYSg7JAGAf45xL20TGv2pEDUodvYNznsrH4HvkIsZtmW6baghyGPhx Gv6VpFI3YtSm1IrRnYtJFKpX7nnGjOLAZvdbgMAE6u2T/UPLZUCS+Wf/BkuzKiHrZ2G6 jP6VLFRNaVe2zQpgmSCDnSOTe+MuV61cle3E/uW5IuuwSWezf9tH9hFVkQxG2zgnq6X5 v7zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792141995; x=1792746795; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5N4qyFuyYUzsn7yKUmEA1eVXAS1dMHnjfF1B2UXe6bw=; b=EZXlPffGzyKQMylyTVYV9LEn1C2or2F/coa2EN5gyjXx/8sz8C+DGTm/wDEAcEjPem Vdl4aga4/oCbMisee5M6WtugUUJcrxflKV/gRh6UeyUUu4ioHK+xtQvZWsOp8uXig3wF Lij9n1Dpv/hmCVtYoZC+MiWDX4swY5ageR3neSNBnWHeL0ILQ380W6RCGDW2aNm7I5rF S7PSWOZRoncmUz7l9BTmDQ0bCCawhYTBZwAHLKFa6aBwOMo8XXyyXLb4bE/YGNGjfqjq fk9RGEaUn/c/J2YFYqi9qKRXW2QVHDfAHUZKTy6M2tY1acJ75J4Mg3qqsaPN851Sbsnb m+OQ== X-Forwarded-Encrypted: i=1; AKwUvBwFN7nu6Kr6AJ3naprt2AtZuncqqMa9wC4C6K/Y+LzElNiD2V5JcpmMn7K8sB/3G83wJYP7q4kwpQ/YUTqH8w==@lists.infradead.org X-Gm-Message-State: AFq9FYLUEW3URvEK7gJ5TEwGyso+ld05j+QB3jZq3FeYJrqDTRbNQvNx 8yLmEKBlqLSCwE9Z+pNQwA9Q3teT0CetJirRo3fn3W4sABtY1Z1p5p8r X-Gm-Gg: AYBFou21YWewASHYA8CTLOtUBI9N4gI31zx79eChHYEbpq1ee6Pfsyqod7L9tQrCu0y Sx6+2TU09iKKIBynIjXtddWN50HXU/ND0htCsv0HFqYzzqcqxb3ncbA+t01nl1HvQBQfNIcxTko hiMxjcxXVnyTHdASP5dGaCdvzIw462JUfO0LZPqnsr1Mwt6WIq2Eax6ScvXNyHFj2X3rgGnfy3s r+B42iM0jrBZQUHgvRpB2LgOjZxV5/Kr8s0CaMz6PCMWU7VLxPwMbOY5CIo9HenyqTLl6+AjbNH 7sv9mvl4hWCI8wCjJ6Cluo2vkfwz9QTHqUU1LkcnkhEZIsPLan6uc3KuGH7Xp4KPxFgUvD2ACQr 0yqi54qlugwnHh7C3avwSiAuLryhkW1kTUr79ytG6JPjGsXthJdErj3SxNaZoE/bM8rYp9gQ+Qz rEaDpbfgbX2ToKvoK6DraN/LY/V0w5F/Kz9+MZYqfCMirxMQ1itllybqdA1yQDf/fc4SbN2DDLs hukUf1F+aiWQPbkZbooWP+DPJkj5eKErnToFJZdKoPF1fRdpA== X-Received: by 2002:a17:90b:28c8:b0:3ac:a7ee:678c with SMTP id 98e67ed59e1d1-3aca7ef2e00mr3511520a91.2.1792141995392; Fri, 16 Oct 2026 02:13:15 -0700 (PDT) Received: from DESKTOP-VNSSJ2S.localdomain (59-127-145-64.hinet-ip.hinet.net. [59.127.145.64]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd65497e28esm767274a12.7.2026.10.16.02.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 02:13:13 -0700 (PDT) From: Zhi-Jun You Date: Fri, 16 Oct 2026 17:12:37 +0800 Subject: [PATCH net v5 5/5] net: ethernet: mtk_wed: bail out when failed to set up rings in wed_start MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261016-wedfix-v5-5-8b02e78fd34f@gmail.com> References: <20261016-wedfix-v5-0-8b02e78fd34f@gmail.com> In-Reply-To: <20261016-wedfix-v5-0-8b02e78fd34f@gmail.com> To: Felix Fietkau , Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Sujuan Chen , Rex Lu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Zhi-Jun You X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1792141974; l=1511; i=hujy652@gmail.com; s=20261016; h=from:subject:message-id; bh=ePo8kYEQepEUUlHGep4r47dMcAUe+w0OHJZFIANEXVY=; b=n9KaOOF5fBmx0U1LSDXbITyZem2x/eJbiwispep6tmzvNhm1EtTdd5kx/xEfHrdoEZpp/bctn SxpS9hnOJO6A+sKBm+tdCHRuzDp4HbwtG6Evlqx2+TjBkoY99pVw88r X-Developer-Key: i=hujy652@gmail.com; a=ed25519; pk=AYHrGhtLNb9z7JIsGOOYWmKKIoVPH7ZZgT+CLIDMuEM= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261016_021316_387576_6E84D0B0 X-CRM114-Status: GOOD ( 11.29 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Add error message and return when fail to set up tx/rx wdma rings. This is suggested by Sashiko. Link: https://lore.kernel.org/all/179000700034.2160803.10594281691384015089@kernel.org/ Signed-off-by: Zhi-Jun You --- drivers/net/ethernet/mediatek/mtk_wed.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c index 3a7c2bb33691..86845893ae20 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed.c +++ b/drivers/net/ethernet/mediatek/mtk_wed.c @@ -2353,14 +2353,20 @@ mtk_wed_start(struct mtk_wed_device *dev, u32 irq_mask) for (i = 0; i < ARRAY_SIZE(dev->rx_wdma); i++) if (!dev->rx_wdma[i].desc) - mtk_wed_wdma_rx_ring_setup(dev, i, 16, false); + if (mtk_wed_wdma_rx_ring_setup(dev, i, 16, false)) { + dev_err(dev->hw->dev, "wdma rx ring %d setup failed\n", i); + return; + } /* * non-DBDC MT7986 allocates only rx_ring[1] and tx_wdma[1] during setup * but tx_wdma[0] is also needed for WED to function. */ if (mtk_wed_is_v2(dev->hw) && !dev->rx_ring[0].desc) - mtk_wed_wdma_tx_ring_setup(dev, 0, MTK_WED_WDMA_RING_SIZE, !!dev->tx_wdma[0].desc); + if (mtk_wed_wdma_tx_ring_setup(dev, 0, MTK_WED_WDMA_RING_SIZE, !!dev->tx_wdma[0].desc)) { + dev_err(dev->hw->dev, "wdma tx ring 0 setup failed\n"); + return; + } if (dev->wlan.hw_rro) { for (i = 0; i < MTK_WED_RX_PAGE_QUEUES; i++) { -- 2.47.3