From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA04606A31A for ; Tue, 20 Oct 2026 05:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ChZoX6p3; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=WU4IXcPQ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=5l6pqreEYh+0Dsa58mvKfgN8V+MvlUn6xbXr6Z0vjIA=; b=ChZoX6p3BzpB7pXEBg9q0BDH8m X5GHtQiwghX74S0TkicmSp1l3kr4ortkX+aitvhnN1xZTK8LxmZ624R1tSkc98cMDeb45iSs/7504 lRa3Gm4z/uHT0YmtASseMK27EpgAEC0gAG2uPROI1I4gmemLWffXLAcsG00u0nohiMhp7rFAIvxI9 dniLoUKO+HpWHKo926mhx55jupIpdooyVd7H0o15F6YrbMlW/c4E0qqv9GxPj7A47sFk7z3s0iVJ3 BDxXPEhBNNweOuNOCmzh6nwktS0iiOLchBOy0yH24q0bn4XU/iGdFlLAjchZtuz0E5KwfOeg4n3BZ qg32O0Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJ2OM-00000008sC9-1j2b; Tue, 20 Oct 2026 05:28:06 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJ2OJ-00000008sB2-0gTI for linux-mediatek@lists.infradead.org; Tue, 20 Oct 2026 05:28:05 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2e946155442so22922125ad.3 for ; Mon, 19 Oct 2026 22:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792474082; x=1793078882; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=5l6pqreEYh+0Dsa58mvKfgN8V+MvlUn6xbXr6Z0vjIA=; b=WU4IXcPQG9bGTWYwR2XZowd4WLRH8MVPcfaDxbIZ9ChnyIh0Ql0+eL0XFoD2BR05Me cr+iHNW3sryxHvX6aFE+23ukAzNBm8FcCLdwzgLzydNMnowTkrz0Jfx4cm/3kqJDF78A vs0k3RWpuxG+rGfcri2EJze0zmdwpEHqGsgrz+c8edIS5Ck7RAhzGfiiBNl1FxLtwj8q Ja4zhE9EMTwqO9idytEWnDnEdMaoo7Q0VTThWxVGXr56KoeM+0P8nOuNBi/4VSz0vElx 42oJMh0LKBqv8G4NqdW6KxnG8C9h/ttQ3ZoCjeVNPCrISL2CRXThFM/vkcGVr0Ls5Py3 CaRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792474082; x=1793078882; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5l6pqreEYh+0Dsa58mvKfgN8V+MvlUn6xbXr6Z0vjIA=; b=sVHhvrYUVNoZT6acLsGqWtp4lybf3FideTRYEN3VEUssIrMmyD5/0WnH0tDRqOTFdJ Q+UbC8ZdBL2ut20tXEX79gSF573fS3fkghs+Grjsvf2vw2TtLaPEZS5kYtH3tiTKIfuK t8k795cgXY7rF3rZuwYP+xmvbgHPT03aQaWsOaS1OTeM3KUsq/KFCRHaaeckZxIFYRY9 EP6zyFk2MYcO8xslVCBrWot+JDLD/Rq05QFJMk1U4JOJThEmeDQBZ5Kk/utL4O/9XXud J7XXeahleH12hYr1LHvh/2pzTifQtojioexukIljUKLsHUQRgmb8L20yr54JpO2KEpOR G4yQ== X-Forwarded-Encrypted: i=1; AKwUvByp+hjkm8CEVQ3Y/+8YRHYmdcK6gAFhQiXOcxNWIfm0S9ZJ0g/WWZBCTTEqglp7lbw4VeTqo2T/ZH1R6bSbtQ==@lists.infradead.org X-Gm-Message-State: AFq9FYI4EudYjdB9s3Tn5P+nNIoYp50ZdPJBIp9RL9QXRiMuJypLhU+/ xe7Ky3cCz7Js1HYoZQS/e7Igfc/W18Sq9KZWiC8lESKr1VtVrSYv65QD X-Gm-Gg: AYBFou0B4Ri7WaVW67OWRzrgGqNkrYNPePVIzdD63DF5GbNomcO4TZioBF6SFcCa90F dSR12r0cSU5Zb+QJBkVo0j/Xm93hKCKNNeW7sf+r5nax9LQHc8hhpqvZgAlmHlnrCJFGsvP6Mak cDTGWHmiwqrUhrTX4RbOr4uM55endwyQ3dK6ONyHbQHUH61G7bO5BWFMcV1XgUoFfdxma4mRCKf N+WPXDsFne9Z6bSbRcMPU038BFTSS6OiLNevxUNs/iy3hv2cdJcH9Z1O+7m/cjnuJdaNEQMDNFi A1996KgTDn6t3/42IfeRI8Oq20bYcYjYYc8G0s9PoBPKVT1RhZXr5vx/EKp3d8U2rb2HL2Dk4WI MZP2iwnht/5tpmj5ZU1hxp2ExAb8u1KLh1bk5icoli/GEzjTHJf9GvkKijoTeramRyULUScyuCo CMN32d2fcHrfb9vx5HwbozZrWzU530q86A+8DCMGo6nGYDRR7qO8p9wdBzj407f8VdL4TfqaRG6 U07yo1sx2UqmzRbwhF+0JcQ9KOeDQy4EzJbF9oe0hhvjtrMxKaOFehOdUUZRK3tYBNxJ6czcLzx q+kco6JUQNBJKw== X-Received: by 2002:a17:903:fab:b0:2e9:5507:b532 with SMTP id d9443c01a7336-2e9a6f587c4mr80082375ad.43.1792474082176; Mon, 19 Oct 2026 22:28:02 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ea1fd8a55asm3333995ad.29.2026.10.19.22.27.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2026 22:28:01 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , cassiogabrielcontato@gmail.com, Mukesh Ojha , Liviu Dudau , Cyril Chao , Darren Ye , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] ASoC: mediatek: mt8196: Ensure the DAI is marked as started on success Date: Tue, 20 Oct 2026 12:27:47 +0700 Message-ID: <20261020052747.568770-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261019_222803_224280_2A53C650 X-CRM114-Status: GOOD ( 13.01 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from mt8196_fe_startup(). ASoC only treats 0 as success when marking the DAI as started, so .shutdown() can be skipped on rollback. Propagate constraint errors and return 0 explicitly on success. Fixes: 57513aabfe5b ("ASoC: mediatek: mt8196: add platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8196/mt8196-afe-pcm.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/sound/soc/mediatek/mt8196/mt8196-afe-pcm.c b/sound/soc/mediatek/mt8196/mt8196-afe-pcm.c index fbeba01b086c..f69ea22cfabb 100644 --- a/sound/soc/mediatek/mt8196/mt8196-afe-pcm.c +++ b/sound/soc/mediatek/mt8196/mt8196-afe-pcm.c @@ -161,8 +161,10 @@ static int mt8196_fe_startup(struct snd_pcm_substream *substream, ret = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS); - if (ret < 0) - dev_warn(afe->dev, "snd_pcm_hw_constraint_integer failed\n"); + if (ret < 0) { + dev_err(afe->dev, "snd_pcm_hw_constraint_integer failed\n"); + return ret; + } /* dynamic allocate irq to memif */ if (memif->irq_usage < 0) { @@ -173,10 +175,16 @@ static int mt8196_fe_startup(struct snd_pcm_substream *substream, memif->irq_usage = irq_id; } else { dev_err(afe->dev, "no more asys irq\n"); - ret = -EBUSY; + return -EBUSY; } } - return ret; + + /* + * ASoC only marks the DAI as started when .startup() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .shutdown() is not skipped on rollback. + */ + return 0; } static void mt8196_fe_shutdown(struct snd_pcm_substream *substream, -- 2.43.0