From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F226606A320 for ; Wed, 21 Oct 2026 02:32:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=KLsMs1HE; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=diMBHzPq DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5BIOTNs2nezs/HO6l5CjGvSoFAHf9bcbJ2W8/ufQESo=; b=KLsMs1HEp9YTwWVAyLnhUxANUK YY6idbNPmJkFV7DvGEd3GfzXBiyWSz8Z39wiExSQsec8RWkxZ5uD0Fjkdop6seKlxFTXu7+oqlzXA LmIPhvPNWL257KyHZ7w4QT3NzByiq5hd9/J8PUsZT8TMoMDnjGpMaBZOG8xS/dJkMlIuxh7+xkFvr k076UFgxxJJNoeJvXb8OXnmAGnjTurajMXNiO8ctf5n6SLXgnoi+UkNRKFeTNaZNOVvTC/DwsgIZP 4kDV9A02ZF6KGtWPwuf2V0FJfJqNh5FBtVi+0VXCN88sldb7AccMOvmX0inxmHTPwchfFLqKJe5dk aaKNWPhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJM8I-0000000AwrB-3TY3; Wed, 21 Oct 2026 02:32:50 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJM8H-0000000Awqm-1hgU; Wed, 21 Oct 2026 02:32:49 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id E737E6021D; Wed, 21 Oct 2026 02:32:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BDC51F000C9; Wed, 21 Oct 2026 02:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792549966; bh=5BIOTNs2nezs/HO6l5CjGvSoFAHf9bcbJ2W8/ufQESo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=diMBHzPqA9Vic4uQ8X89NL3ds5Erirm7bqnEMM9F8MaK4G/aHh7ZF7+0MNhKPS5hx 61KHv4SAHm5DleXqB3A5Pb5b97wVpin7wwzKB/IhRpj100ytyHJOHe6yljwTwRgIpU Bnfmb1fiu/qCs8yx7OaHzQNHZjvPuAJJoMCtLaTlUVeI1N9NAd+d9vb5i73u4H74ij /ptFC2xgm/gSE/LtGv++LlJCqefvj9tWCaNWD2JSVKLXXM5Pp2M4vzAeSKRSuf9jUv 7O4SHv3g7ONDCg75OLq/XCrHshK6pcEzM8AXFmF+JjKvgMeYDNDiE6X/ISW+SykxO7 NTNYOoWHNSn7A== Date: Tue, 20 Oct 2026 21:32:45 -0500 From: Rob Herring To: Luca Leonardo Scorcia Cc: linux-mediatek@lists.infradead.org, Krzysztof Kozlowski , AngeloGioacchino Del Regno , Dmitry Torokhov , Krzysztof Kozlowski , Conor Dooley , Sen Chu , Sean Wang , Macpaul Lin , Lee Jones , Matthias Brugger , Liam Girdwood , Mark Brown , Linus Walleij , Val Packett , Fabien Parent , Akari Tsuyukusa , Chen Zhong , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, mfd@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH RESEND v10 1/9] dt-bindings: mfd: mt6397: Add MT6392 PMIC Message-ID: <20261021023245.GA3650393-robh@kernel.org> References: <20261020173556.632798-1-l.scorcia@gmail.com> <20261020173556.632798-2-l.scorcia@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261020173556.632798-2-l.scorcia@gmail.com> X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Tue, Oct 20, 2026 at 07:33:22PM +0200, Luca Leonardo Scorcia wrote: > Describe the MT6392 PMIC and its RTC and regulator devices. This device > is mostly based on MT6323 with some similarities to MT6397 and is usually > found on boards using the MT8516/MT8167 SoC. > > Signed-off-by: Luca Leonardo Scorcia > Reviewed-by: Krzysztof Kozlowski > Reviewed-by: AngeloGioacchino Del Regno > --- > .../bindings/mfd/mediatek,mt6397.yaml | 72 +++++++++++++++++++ > 1 file changed, 72 insertions(+) You need to reorder your patches to avoid errors. > > diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml > index 3cbc0dc12c31..06e93c545e3b 100644 > --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml > +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml > @@ -39,6 +39,7 @@ properties: > - mediatek,mt6328 > - mediatek,mt6358 > - mediatek,mt6359 > + - mediatek,mt6392 > - mediatek,mt6397 > - items: > - enum: > @@ -72,6 +73,10 @@ properties: > - mediatek,mt6331-rtc > - mediatek,mt6358-rtc > - mediatek,mt6397-rtc > + - items: > + - enum: > + - mediatek,mt6392-rtc > + - const: mediatek,mt6323-rtc > - items: > - enum: > - mediatek,mt6359-rtc > @@ -99,6 +104,7 @@ properties: > - mediatek,mt6331-regulator > - mediatek,mt6358-regulator > - mediatek,mt6359-regulator > + - mediatek,mt6392-regulator > - mediatek,mt6397-regulator > - items: > - enum: > @@ -663,3 +669,69 @@ examples: > compatible = "mediatek,mt6397-rtc"; > }; > }; > + > + - | > + #include > + #include > + > + pmic { > + compatible = "mediatek,mt6392"; Or drop the example. Is this one really different enough from the existing example(s)? > + > + interrupts-extended = <&pio 28 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + keys { > + compatible = "mediatek,mt6392-keys"; > + > + key-power { > + linux,keycodes = ; > + wakeup-source; > + }; > + > + key-home { > + linux,keycodes = ; > + wakeup-source; > + }; > + }; > + > + pinctrl { > + compatible = "mediatek,mt6392-pinctrl"; > + > + gpio-controller; > + #gpio-cells = <2>; > + }; > + > + regulators { > + compatible = "mediatek,mt6392-regulator"; > + > + vproc { > + regulator-allowed-modes = <0 1>; > + regulator-initial-mode = <0>; > + regulator-min-microvolt = < 700000>; > + regulator-max-microvolt = <1350000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + // ... > + > + vadc18 { > + regulator-allowed-modes = <0 2>; > + regulator-initial-mode = <0>; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + vefuse { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2000000>; > + }; > + }; > + > + rtc { > + compatible = "mediatek,mt6392-rtc", "mediatek,mt6323-rtc"; > + }; > + }; > -- > 2.43.0 >