From: Francesco Palmarini via B4 Relay <devnull+palmarini.unive.it@kernel.org>
To: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Ryder Lee <ryder.lee@mediatek.com>
Cc: Shayne Chen <shayne.chen@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Francesco Palmarini <palmarini@unive.it>
Subject: [PATCH 2/2] wifi: mt76: mt7615: release patch semaphore on timeout
Date: Sun, 25 Oct 2026 12:32:32 +0000 [thread overview]
Message-ID: <20261025-mt7622-patch-sem-v1-2-e16e31c1face@unive.it> (raw)
In-Reply-To: <20261025-mt7622-patch-sem-v1-0-e16e31c1face@unive.it>
From: Francesco Palmarini <palmarini@unive.it>
If the PATCH_SEM_CONTROL reply gets lost, the rom may still have granted
the semaphore and every following attempt fails with
PATCH_NOT_DL_SEM_FAIL. Release it on timeout so the next retry can get
it again.
Signed-off-by: Francesco Palmarini <palmarini@unive.it>
---
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index aab4303fe..5f5e29f49 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -1259,6 +1259,10 @@ static int mt7615_load_patch(struct mt7615_dev *dev, u32 addr, const char *name)
goto release_fw;
case PATCH_NOT_DL_SEM_SUCCESS:
break;
+ case -ETIMEDOUT:
+ /* rom might have granted the semaphore anyway */
+ mt76_connac_mcu_patch_sem_ctrl(&dev->mt76, false);
+ fallthrough;
default:
dev_err(dev->mt76.dev, "Failed to get patch semaphore\n");
ret = -EAGAIN;
--
2.39.5
prev parent reply other threads:[~2026-10-25 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 12:32 [PATCH 0/2] wifi: mt76: mt7615: fix mt7622 wmac init Francesco Palmarini via B4 Relay
2026-10-25 12:32 ` [PATCH 1/2] wifi: mt76: mt7615: fix lost first mcu event on mt7622 Francesco Palmarini via B4 Relay
2026-10-25 12:32 ` Francesco Palmarini via B4 Relay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261025-mt7622-patch-sem-v1-2-e16e31c1face@unive.it \
--to=devnull+palmarini.unive.it@kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=palmarini@unive.it \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox