From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8232F606A31F for ; Tue, 27 Oct 2026 05:10:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=G+djQe23; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=GhHbrh+q DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=EhQnVDe9USo4MEDAt10lIRyoDXqtd5qy3HB/D8OuXxY=; b=G+djQe23DJAXSi P3Je+hSQlprdInlKwUXYSE/OBF6Q6hr2NAiuPskTQhGM2yzBcHlXGiirv24VrQ9VUvJQbidCM4xxk f1qj7BfGMAZqMbJpxacxzJ9U+2WEcbaegNCmFk1OWIL09x4hiOayhIT2c3CMvzkU5z1x/S28IUcE6 zw9D2TMovEmYRrASEzIvSuAVAgo8da7LdZCD0tt4e5m/kojaANM1mRF66VShazpv8HSagwwwtmn8d CeEV7OUaOg+H9iyXyAnAEGSA4hSW5LRoY+9X4yrkxWBwbUaylOir2uCFbHiKQ2/ReRuAg4NVl02Ix c4NESgMawOA6UtgqwBjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLZRw-00000003lRi-19hi; Tue, 27 Oct 2026 05:10:16 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLZRt-00000003lR1-2MI6 for linux-mediatek@lists.infradead.org; Tue, 27 Oct 2026 05:10:14 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-cc4be0e5351so1232684a12.0 for ; Mon, 26 Oct 2026 22:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1793077812; x=1793682612; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EhQnVDe9USo4MEDAt10lIRyoDXqtd5qy3HB/D8OuXxY=; b=GhHbrh+qCTH8thLcNu32DOhpZv9OJeuiUYDiklNyetLIAySvm6Jd1KnasZa85tZmFd wh8DlgfwrJpxMhhFfr/laFrKFqcoTkPfHNoXm8StD86q/+wyW3K54aE3gV4tRpoAEssi 980MT/pRJe0uoo3hrR8/7l+kIQsjQg99tAgWf54aJfgePQjK9eee/M9jdvvpRVUtjK7k ttzsosTjxKrafysrgTWbyizlWHUMlvUS1WhzStk68PtRfMHTgPua4hfizY4y7wl1+oVv cjW359g9jg0biuFr2I8MtZZvUSEQ1T99I3OHNLTZ4iDtkFtHXqgA0Eo4DIhlm4W+Japt 2UDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793077812; x=1793682612; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=EhQnVDe9USo4MEDAt10lIRyoDXqtd5qy3HB/D8OuXxY=; b=02vm7TYBb9mmWun3qesAaK/5HlJVzWstGVckDpTrpnT5Bq6Y7CQVBbaai4+0yQn9aR M+LP4Hip8hxynqqiol+1h5VU2NLo2DX8Fa+ey9a/tFwadYNpnrgRf0RPLsze+qFDaKHX 0rEYqhv4ZDYee7uBhYzxPfbt40xD4h10IZ+duoR9amhpyI5lkz4iBNoNzCcfeyZlYYf6 5CQFhMgHEnUEGLCf0l4LZYdeOOOIJN9p6KLBjCDRFJDG7sLMtDHTP/yufgcxpZB9ab43 sQ57hOD+OxBX5nplT3RmE/yrsl1QnyhYgNREkdalwCMdma1GyOq9D22PWaYlu0ZNGhbr 5egw== X-Forwarded-Encrypted: i=1; AKwUvBz6ov/4oPAyusAQNdqao8f5stzf2RqrGhn/uBziE1dW3z+7JC1O6U42AdPHBs9FgCA/kocFNuecJSh3t2Jrdw==@lists.infradead.org X-Gm-Message-State: AFq9FYIdToUqvg6R83VoM1vl6Is3Y4ETj8TlDWCVbGUtJq+wU1tl9xkz +/TkfCQ1e3/oGWbybqyV6qyiSMAipz2Ehb40ZKTWMQMrRnFK4ZNR9YiH X-Gm-Gg: AYBFou3mnS3KSBxcnoTRR7RIod1WatcxAd1kiCxCJn7v/ssPP1rsYQ1kmoGhsbp8tol WaqSeD0QrrwSD53016evyXq2AQiA1ky9NYrriGTTp7JZbOxgmBacWU/wN4ez1L2YbE37JaRKKj/ ArC4oURPTIx5hkpuMcaexg3KXFNpmVMP9uoLxawQFU3iTBcsjO/uNTJ7BIwC04I1E+Hdm1r2ij8 0iNpMg9UXQrYWNjbHBL2stjC5DQsC34apwP9TaAguLueIytTVRgcbtt3c/uSNypOogGI5l3TBvl 3YlJf+dinQ17slikOA8yTKonEVvi936M6k97kEAEy1HX6mhTCWxSa1Um8I5Zf1R1Cu7rFX/en02 c2INtKJW0Kp42Qh9MYgejo2Q0XFzDK1PLcGz33PDfTY5jBoUU6OOtbacOA+QZVlu9Q2eKAxKzim E/eM6iPGSTgqKAiS1pshT3LEe6HnTWIRi3Q2g+5lJTvlkcMQh43n3nh1VmbZ003xwEz3Oc4RDIa 1+/cmFXuzlKHQ3IuCfdkOv1lwHO38JwvKiP6Q== X-Received: by 2002:a17:90b:3b45:b0:3a8:7096:9b48 with SMTP id 98e67ed59e1d1-3ade9b2cff5mr8125294a91.1.1793077812053; Mon, 26 Oct 2026 22:10:12 -0700 (PDT) Received: from plex ([2406:6d00:a27c:4200::7be]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae404556fbsm1893858a91.11.2026.10.26.22.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 22:10:11 -0700 (PDT) From: Chris Scott To: lorenzo@kernel.org Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, pawlik.dan@gmail.com, zhengping.zhang@airoha.com Subject: Re: [RFC net-next 2/3] net: airoha: npu: attach a coherent pool in the NPU window Date: Tue, 27 Oct 2026 15:10:02 +1000 Message-ID: <20261027051002.3360392-1-gilroyscott1970@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: <20261024154150.45733-1-gilroyscott1970@gmail.com> <20261024154150.45733-3-gilroyscott1970@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261026_221013_612506_E360D401 X-CRM114-Status: UNSURE ( 7.70 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon, Oct 26, 2026, Lorenzo Bianconi wrote: > nit: what about creating a dedicated routine for both firmware and dma > memory regions. Something like: > > +static int airoha_npu_reserve_mem_region(struct device *dev, > + struct resource *res) [...] Hi Lorenzo, Thanks for the review. Sure, I will move both into airoha_npu_reserve_mem_region() in v1. The pool attach then moves ahead of dma_set_mask_and_coherent(), which is fine since nothing allocates coherent memory in between. v1 will follow once net-next reopens, together with a binding fix from the Sashiko review of 1/3. Regards, Chris