From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3453F606A31C for ; Mon, 9 Nov 2026 04:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=zT9ngv3b; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=j9364OTQ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=yZy6juQ/C2+U+L3WTVvMgyAkJHBU1cX+JxwPunI95Oc=; b=zT9ngv3btielEZ piSUgFXNIwntbiftl96UVa1nzr+fALnvDG8ngkLPF0vtZlvjV/vVU9SeqTnglKonBI+HSmThRo1VM DbmClWEMJop4iDHSJ1SfzEorcu6lYZDApdLByxzbgSFDwb4U4dtx+YAUdKUPgO2HImUcdiFZ6LrUG 8lHSMAaXIYo66r+GVeEtvreu+LIPHRSmnjzOHjuxrLvem31ZDIqq+sNvFYv9lOV8/Yp/bA9kMUXXH MD0UBsBXwkyNOTVlKCJxBUG4YJDlx+iWQ79qcngtC5Uj7ecXANFLD2N2Zoqx7keEYAy1gzB3O1yQG tL9cb+cejFvFc39yUPyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQHDa-0000000HL6e-3ipu; Mon, 09 Nov 2026 04:42:54 +0000 Received: from mail-dy1-x132f.google.com ([2607:f8b0:4864:20::132f]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQHDX-0000000HL31-2uBd for linux-mediatek@lists.infradead.org; Mon, 09 Nov 2026 04:42:52 +0000 Received: by mail-dy1-x132f.google.com with SMTP id 5a478bee46e88-3700ed8dbe3so1185589eec.0 for ; Sun, 08 Nov 2026 20:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794199370; x=1794804170; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yZy6juQ/C2+U+L3WTVvMgyAkJHBU1cX+JxwPunI95Oc=; b=j9364OTQTl+8ipaC0kek7uaL39h0a+AAiqcSFWqHOMiGSS6IXCOMpcaM0G1c0LCW7t 35kdpDkooO8If8dvHT/ik7FJUsMyph1l7IDtq+xHO0YRUYlQZQq8L+6hHChK4F46V4ap IIHPtn82gKCY/Z9JEPeo80sxU0+e075wPR1ODEPAZi9Ih0MLdqQDBeXyp/30r+kpnfzp iSM+y+b6GNVqiwOrNvtovNjFK2l8/Ss4regIfEdOLV8hEFUJnLEbSTFOrAxklHLC034R /L9mCvkO47NpCYjXYj8OhpUmwULRlCe6UULfzJGtBmm0GQuhXebf9gHDX6Y3Q7m0ooRg d/Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794199370; x=1794804170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yZy6juQ/C2+U+L3WTVvMgyAkJHBU1cX+JxwPunI95Oc=; b=DJM12j1SKhljrlD+ujhPOfmlfT+/rF9LLS7tL4bvdZT5HFN/qXEwt/ER0f0LTyaS04 a+sk03cHZ8+nPZUij1kg7I78iJJ83IDBk/pvvmPMhUOVB4buKA8m61NpMMUTJb51NlSN lsXtrSc5hNawaXM6u5kWecyvQDfj9WYvjlT8RDScD8b5gPkJCdh0Zc2KqIBQ86J5O8Y/ 8NbAnyd53MKzq2sHJmcZZ2KShzoqQ1AXIpuas1PngrS4TDCZmLUujUDCTKhrg7SGIOg7 pF4IGx74UdIRS9FblQHYji+Py7cQPSTYtjOQSEasvNvbsUsm9DUpwLSNx041MhsTvY5S 2/8w== X-Forwarded-Encrypted: i=1; AL+hErFbZZkU2glRsxA+hkg3G/DZivQxLyxkLlO2vcWi2mh1z1v1cZMkhBxY4kCpVozDkiD2aIMNJ/BB+pf4ZZ/55w==@lists.infradead.org X-Gm-Message-State: APuU4Z8xVeEV0Catsi524t0erMU4bDtB19221MEjZ76YQ8DL/9P9T0PQ FLWeHMt/oydH+9UgZSTYBMf3ZrYyshGPxWtfvrRrBGYCpXVUl6RH8/LA X-Gm-Gg: AYBFou2R9+U1Qp2QlBSIFw7Jsn7RuBknLR3WYN4hzkJbZwvp1jLzXJbsoIJVhU691J6 UqP+jL1c8U1NlO+nF6gGRbSUx4v/aVeE+nkKGYpxO+gYzF5vYs+UehLaxsFeMI7F3ocGXyvaov4 3QPHkHnPAnAHOhT/Z9JnL1rJGf/zKVDtcoBgeILs2VMcfgu5e9UNQ/u/bO4KcslO0ircZey3+I0 VbJWjJ+pFVx4SpR6fryHJAny2Ca0jCIt2pNvd0Jnx5xbNIKOe9l5YAtxV1d2QqqR94hu3jVqqk8 KyzW4QBDh3bUPHWcQO1aAtQqXKjEOsf+KaD/xSShoU2Ma4VfVZ4jxjhBYO2vmX7SEXnYDhUlm5a J4LSe8iouu79WtPJcEKyRzromxO8L80GtSA+HDQPK0J1fIsSOqloC1Z98ZLtEKkhj3aZ7GDvrgf 7lEO+Yen6ckKtZTVKmpCwcuO11LBgHGvrV8mHhftztyC15KzP8kqs1CRJTPeKQPz5ec1x/1qpSB tvbDsFXP3eCW3ktNcKbWg7e/A9gG+R0sLMWQCrDglwoXxxi+N7S1JT/s7PtWHUEtjm76bjMhN5V ryajRjGJgmlenWLdA/j/SeVEtyYnYCX4PDppg58HrZgldcFA X-Received: by 2002:a05:7300:da10:b0:36e:8e6d:a0c0 with SMTP id 5a478bee46e88-3725dd59dd2mr5386387eec.19.1794199370484; Sun, 08 Nov 2026 20:42:50 -0800 (PST) Received: from hj.. ([163.239.22.29]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3726561851esm10154026eec.4.2026.11.08.20.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Nov 2026 20:42:50 -0800 (PST) From: hyunjungg To: Sebastian Reichel , linux-pm@vger.kernel.org Cc: Sebastian Reichel , Chen-Yu Tsai , Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Hyunjung Ko , stable@vger.kernel.org Subject: [PATCH v2 3/3] power: supply: mt6360_charger: drain chrdet_work before unregistering the supply Date: Mon, 9 Nov 2026 13:42:12 +0900 Message-ID: <20261109044212.1157357-4-hj351016@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261109044212.1157357-1-hj351016@gmail.com> References: <20261109044212.1157357-1-hj351016@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261108_204251_768377_9F42EA05 X-CRM114-Status: GOOD ( 10.31 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 From: Hyunjung Ko mt6360_charger_probe() registers chrdet_work for devm cancellation before devm_power_supply_register(). devres unwinds in reverse, so on unbind the power supply is freed first and the work cancelled last. mt6360_chrdet_work() calls power_supply_changed(mci->psy), so the work running in that window dereferences the freed supply. Register the work cancellation after the power supply so devres drains it first. chrdet_work is only scheduled later in probe, so the move is safe. Fixes: 0402e8ebb8b8 ("power: supply: mt6360_charger: add MT6360 charger support") Cc: stable@vger.kernel.org Signed-off-by: Hyunjung Ko --- diff --git a/drivers/power/supply/mt6360_charger.c b/drivers/power/supply/mt6360_charger.c index b4d462343151..71c60ba012df 100644 --- a/drivers/power/supply/mt6360_charger.c +++ b/drivers/power/supply/mt6360_charger.c @@ -790,9 +790,6 @@ static int mt6360_charger_probe(struct platform_device *pdev) mci->vinovp = 6500000; mutex_init(&mci->chgdet_lock); platform_set_drvdata(pdev, mci); - ret = devm_work_autocancel(&pdev->dev, &mci->chrdet_work, mt6360_chrdet_work); - if (ret) - return dev_err_probe(&pdev->dev, ret, "Failed to set delayed work\n"); ret = device_property_read_u32(&pdev->dev, "richtek,vinovp-microvolt", &mci->vinovp); if (ret) @@ -828,6 +825,10 @@ static int mt6360_charger_probe(struct platform_device *pdev) if (IS_ERR(mci->otg_rdev)) return PTR_ERR(mci->otg_rdev); + ret = devm_work_autocancel(&pdev->dev, &mci->chrdet_work, mt6360_chrdet_work); + if (ret) + return dev_err_probe(&pdev->dev, ret, "Failed to set delayed work\n"); + schedule_work(&mci->chrdet_work); return 0; -- 2.43.0