From: Emery Hsin <emery.hsin@mediatek.com>
To: <nbd@nbd.name>, <lorenzo@kernel.org>
Cc: <Sean.Wang@mediatek.com>, <jb.tsai@mediatek.com>,
<Quan.Zhou@mediatek.com>, <linux-wireless@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
Emery Hsin <emery.hsin@mediatek.com>
Subject: [PATCH] wifi: mt76: mt792x: drop redundant MCU restart before firmware download
Date: Tue, 10 Nov 2026 11:07:37 +0800 [thread overview]
Message-ID: <20261110030737.367177-1-emery.hsin@mediatek.com> (raw)
Resetting the MCU state before firmware download is the legacy approach
and causes problems on MT7928. The wfsys reset at probe already leaves
the chip in a clean state, so drop the MCU restart and FW_PWR_ON poll.
Fixes: 9eef868b86db ("wifi: mt76: mt792x: ensure MCU ready before ROM patch download")
Signed-off-by: Emery Hsin <emery.hsin@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/mt792x_core.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt792x_core.c b/drivers/net/wireless/mediatek/mt76/mt792x_core.c
index 80756aa8d99d..1965e9de7099 100644
--- a/drivers/net/wireless/mediatek/mt76/mt792x_core.c
+++ b/drivers/net/wireless/mediatek/mt76/mt792x_core.c
@@ -1135,13 +1135,6 @@ int mt792x_load_firmware(struct mt792x_dev *dev)
{
int ret;
- mt76_connac_mcu_restart(&dev->mt76);
-
- if (!mt76_poll_msec(dev, MT_CONN_ON_MISC, MT_TOP_MISC_FW_STATE,
- MT_TOP_MISC2_FW_PWR_ON, 1000))
- dev_warn(dev->mt76.dev,
- "MCU is not ready for firmware download\n");
-
if (is_mt7928(&dev->mt76)) {
dev_info(dev->mt76.dev, "Loading CB firmware patch: %s\n",
mt792x_cb_patch_name(dev));
--
2.45.2
reply other threads:[~2026-11-10 3:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110030737.367177-1-emery.hsin@mediatek.com \
--to=emery.hsin@mediatek.com \
--cc=Quan.Zhou@mediatek.com \
--cc=Sean.Wang@mediatek.com \
--cc=jb.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox