From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C0D606A33B for ; Wed, 11 Nov 2026 08:57:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HdjjmOUc DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=Ca4JklKbmUPAZuKF/cxiCrQi6UVL+WjieUsmSP5loTY=; b=HdjjmOUckPU1VV y2I6JHX2qKMb0vcYFXEw/qfnYfg6wAlsTQ69JH+J8yw3OaNNlUbH1b6OkTcwIg2X2DT9A/FUPNGpP favmPweRRFjY+rGNyKhV9390qel2tm/VuqpVJBtHr1ceQKTa7DH83hh3YPjLtGstp0EAAd8u/99rA fJjXXkWQreiemgwILSzzGvSN493L6H7AmSSCfOBgz5yqBo+B1MkQD/tXSmIHm0QJKsYsFsB/84fy5 UxfNeosVTXMn+VsTM3vXrsmTAwmk+xVIQD4VNFl7abz2/ZdDcVyB+AscN6rF3GcifEzFHe8yhIIR0 StKekop7suo+0V4RqyIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xR48l-000000066Bh-0iQc; Wed, 11 Nov 2026 08:57:11 +0000 Received: from nbd.name ([46.4.11.11]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xR48g-00000006678-3aga; Wed, 11 Nov 2026 08:57:07 +0000 Received: from [2a04:4540:1401:33fc:b262:f9a8:847e:6650] (helo=bertha10..) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1xR48R-001TSi-2D; Wed, 11 Nov 2026 09:56:51 +0100 From: John Crispin To: Stephen Boyd , Brian Masney , Jerome Brunet , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno Cc: Christian Marangi , lei.dong@airoha.com, Linqi.zhang@airoha.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Lorenzo Bianconi , Rajeev.kumar@airoha.com, upstream@airoha.com, Weifeng.xu@airoha.com, zhengping.zhang@airoha.com Subject: [PATCH 2/2] clk: en7523: add a reset operation Date: Wed, 11 Nov 2026 09:56:50 +0100 Message-Id: <20261111085650.632025-3-john@phrozen.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20261111085650.632025-1-john@phrozen.org> References: <20261111085650.632025-1-john@phrozen.org> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261111_005706_913972_2C770D74 X-CRM114-Status: GOOD ( 10.63 ) X-Spam-Score: -1.9 (-) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 The reset controller implements assert, deassert and status but not reset, so device_reset() fails with -ENOTSUPP. The i2c-mt7621 driver calls it at probe and after a transfer timeout. Every I2C bus that references an SCU reset, as on the EN7581 and the AN7589, therefore logs "I2C reset failed!" and is never reset. Add a reset operation that asserts and then deasserts the line, as the MT7621 reset controller does for the same I2C block. Signed-off-by: John Crispin --- drivers/clk/clk-en7523.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c index 8f63482cbb7b..eb893259d470 100644 --- a/drivers/clk/clk-en7523.c +++ b/drivers/clk/clk-en7523.c @@ -818,6 +818,18 @@ static int en7523_reset_deassert(struct reset_controller_dev *rcdev, return en7523_reset_update(rcdev, id, false); } +static int en7523_reset_reset(struct reset_controller_dev *rcdev, + unsigned long id) +{ + int ret; + + ret = en7523_reset_assert(rcdev, id); + if (ret) + return ret; + + return en7523_reset_deassert(rcdev, id); +} + static int en7523_reset_status(struct reset_controller_dev *rcdev, unsigned long id) { @@ -847,6 +859,7 @@ static int en7523_reset_xlate(struct reset_controller_dev *rcdev, } static const struct reset_control_ops en7581_reset_ops = { + .reset = en7523_reset_reset, .assert = en7523_reset_assert, .deassert = en7523_reset_deassert, .status = en7523_reset_status, -- 2.34.1