Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Daniel Stone <daniels@collabora.com>,
	Manasi Navare <navaremanasi@google.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Mark Yacoub <markyacoub@google.com>,
	Sean Paul <seanpaul@google.com>,
	Drew Davenport <ddavenport@google.com>,
	Louis Chauvet <louis.chauvet@bootlin.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC v3 0/8] Add support for DisplayPort link training information report
Date: Mon, 16 Nov 2026 17:49:31 +0200	[thread overview]
Message-ID: <20261116154931.GA1763340@killaraus.ideasonboard.com> (raw)
In-Reply-To: <dfe3ce17-8153-4cd1-b9df-fe0d61cec9c4@bootlin.com>

On Mon, Nov 16, 2026 at 04:13:52PM +0100, Kory Maincent wrote:
> On 11/16/26 14:10, Jani Nikula wrote:
> > On Mon, 12 Oct 2026, Kory Maincent <kory.maincent@bootlin.com> wrote:
> >> DisplayPort link training negotiates the physical-layer parameters needed
> >> for a reliable connection: lane count, link rate, and optionally Display
> >> Stream Compression (DSC). Currently, each driver exposes this state in
> >> its own way, often through driver-specific debugfs entries, with no
> >> standard interface for userspace diagnostic and monitoring tools.
> >>
> >> This series introduces generic helpers, for exposing DP link capabilities
> >> and state as standard sysfs entries.
> > 
> > So how did we end up with sysfs here?
> 
> In the first RFC it was in DRM properties. I presented it in the display 
> hackfest in Nice last years. People suggested to use sysfs instead but 
> if the need appears later in the development move back to DRM 
> properties. I first though DRM properties seems better as it is the user 
> interface used by distros but I had no strong argument about the change 
> to sysfs, so I moved on to it.
> 
> >> The aim of such development is to guide users to select the most suitable
> >> DisplayPort connector for their needs. For example, if you have a USB-C
> >> hub with lesser capabilities than your computer’s native DisplayPort
> >> connector (such as HBR2 versus HBR3 support), the system could recommend
> >> connecting high-resolution displays directly to the computer’s port
> >> instead of through the hub to ensure optimal performance.
> > 
> > I do wonder how all this is supposed to work in more complex real world
> > scenarios, though.
> > 
> > I believe the user primarily cares about *modes*. Which display modes
> > can be used with each display/connector pair.
> > 
> > With the low level link information, are you proposing to compute the
> > required bandwidth for modes in userspace? I think it's going to be a
> > lot of work to compute the bandwidth requirements, taking into account
> > DP SST vs. MST vs. UHBR and DSC and bit depth and everything, and you'll
> > still miss any driver/GPU specific contraints. Or are you just proposing
> > to match the physical characteristics only?
> 
> This is a requirement from Google, yes they want to compute the 
> bandwidth for modes in the userspace side.
> @Manasi could describe in detail how would you implement it?
> 
> > Given all the connectors and displays and their modes on a system, you
> > could estimate a) for each display, what modes could be used on each
> > connector, and b) for each connector, what modes could be used on a
> > display, if connected. From the user POV, they could be shown why some
> > display mode is not available on the current connector, and crucially,
> > on which connector it could be available.
> > 
> > In general, I'm wondering if you're really after higher level
> > information, something like "connector max available bandwidth
> > with/without DSC", that would more directly map to the user needs as I
> > see them than low level link details.
> > 
> > Do you have the userspace somewhere? That's needed for merging UABI
> > anyway [1].
> > 
> > [1] https://docs.kernel.org/gpu/drm-uapi.html#open-source-userspace-requirements
> 
> I wanted to add it to IGT GPU tools, but I was hopping for community 
> review on this RFC before the IGT development.

Note the following requirement:

  The open-source userspace must not be a toy/test application, but the
  real thing. Specifically it needs to handle all the usual error and
  corner cases. These are often the places where new uAPI falls apart
  and hence essential to assess the fitness of a proposed interface.

I think think IGT qualifies. An implementation in a desktop environment
would likely be needed.

> >> The new drm_dp_source_set_caps and drm_dp_sink_set_caps helper expose
> >> source and sink training capabilities to userspace via sysfs attributes
> >> under dp_link. Finally drm_dp_set_cur_link_params helper is provided to
> >> report current link information at runtime.
> >>
> >> Three drivers are updated as reference implementations: i915 (direct
> >> connector path), ANX7625 and MediaTek (via the bridge connector framework
> >> using a new DRM_BRIDGE_OP_DP flag).
> >>
> >> Here is a sysfs example:
> >>
> >> cur_link_info_dsc            sink_link_caps_nlanes
> >> cur_link_info_link_rate      source_link_caps_dsc
> >> cur_link_info_nlanes         source_link_caps_link_rates
> >> sink_link_caps_dsc           source_link_caps_nlanes
> >> sink_link_caps_link_rates
> >>
> >> 1620000 2160000 2700000 3240000 4320000 5400000
> >>
> >> 1620000 2700000 5400000 10000000 20000000
> >>
> >> 5400000
> >>
> >> This series is rebased on top of drm-misc and may conflict with the
> >> current state of the drm i915 tree. Which tree should pick this up,
> >> given that it mixes core development with driver changes?
> > 
> > For development, please just base your work on top of drm-tip, and the
> > tree(s) will be sorted out later.
> 
> Oh, ok, thanks you.

-- 
Regards,

Laurent Pinchart


      parent reply	other threads:[~2026-11-16 15:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 15:10 [PATCH RFC v3 0/8] Add support for DisplayPort link training information report Kory Maincent
2026-10-12 15:10 ` [PATCH RFC v3 1/8] drm: Move sink link rates reading helpers out of i915 Kory Maincent
2026-11-16 11:58   ` Jani Nikula
2026-10-12 15:10 ` [PATCH RFC v3 2/8] drm: Move DSC capability reading helper " Kory Maincent
2026-11-16 12:03   ` Jani Nikula
2026-10-12 15:10 ` [PATCH RFC v3 3/8] drm: Introduce DisplayPort link training capabilities and state helpers Kory Maincent
2026-10-12 15:10 ` [PATCH RFC v3 4/8] drm/i915/display/dp: Read DPCD DSC capabilities in any case Kory Maincent
2026-10-12 15:11 ` [PATCH RFC v3 5/8] drm/i915/display/dp: Use dp_connector helpers to expose link training state Kory Maincent
2026-10-12 15:11 ` [PATCH RFC v3 6/8] drm/bridge: Expose link training state via new DRM_BRIDGE_OP_DP flag Kory Maincent
2026-10-12 15:11 ` [PATCH RFC v3 7/8] drm/analogix/anx7625: Use dp_connector helpers to expose link training state Kory Maincent
2026-10-12 15:11 ` [PATCH RFC v3 8/8] drm/mediatek: " Kory Maincent
2026-11-10  9:14   ` CK Hu (胡俊光)
2026-11-16 13:10 ` [PATCH RFC v3 0/8] Add support for DisplayPort link training information report Jani Nikula
2026-11-16 15:13   ` Kory Maincent
2026-11-16 15:49     ` Jani Nikula
2026-11-16 15:49     ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116154931.GA1763340@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniels@collabora.com \
    --cc=ddavenport@google.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kory.maincent@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=markyacoub@google.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=navaremanasi@google.com \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rfoss@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=seanpaul@google.com \
    --cc=simona@ffwll.ch \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tursulin@ursulin.net \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox