From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D52CFC4345F for ; Wed, 17 Apr 2024 15:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bgB99a4HbaLSL2r+LSYMaG358qnlviysNDbI/Uiar8w=; b=C+3x5XltW7Kjz6azC8/hLWGSr/ x0NDCHBUrzWz3andqMFEVhF5pqeOmebKRWUdD2cddTJGdI/ma/TtfBe41pr1osyXz+UhdbFMryrwE N4MtPWRk9GDfq02I9KdvMRQNkYCZSc+WKxaR8lilKLdeodf/r8KaoIP3onBw5H7yvTu8YxMKDQbis MI6z/obimFxuxsnIwNGsVqIzBm1vVImb0H1z4F6pKJL9fkPWLPAHWDAWkM3udGVtvDXgdHqNTseCi iffx+vxSIdDbXb/m0fRqtSKdKub//qtCCcSWrx7lHXmNJE4W3GmnRU2KT72q8P8Y3IcXijFohaDWY F5whQeng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7HT-0000000Gbcb-1H7M; Wed, 17 Apr 2024 15:33:03 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx7HP-0000000GbbJ-3sT3; Wed, 17 Apr 2024 15:33:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713367975; bh=ijKSzKC4JBCHQVUbEr5IAP63huLyRu3EmNojTu9JoWY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pvofwZOHRzGD4VAQNK/W3l0XSZ3ufjf2JCT9QtBN/mnGiP1nzBjOmOvKoHNCG+Ns0 XKwgo5F2BTcNfQE/WQyFXmA/+4sEb5JIfrlyRRXVOkn/H9VXhmszLI3g+3ePZuSC8h 8V/yAtDVNlkwSQLX4rgP3hZTrNFNv5Cb5CtA92JOJDO1JJuOCwOz6jhGZvgQ2gmU0v 72sfNAMyjlPyJ5MI7S5bTaQB++GIBpRgI7XB4+rw2LYvRdKv/PWLHpsFQhnbzAd1pN 6TZMHsGsfcCt2NHcL9d9a+cLQKyiKNb9eo+4YzAahO7imCZA8F4itIOfF5N09RS7FU /qdBt0pV0424g== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id BB19A3780629; Wed, 17 Apr 2024 15:32:54 +0000 (UTC) Message-ID: <207eb8d7-1a40-4114-a84b-26616dc39fcc@collabora.com> Date: Wed, 17 Apr 2024 17:32:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] dt-bindings: interconnect: Add MediaTek EMI Interconnect bindings To: Rob Herring Cc: djakov@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, keescook@chromium.org, gustavoars@kernel.org, henryc.chen@mediatek.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, wenst@chromium.org, amergnat@baylibre.com References: <20240417091442.170505-1-angelogioacchino.delregno@collabora.com> <20240417091442.170505-3-angelogioacchino.delregno@collabora.com> <20240417145402.GA2355631-robh@kernel.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240417145402.GA2355631-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_083300_399996_3CA9FBAB X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 17/04/24 16:54, Rob Herring ha scritto: > On Wed, Apr 17, 2024 at 11:14:37AM +0200, AngeloGioacchino Del Regno wrote: >> Add bindings for the MediaTek External Memory Interface Interconnect, >> which providers support system bandwidth requirements through Dynamic >> Voltage Frequency Scaling Resource Collector (DVFSRC) hardware. >> >> This adds bindings for MediaTek MT8183 and MT8195 SoCs. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> .../interconnect/mediatek,mt8183-emi.yaml | 76 +++++++++++++++++++ >> .../interconnect/mediatek,mt8183.h | 23 ++++++ >> .../interconnect/mediatek,mt8195.h | 44 +++++++++++ >> 3 files changed, 143 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/interconnect/mediatek,mt8183-emi.yaml >> create mode 100644 include/dt-bindings/interconnect/mediatek,mt8183.h >> create mode 100644 include/dt-bindings/interconnect/mediatek,mt8195.h >> >> diff --git a/Documentation/devicetree/bindings/interconnect/mediatek,mt8183-emi.yaml b/Documentation/devicetree/bindings/interconnect/mediatek,mt8183-emi.yaml >> new file mode 100644 >> index 000000000000..3ad60fd21f83 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interconnect/mediatek,mt8183-emi.yaml >> @@ -0,0 +1,76 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/interconnect/mediatek,mt8183-emi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: MediaTek External Memory Interface (EMI) Interconnect >> + >> +maintainers: >> + - AngeloGioacchino Del Regno >> + >> +description: | >> + EMI interconnect providers support system bandwidth requirements through >> + Dynamic Voltage Frequency Scaling Resource Collector (DVFSRC) hardware. >> + The provider is able to communicate with the DVFSRC through Secure Monitor >> + Call (SMC). >> + >> + ICC provider ICC Nodes >> + ---- ---- >> + _________ |CPU | |--- |VPU | >> + _____ | |----- ---- | ---- >> + | |->| DRAM | ---- | ---- >> + |DRAM |->|scheduler|----- |GPU | |--- |DISP| >> + | |->| (EMI) | ---- | ---- >> + |_____|->|_________|---. ----- | ---- >> + /|\ `-|MMSYS|--|--- |VDEC| >> + | ----- | ---- >> + | | ---- >> + | change DRAM freq |--- |VENC| >> + -------- | ---- >> + SMC --> | DVFSRC | | ---- >> + -------- |--- |IMG | >> + | ---- >> + | ---- >> + |--- |CAM | >> + ---- >> + >> +properties: >> + compatible: >> + enum: >> + - mediatek,mt8183-emi >> + - mediatek,mt8195-emi >> + >> + reg: >> + maxItems: 1 >> + >> + '#interconnect-cells': >> + const: 1 >> + >> +required: >> + - compatible >> + - '#interconnect-cells' >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + system-controller@10012000 { >> + compatible = "mediatek,mt8195-dvfsrc"; >> + reg = <0 0x10012000 0 0x1000>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + emi_icc: interconnect@1 { >> + compatible = "mediatek,mt8195-emi"; >> + reg = <1>; >> + #interconnect-cells = <1>; > > > There's not really any need for this node. Just put #interconnect-cells > in the parent. > Actually, I modeled it to be a subnode of the DVFSRC for multiple reasons: 1. Some SoCs have more than one interconnect on the DVFSRC (two different kinds of EMI interconnect, and then also a SMI interconnect); and 2. Some boards will want to not enable the interconnect driver because some of those are not battery powered (so they just keep the knobs at full thrust from the bootloader and never care scaling busses); and 3. Some DVFSRC interconnect features may depend on firmware (but I'm not sure which ones and which SoCs, as there are lots of SMI/EMI ICC things that are not implemented yet with this series). The alternative would've been to add a property to enable, or disable, the SMI ICC (not present in this series), and/or one, or the other kind of EMI ICC (this series implements only the simpler EMI ICC, and I keep saying "the other" because I currently don't remember the name).... which is really ugly. Ideas? :-) Cheers, Angelo > Rob