From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: sean.wang@kernel.org, linus.walleij@linaro.org,
matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH 5/5] pinctrl: mediatek: common-v1: Commonize spec_ies_smt_set callback
Date: Mon, 21 Feb 2022 14:40:48 +0100 [thread overview]
Message-ID: <211bd3ca-f786-b161-6f3d-dc6b8471ffc7@collabora.com> (raw)
In-Reply-To: <CAGXv+5H0OkMk=1MZH3jCFSZbauJmEcgFADfDXDPf2r1wrp8wCw@mail.gmail.com>
Il 21/02/22 10:58, Chen-Yu Tsai ha scritto:
> On Thu, Feb 10, 2022 at 10:21 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>>
>> All of the MediaTek pinctrl drivers registering with pinctrl-mtk-common
>> that are offering a .spec_ies_smt_set() callback are declaring their
>> own function which is doing exactly the same on all drivers: calling
>> mtk_pconf_spec_set_ies_smt_range() with their struct and a simple check.
>>
>> Commonize this callback by adding the ies and smt structure pointers
>> to struct mtk_pinctrl_devdata and changing the callback signature to
>> take it.
>>
>> Removing the callback and checking for the existence of the spec_smt
>> and/or spec_ies data would allow us to staticize the function
>> mtk_pconf_spec_set_ies_smt_range(), but this solution was avoided as
>> to keep flexibility, as some SoCs may need to perform a very different
>> operation compared to what this commonized function is doing.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Hi Chen-Yu,
did you mean Reviewed-by? :-)
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-02-21 14:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 14:19 [PATCH 0/5] MediaTek pinctrl drivers cleanups AngeloGioacchino Del Regno
2022-02-10 14:19 ` [PATCH 1/5] pinctrl: mediatek: paris: Unify probe function by using OF match data AngeloGioacchino Del Regno
2022-02-21 4:23 ` Chen-Yu Tsai
2022-02-10 14:19 ` [PATCH 2/5] pinctrl: mediatek: common-v1: Add common probe function AngeloGioacchino Del Regno
2022-02-21 4:33 ` Chen-Yu Tsai
2022-02-10 14:19 ` [PATCH 3/5] pinctrl: mediatek: common-v1: Use " AngeloGioacchino Del Regno
2022-02-21 4:35 ` Chen-Yu Tsai
2022-02-10 14:19 ` [PATCH 4/5] pinctrl: mediatek: common-v1: Commonize spec_pupd callback AngeloGioacchino Del Regno
2022-02-21 9:57 ` Chen-Yu Tsai
2022-02-21 9:59 ` Chen-Yu Tsai
2022-02-22 2:55 ` Chen-Yu Tsai
2022-02-10 14:19 ` [PATCH 5/5] pinctrl: mediatek: common-v1: Commonize spec_ies_smt_set callback AngeloGioacchino Del Regno
2022-02-21 9:58 ` Chen-Yu Tsai
2022-02-21 13:40 ` AngeloGioacchino Del Regno [this message]
2022-02-22 2:54 ` Chen-Yu Tsai
2022-02-19 1:18 ` [PATCH 0/5] MediaTek pinctrl drivers cleanups Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211bd3ca-f786-b161-6f3d-dc6b8471ffc7@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=kernel@collabora.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox