public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Macpaul Lin" <macpaul.lin@mediatek.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Bernhard Rosenkränzer" <bero@baylibre.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Cc: Bear Wang <bear.wang@mediatek.com>,
	Pablo Sun <pablo.sun@mediatek.com>,
	Macpaul Lin <macpaul@gmail.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: arm64: dts: mediatek: mt8365-evk: update compatible
Date: Tue, 12 Sep 2023 10:08:14 +0200	[thread overview]
Message-ID: <22805138-e42a-cdd0-bc96-5281f0e2c586@linaro.org> (raw)
In-Reply-To: <20230912072340.22862-1-macpaul.lin@mediatek.com>

On 12/09/2023 09:23, Macpaul Lin wrote:
> Fix compatible of 'mediatek,mt8365-evk' from 'enum' to 'const'.

What is there to fix? There is no bug... please describe why you are
doing changes.

> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
>  Documentation/devicetree/bindings/arm/mediatek.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> change for v2:
>  - rebase this patch to follow the v5 patch set of mt8395.
>   - depends on https://lore.kernel.org/lkml/20230909132819.21626-2-macpaul.lin@mediatek.com/T/
>  - Fix description as a single board.
> 
> changes for v3:
>  - rebase this patch to follow the v6 patch set of mt8395.
>   - depends on https://lore.kernel.org/lkml/20230911115717.26184-1-macpaul.lin@mediatek.com/T/
>  - drop "Fixes:" tag in commit message.
>  - drop platform description update for mt8365-evk (Genio 350-EVK).
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 2e8ad49c3479..bab4fa0e8199 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -245,7 +245,7 @@ properties:
>                - mediatek,mt8183-pumpkin
>            - const: mediatek,mt8183
>        - items:
> -          - enum:
> +          - const:

Obviously this was not tested... Please test before sending.

Best regards,
Krzysztof



  parent reply	other threads:[~2023-09-12  8:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12  7:23 [PATCH v3 1/2] dt-bindings: arm64: dts: mediatek: mt8365-evk: update compatible Macpaul Lin
2023-09-12  7:23 ` [PATCH v3 2/2] arm64: dts: mediatek: rename mt8365-evk to mt8365-genio-350-evk Macpaul Lin
2023-09-12  8:08 ` Krzysztof Kozlowski [this message]
2023-09-12  9:36   ` [PATCH v3 1/2] dt-bindings: arm64: dts: mediatek: mt8365-evk: update compatible Macpaul Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22805138-e42a-cdd0-bc96-5281f0e2c586@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bear.wang@mediatek.com \
    --cc=bero@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=macpaul.lin@mediatek.com \
    --cc=macpaul@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=pablo.sun@mediatek.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox