From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14810C32771 for ; Fri, 19 Aug 2022 15:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=24MYTNmWKwuz612F53s8OGxxNoOr440y1r636RmtOyM=; b=1DYpuyAfMsFzfEfyKWWVBsqJKz 2+KTKs7Y7FNNCYhMgSDFDJ6MsJupLxjU3kr2wIAsQNKW1JJ3yoXxPgtKRTyOix7099GKnbUW8XIcx hU1bSmun9r6qjZmmNxocjbMOroIZxRIwm0poLVyvHSe5AJTwSxFXE6U/A+g4FKYKh7/mNUbYtPluM Hl06dfLa0R6yhnulEuyHJ0ZXbUODWjF4ZP3i4Q6UhGwTdLdr9UDucLcKNqEXnVQipRcp5D0/x3s3z 7DAiiZlwVL/4rzq3k1kO47hxW1NLO0r0efE/lUWkz7yM3xpu/MiuE5nwAFr/mko3JgxtoSD4JJOIu X9U1i3sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP3v6-009vIZ-Cq; Fri, 19 Aug 2022 15:28:24 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP3uw-009vCk-0N; Fri, 19 Aug 2022 15:28:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=24MYTNmWKwuz612F53s8OGxxNoOr440y1r636RmtOyM=; b=p/vghahIi+rGsJOOBcIrm0yvFt 0YajqQ0rLEYEnvp2xZHIGxLITHzgOXXEv4M41MX318pD2xLf6gcLiQNI09vS6bl60rwA2GWTjaCQv mxLM0ELFbzpxaMzJrb/xq0jOEuym4AOaZVkU3/CJnmE5ZwD8OhMDokLssZhE6l8fD8W61/qAvfDfS M6u4mrQh7+6QBfnjdHEB1sbLlPEGx9kkwjr0UDMvfCYbuc2drfea8G4keCpflasM8TCCm6QZTYQYv AlZxuTfljpn7GdTINGFYyc+NLCc0rFeua3I+6v+zIHZYya8ZcmJxLSXVRvpYUM4Js1B21+nTRCTGD cnR0C4pg==; Received: from [2600:1702:3c30:6ca0:77cd:43b1:3d69:dd7b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oP3uE-00BHzl-Dd; Fri, 19 Aug 2022 15:27:30 +0000 Message-ID: <245d4220-a88a-5665-c756-a5b32e5bfeae@infradead.org> Date: Fri, 19 Aug 2022 08:26:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] net: move from strlcpy with unused retval to strscpy Content-Language: en-US To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , Wolfgang Grandegger , Marc Kleine-Budde , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Kurt Kanzenbach , Steffen Klassert , David Dillow , Russell King , Ion Badulescu , Andreas Larsson , Mark Einon , Lino Sanfilippo , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jes Sorensen , Shay Agroskin , Arthur Kiyanovski , David Arinzon , Noam Dagan , Saeed Bishara , Don Fry , Tom Lendacky , Shyam Sundar S K , Igor Russkikh , Chris Snook , Michael Chan , Broadcom internal kernel review list , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Ariel Elior , Sudarsana Kalluru , Manish Chopra , Doug Berger , Siva Reddy Kallam , Prashant Sreedharan , Sunil Goutham , Raju Rangoju , Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , Hartley Sweeten , Christian Benvenuti , Govindarajulu Varadarajan <_govind@gmx.com>, Denis Kirjanov , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Madalin Bucur , Ioana Ciornei , Claudiu Manoil , Joakim Zhang , Pantelis Antoniou , Li Yang , Yisen Zhuang , Salil Mehta , Douglas Miller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nick Child , Jesse Brandeburg , Tony Nguyen , Guo-Fu Tseng , Sebastian Hesselbarth , Thomas Petazzoni , Marcin Wojtas , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Taras Chornyi , Mirko Lindner , Stephen Hemminger , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Matthias Brugger , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Ido Schimmel , Petr Machata , Bryan Whitehead , UNGLinuxDriver@microchip.com, Chris Lee , Jon Mason , Simon Horman , Rain River , Zhu Yanjun , Vladimir Zapolskiy , Rahul Verma , Shahed Shaikh , Heiner Kallweit , nic_swsd@realtek.com, Jiri Pirko , Byungho An , Edward Cree , Martin Habets , Ralf Baechle , Francois Romieu , Daniele Venzano , Nicolas Pitre , Steve Glendinning , Jassi Brar , Ilias Apalodimas , Kunihiko Hayashi , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Grygorii Strashko , Samuel Chessman , Ishizaki Kou , Kevin Brace , Radhey Shyam Pandey , Michal Simek , Krzysztof Halasa , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Sridhar Samudrala , Dave Jiang , Allen Hubbe , Michael Hennerich , Petko Manolov , Oliver Neukum , "Michael S. Tsirkin" , Jason Wang , Ronak Doshi , VMware PV-Drivers Reviewers , David Ahern , Kalle Valo , Christian Lamparter , Simon Kelley , Larry Finger , Arend van Spriel , Franky Lin , Hante Meuleman , Stanislav Yakovlev , Stanislaw Gruszka , Jouni Malinen , Ajay Singh , Claudiu Beznea , Igor Mitsyanko , Sergey Matyukevich , Herton Ronaldo Krzesinski , Hin-Tak Leung , netdev@vger.kernel.org, linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-acenic@sunsite.dk, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, intel-wired-lan@lists.osuosl.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-mips@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-omap@vger.kernel.org, linux-hyperv@vger.kernel.org, ntb@lists.linux.dev, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, libertas-dev@lists.infradead.org References: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> From: Geoff Levand In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Wolfram, On 8/18/22 14:00, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang ... > diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c > index 3dbfb1b20649..6e838e8f79d0 100644 > --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c > +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c > @@ -1187,8 +1187,8 @@ int gelic_net_open(struct net_device *netdev) > void gelic_net_get_drvinfo(struct net_device *netdev, > struct ethtool_drvinfo *info) > { > - strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); > - strlcpy(info->version, DRV_VERSION, sizeof(info->version)); > + strscpy(info->driver, DRV_NAME, sizeof(info->driver)); > + strscpy(info->version, DRV_VERSION, sizeof(info->version)); > } > ps3_gelic_net > static int gelic_ether_get_link_ksettings(struct net_device *netdev, > diff --git a/drivers/net/ethernet/toshiba/spider_net_ethtool.c b/drivers/net/ethernet/toshiba/spider_net_ethtool.c > index 93110dba0bfa..fef9fd127b5e 100644 > --- a/drivers/net/ethernet/toshiba/spider_net_ethtool.c > +++ b/drivers/net/ethernet/toshiba/spider_net_ethtool.c > @@ -63,12 +63,12 @@ spider_net_ethtool_get_drvinfo(struct net_device *netdev, > card = netdev_priv(netdev); > > /* clear and fill out info */ > - strlcpy(drvinfo->driver, spider_net_driver_name, > + strscpy(drvinfo->driver, spider_net_driver_name, > sizeof(drvinfo->driver)); > - strlcpy(drvinfo->version, VERSION, sizeof(drvinfo->version)); > - strlcpy(drvinfo->fw_version, "no information", > + strscpy(drvinfo->version, VERSION, sizeof(drvinfo->version)); > + strscpy(drvinfo->fw_version, "no information", > sizeof(drvinfo->fw_version)); > - strlcpy(drvinfo->bus_info, pci_name(card->pdev), > + strscpy(drvinfo->bus_info, pci_name(card->pdev), > sizeof(drvinfo->bus_info)); > } Seems OK for both ps3_gelic_net and spider_net_ethtool. Acked-by: Geoff Levand