Re: [PATCH v14 36/56] media: nuvoton: Stop direct calls to queue num_buffers field

Andrzej Pietrasiewicz
2023-11-09T11:29:31Z

W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze:
> Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
> This allows us to change how the number of buffers is computed in the
> future.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

> CC: Joseph Liu <kwliu@nuvoton.com>
> CC: Marvin Lin <kflin@nuvoton.com>
> ---
> drivers/media/platform/nuvoton/npcm-video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c
> index b9e6782f59b4..f9b4e36a5175 100644
> --- a/drivers/media/platform/nuvoton/npcm-video.c
> +++ b/drivers/media/platform/nuvoton/npcm-video.c
> @@ -393,7 +393,7 @@ static void npcm_video_free_diff_table(struct npcm_video *video)
> struct rect_list *tmp;
> unsigned int i;
>
> - for (i = 0; i < video->queue.num_buffers; i++) {
> + for (i = 0; i < vb2_get_num_buffers(&video->queue); i++) {
> head = &video->list[i];
> list_for_each_safe(pos, nx, head) {
> tmp = list_entry(pos, struct rect_list, list);