Re: [PATCH v7 02/16] dt-bindings: media: mediatek: mdp3: merge the indentical RDMA under display

Krzysztof Kozlowski
2023-10-13T06:46:20Z

On 12/10/2023 10:40, Moudy Ho wrote:

>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8183-mdp3-rdma
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: RDMA clock
> + - description: RSZ clock (shared SRAM with RDMA)
> +
> + mboxes:
> + items:
> + - description: used for 1st data pipe from RDMA
> + - description: used for 2nd data pipe from RDMA

interrupts:
false

> +
> + required:
> + - mboxes
> + - mediatek,gce-events
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8195-vdo1-rdma
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: RDMA clock

mboxes: false
mediatek,gce-events: false

I am not so sure it is actually "simpler" to merge these. They are quite
different. You will end up with unmanageable allOf with a lot of
branches (which supposedly you want to remove).

> +
> additionalProperties: false
>
> examples:

Best regards,
Krzysztof