Re: [PATCH v7 15/16] dt-bindings: display: mediatek: split: add compatible for MT8195

AngeloGioacchino Del Regno
2023-10-16T08:01:28Z

Il 13/10/23 08:52, Krzysztof Kozlowski ha scritto:
> On 12/10/2023 10:40, Moudy Ho wrote:
>> Add compatible string and GCE property for MT8195 SPLIT, of
>> which is operated by MDP3.
>>
>> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
>
>
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: mediatek,mt8195-mdp3-split
>> +
>> + then:
>> + required:
>> + - mediatek,gce-client-reg
>
> else:
> mediatek,gce-client-reg: false
>
>

Technically, all of the display components do support GCE, using it is
a matter of preference, so disallowing gce-client-reg on anything that
is not mt8195-mdp3-split is *technically* wrong, as much as not having
that from the beginning was also technically wrong... :-)

P.S.: The driver for the display split component doesn't use GCE yet,
only mdp3 for now, but again, it's the driver - while the HW is actually
capable of using that

Cheers,
Angelo

>> +
>> additionalProperties: false
>>
>> examples:
>
> Best regards,
> Krzysztof
>