From: Matthias Brugger <matthias.bgg@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Ryder Lee" <ryder.lee@mediatek.com>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
Sean Wang <sean.wang@kernel.org>,
Weijie Gao <weijie.gao@mediatek.com>,
linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] arm64: dts: mt7622: add a property "mediatek,num-pwms" for PWM
Date: Thu, 17 Jan 2019 14:00:43 +0100 [thread overview]
Message-ID: <2edcc5fd-ce60-b585-e0fd-226897a7a34c@gmail.com> (raw)
In-Reply-To: <20190115200231.drn2rbxu4jxr22yz@pengutronix.de>
On 15/01/2019 21:02, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Jan 14, 2019 at 04:21:22PM +0800, Ryder Lee wrote:
>> This adds a property "mediatek,num-pwms" for PWM controller.
>>
>> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>> index 8fc4aa7..ab016cf 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
>> @@ -436,6 +436,7 @@
>> <&pericfg CLK_PERI_PWM6_PD>;
>> clock-names = "top", "main", "pwm1", "pwm2", "pwm3", "pwm4",
>> "pwm5", "pwm6";
>> + mediatek,num-pwms = <6>;
>> status = "disabled";
>
> Conceptually this patch must go in before the change to the driver.
> Otherwise the pwms are not usable with only patch 1 applied which breaks
> bisectability.
>
The driver should have backwards compatibility to older DTs. So that would need
to be fixed in the driver not in the patch order of the series.
Regards,
Matthias
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-17 13:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 8:21 [PATCH 1/5] pwm: mediatek: add a property "mediatek,num-pwms" Ryder Lee
2019-01-14 8:21 ` [PATCH 2/5] dt-bindings: pwm: " Ryder Lee
2019-01-14 11:19 ` Matthias Brugger
2019-01-14 8:21 ` [PATCH 3/5] arm64: dts: mt7622: add a property "mediatek,num-pwms" for PWM Ryder Lee
2019-01-15 20:02 ` Uwe Kleine-König
2019-01-17 13:00 ` Matthias Brugger [this message]
2019-01-17 19:41 ` Uwe Kleine-König
2019-01-14 8:21 ` [PATCH 4/5] arm: dts: mt7623: " Ryder Lee
2019-01-14 8:21 ` [PATCH 5/5] dt-bindings: pwm: update bindings for MT7629 SoC Ryder Lee
2019-01-14 11:19 ` Matthias Brugger
2019-01-14 11:16 ` [PATCH 1/5] pwm: mediatek: add a property "mediatek,num-pwms" Matthias Brugger
2019-01-18 1:45 ` Ryder Lee
2019-01-15 20:00 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2edcc5fd-ce60-b585-e0fd-226897a7a34c@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).