From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Jianjun Wang" <jianjun.wang@mediatek.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>
Cc: Ryder Lee <ryder.lee@mediatek.com>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jieyy.yang@mediatek.com,
chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com,
jian.yang@mediatek.com
Subject: Re: [PATCH v2] PCI: mediatek-gen3: Fix translation window
Date: Mon, 23 Oct 2023 14:32:17 +0200 [thread overview]
Message-ID: <304abe7d-ab05-4190-b6e5-563525cbb756@collabora.com> (raw)
In-Reply-To: <20231023081423.18559-1-jianjun.wang@mediatek.com>
Il 23/10/23 10:14, Jianjun Wang ha scritto:
> The size of translation table should be a power of 2, using fls()
> cannot get the proper value when the size is not a power of 2. For
> example, fls(0x3e00000) - 1 = 25, hence the PCIe translation window
> size will be set to 0x2000000 instead of the expected size 0x3e00000.
>
> Fix translation window by splitting the MMIO space to multiple tables if
> its size is not a power of 2.
>
> Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2023-10-23 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 8:14 [PATCH v2] PCI: mediatek-gen3: Fix translation window Jianjun Wang
2023-10-23 12:32 ` AngeloGioacchino Del Regno [this message]
2023-11-23 1:27 ` Jianjun Wang (王建军)
2023-12-15 6:08 ` Jianjun Wang (王建军)
2024-01-09 4:37 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304abe7d-ab05-4190-b6e5-563525cbb756@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=bhelgaas@google.com \
--cc=chuanjia.liu@mediatek.com \
--cc=jian.yang@mediatek.com \
--cc=jianjun.wang@mediatek.com \
--cc=jieyy.yang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=qizhong.cheng@mediatek.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox