From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDD0FC43458 for ; Fri, 10 Jul 2026 13:15:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rx/8gALKK6VAdXbfpPjC1MKZl9eeecWweGFPH/OHuEg=; b=UdyprJ8ffVbY7nbLSf4o9yh0wU zieFc+3p3Rz7QjXFzWQiluIB1pTr6RgsaAXwGyEu1c7NbFyFmpZAuJfLqVjPEaJQtAx72vhI2QqZf 8b3RfFcchY/eeOJ385BuOhdci3hpyuoa7qwhQ92AsL0reIhbWI01t4DP0TLNNp9jgbEPKtlvfzMcl rLmLB4dYAraIHFQOgNTH1aU2teABR6QMeOmiuDoLMkMrgpPJsrxsRUaakKj7upNoYlbvgLfs3IAJ8 Asn5578pURRHpDGJ2n3U9x9rr799pQFu2xmIJU/q+Z/FShIiXsJI6TYbpzlz+3FfG4UXjv+VI1Yi6 dgIscZmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiB51-00000004zEJ-2f9l; Fri, 10 Jul 2026 13:15:47 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiB4z-00000004zDn-1Ygr; Fri, 10 Jul 2026 13:15:45 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4BE66600C3; Fri, 10 Jul 2026 13:15:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A40E71F00A3A; Fri, 10 Jul 2026 13:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783689344; bh=rx/8gALKK6VAdXbfpPjC1MKZl9eeecWweGFPH/OHuEg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=VPtbpUbVXMNlg61BFX59iMclPIF2ufhARVU4gF7cciYo7oFsSJjeZqGdCISGilehe WU/w+xWLMIuQYHeTQrJRwRa2eW1M3FoYdAuaiTdCA8pXmNLh8UjfAX2phL2fKDaCvu M5tu7Nccs/F5aGlwq/jeaa42Ulo6+GIvC0d5YVrVse66qQJ/kal1gFqISRRNGeX+3Y 7sxsINL5JJXTYdB1In94vI1AyrEL578RL+LQPivCi619HeEO9DJHYMyCNCAjKSKxpx jo3JNXoAyk/LtVEfCWAwyPsJHVhxGang2+obiAHvYodGhinFLsT8m2unpqYdA+tb4z K6GFaBKZQEM7A== Message-ID: <315a0aec-99e8-4d03-a04b-613acfae1f52@kernel.org> Date: Fri, 10 Jul 2026 15:15:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 21/23] mfd: Unify style of of_device_id arrays To: Mathieu Dubois-Briand , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Lee Jones Cc: Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Chen-Yu Tsai , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Marek Vasut , James Ogletree , Fred Treven , Ben Bright , David Rhodes , Richard Fitzgerald , Support Opensource , Peter Griffin , Alim Akhtar , Tim Harvey , Neil Armstrong , Charles Keepax , Sven Peter , Janne Grunau , Neal Gompa , Chanwoo Choi , Luca Ceresoli , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Saravanan Sekar , Matthias Brugger , AngeloGioacchino Del Regno , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Matti Vaittinen , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Jernej Skrabec , Samuel Holland , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , mfd@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linux-rpi-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org References: From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 10/07/2026 15:00, Mathieu Dubois-Briand wrote: > On Thu Jul 9, 2026 at 6:58 PM CEST, Uwe Kleine-König (The Capable Hub) wrote: >> These arrays already mostly match the most used and generally >> recommended coding style. That is: >> >> - no comma after the list terminator; >> - a comma after an initializer if (and only if) the closing } is not >> directly following; >> - no explicit zeros in the list terminator; >> - a space after an opening { and before a closing }, a single space in >> the list terminator; >> >> Adapt the offenders accordingly. >> >> Reviewed-by: André Draszik # for Maxim MAX77759 >> Reviewed-by: Charles Keepax Here... >> Signed-off-by: Uwe Kleine-König (The Capable Hub) >> --- > > ... > >> >> diff --git a/drivers/mfd/max7360.c b/drivers/mfd/max7360.c >> index 52fffed0c0dd..dc744b40bb38 100644 >> --- a/drivers/mfd/max7360.c >> +++ b/drivers/mfd/max7360.c >> @@ -152,7 +152,7 @@ static int max7360_probe(struct i2c_client *client) >> >> static const struct of_device_id max7360_dt_match[] = { >> { .compatible = "maxim,max7360" }, >> - {} >> + { } >> }; >> MODULE_DEVICE_TABLE(of, max7360_dt_match); >> > > Reviewed-by: Mathieu Dubois-Briand # max7360 and here Thesr are all Acks, not reviews. Entire commit will now carry multiple review tags, implying it was reviewed by 3 or more people but none of these people actually reviewed the commit. None! They looked at one line out of 100. This is ridiculous. Quoting: "Reviewed-by:, instead, indicates that the patch has been reviewed and found acceptable according to the Reviewer's Statement:" Not piece of a patch. THE PATCH. Best regards, Krzysztof