From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34038C433F5 for ; Wed, 27 Apr 2022 09:38:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ftcbYo+LaY1TDUiu7GPC3+tOD4Mvst1be89DDNRKMz4=; b=Tkp6Bi/WEWRgfs X4CjmY3mUAU+uWbQFDl6bR9f4oqmyo/rEbDeIqN23wNMvzB8R1lz+n7qO2s/uZXFKCFxm18Lzjou4 q6sEbOFWAkaBvBY79ZLMKHcBafDI7LtEu/W5HgBaHCQwAc5nqyNgxhU7n+gas0pwBK6eD75IGREKA gtd6UVLTWSoUzDO2kqX6rlOWk7I5K4LD2fsWjT4jj6SAt5FtBVsNQsMMDYAH8nAF1pRdLaMoAluZa QoGXj1rLVahEFTBBAivoOBh66tSKnxR6Q3RcTlKvtpzDf6bE1G1hzJr8M0mTs3cDDE8lrH0E9H1ci s5DOY4ISSXIku8/NBPOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nje7b-000me6-9B; Wed, 27 Apr 2022 09:38:07 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nje77-000mLC-Su; Wed, 27 Apr 2022 09:37:39 +0000 X-UUID: 2d574063d95449e587afdee3984f4845-20220427 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.4, REQID:ff19fb90-dbb0-4631-99d4-59ee3ca77e70, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:faefae9, CLOUDID:a8b5e32e-6199-437e-8ab4-9920b4bc5b76, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,File:nil,QS:0,BEC:nil X-UUID: 2d574063d95449e587afdee3984f4845-20220427 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 556970087; Wed, 27 Apr 2022 02:37:30 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 Apr 2022 02:28:59 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 Apr 2022 17:28:57 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 27 Apr 2022 17:28:57 +0800 Message-ID: <33c754a7b6e4cd631bb2aeef002d34a6c25d6689.camel@mediatek.com> Subject: Re: [PATCH v2 1/1] dt-bindings: nvmem: mediatek: Convert mtk-efuse binding to YAML From: allen-kh.cheng To: Krzysztof Kozlowski , "Srinivas Kandagatla" , Matthias Brugger , Rob Herring , "Krzysztof Kozlowski" CC: Lala Lin , , , , , , Chen-Yu Tsai , Ryder Lee Date: Wed, 27 Apr 2022 17:28:57 +0800 In-Reply-To: <89609af9-5feb-0553-5e39-c97c4750b5a1@linaro.org> References: <20220425084800.2021-1-allen-kh.cheng@mediatek.com> <20220425084800.2021-2-allen-kh.cheng@mediatek.com> <9d65b713e3ffdd34dcca532c4c97fa98b124bde4.camel@mediatek.com> <0169c4ac-fdce-29b7-553a-14dc7df532d1@linaro.org> <89609af9-5feb-0553-5e39-c97c4750b5a1@linaro.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_023737_975901_0BD14DD5 X-CRM114-Status: GOOD ( 28.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Tue, 2022-04-26 at 12:14 +0200, Krzysztof Kozlowski wrote: > On 26/04/2022 12:02, allen-kh.cheng wrote: > > Hi Krzysztof, > > > > On Tue, 2022-04-26 at 08:31 +0200, Krzysztof Kozlowski wrote: > > > On 26/04/2022 08:23, allen-kh.cheng wrote: > > > > > > +properties: > > > > > > + compatible: > > > > > > + oneOf: > > > > > > + - enum: > > > > > > + - mediatek,mt8173-efuse > > > > > > + - mediatek,efuse > > > > > > > > > > Still no changes... > > > > > > > > > > > > > I just want to confirm again. > > > > > > > > "Generic compatibles should not be used standalone" > > > > > > > > It seems we should remove mediatek,efuse and keep > > > > "mediatek,mt8173- > > > > efuse"in binding. have I got that right? > > > > > > You should comment for which chipsets this compatible is and add > > > a > > > deprecated:true. In such case it cannot be part of enum but > > > separate > > > item in this oneOf. > > > > > > > > > Best regards, > > > Krzysztof > > > > Thanks for your suggestions, I would plan to send PATCHs as below, > > > > We have a PATCH 01 for current accepted dts > > > > properties: > > compatible: > > oneOf: > > - enum: > > - mediatek,efuse > > > > - mediatek,mt8173-efuse > > description: Only mt8173-efuse > > with generic fallback should be used > > - items: > > - enum: > > > > - mediatek,mt7622-efuse > > ... > > - const: mediatek,efuse > > > > Then add PATCH 02 to deprecate it > > > > properties: > > compatible: > > oneOf: > > - enum: > > - mediatek,efuse > > - mediatek,mt8173-efuse > > deprecated: true > > description: The mediatek,efuse is a generic fallback for > > other > > Chipset. Do not use the single compatible such as mediatek,efuse > > or mediatek,mt8173-efuse. It is deprecated. > > - items: > > - enum: > > - mediatek,mt7622-efuse > > ... > > - const: mediatek,efuse > > > > > > PATCH 03 for 8173 > > > > update mt8173.dtsi > > > > change compatible from "mediatek,mt8173-efuse" to "mediatek,mt8173- > > efuse", "mediatek,efuse"; > > > > > > Do you think it'd be okay ? > > The idea is correct, but as I said it cannot be part of enum, but > separate item in oneOf. You should see an error when testing your > patch. > > > Best regards, > Krzysztof I have tested make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/nvmem/mtk,efuse.yaml make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/nvmem/mtk,efuse.yaml Is the following correct as final version ? properties: compatible: oneOf: - const: mediatek,mt8173-efuse #Don't use this in new dts files deprecated: true - const: mediatek,efuse deprecated: true description: Please use mediatek,efuse as fallback. - items: - enum: - mediatek,mt7622-efuse - mediatek,mt7623-efuse - mediatek,mt8173-efuse - mediatek,mt8183-efuse - mediatek,mt8192-efuse - mediatek,mt8195-efuse - mediatek,mt8516-efuse - const: mediatek,efuse Thanks a lot, Allen _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek