Re: [PATCH v3 06/25] drm/armada: Compute dumb-buffer sizes with drm_mode_size_dumb()

Thomas Zimmermann
2025-02-19T08:23:48Z

Hi

Am 18.02.25 um 16:57 schrieb Russell King (Oracle):
> On Tue, Feb 18, 2025 at 03:23:29PM +0100, Thomas Zimmermann wrote:
>> Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and
>> buffer size. No alignment required.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Russell King <linux@armlinux.org.uk>
> armada_pitch() does have some special alignment (it aligns the pitch to
> 128 bytes). I've no idea what drm_mode_size_dumb() does. Can you check
> whether it does the same please?
>
> If it doesn't, then this patch is incorrect.

Indeed, I should have noticed. Will be fixed in the next iteration.
Thanks for the review.

Best regards
Thomas

>

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)