Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Darren Ye (叶飞)" <Darren.Ye@mediatek.com>
To: "krzk@kernel.org" <krzk@kernel.org>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"brgl@bgdev.pl" <brgl@bgdev.pl>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"perex@perex.cz" <perex@perex.cz>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 08/10] ASoC: dt-bindings: mediatek,mt8196-afe: add support for MT8196 audio AFE controller
Date: Mon, 23 Jun 2025 06:52:49 +0000	[thread overview]
Message-ID: <3562cdd32d6f723a35ed063b65560a8e25801255.camel@mediatek.com> (raw)
In-Reply-To: <011093f8-85a1-4c3c-b3fa-7be9e6df8a25@kernel.org>

On Sun, 2025-06-22 at 11:43 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 20/06/2025 11:40, Darren.Ye wrote:
> > From: Darren Ye <darren.ye@mediatek.com>
> > 
> > This patch adds initial support for the audio AFE(Audio Front End)
> > controller
> 
> Why this was changed to undesired 'This patch' (see submitting
> patches)?
> I think you are circling back to previous versions, reintroducing
> issues
> fixed in between.

Thanks for you feedback. Just to confirm, for the next version, should
I revert the subject/description back to previous version and only drop
the document part, whitout making other changes?


Please see the following change:

ASoC: dt-bindings: mediatek,mt8196-afe: add audio AFE

Add mt8196 audio AFE.


Please let me know if this is correct.

Best regards,
Darren

> 
> > on the mediatek MT8196 platform.
> > 
> > Signed-off-by: Darren Ye <darren.ye@mediatek.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> 
> Subject: I asked to drop document, because the rest was correct and
> you
> totally rewritten it to unnecessary too long subject.
> 
> Well, at least the rest you implemented, but I just don't get why,
> when
> asked to change something you change several things to less desired
> style.
> 
> Best regards,
> Krzysztof

  reply	other threads:[~2025-06-23  7:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20  9:40 [PATCH v5 00/10] ASoC: mediatek: Add support for MT8196 SoC Darren.Ye
2025-06-20  9:40 ` [PATCH v5 01/10] ASoC: mediatek: common: modify mtk afe platform driver for mt8196 Darren.Ye
2025-06-21  8:34   ` kernel test robot
2025-06-20  9:40 ` [PATCH v5 02/10] ASoC: mediatek: mt8196: add common header Darren.Ye
2025-06-20  9:40 ` [PATCH v5 03/10] ASoC: mediatek: mt8196: support audio clock control Darren.Ye
2025-06-20  9:40 ` [PATCH v5 04/10] ASoC: mediatek: mt8196: support ADDA in platform driver Darren.Ye
2025-06-20  9:40 ` [PATCH v5 05/10] ASoC: mediatek: mt8196: support I2S " Darren.Ye
2025-06-23  9:05   ` AngeloGioacchino Del Regno
2025-06-20  9:40 ` [PATCH v5 06/10] ASoC: mediatek: mt8196: support TDM " Darren.Ye
2025-06-20  9:40 ` [PATCH v5 07/10] ASoC: mediatek: mt8196: add " Darren.Ye
2025-06-23  9:29   ` AngeloGioacchino Del Regno
2025-06-20  9:40 ` [PATCH v5 08/10] ASoC: dt-bindings: mediatek,mt8196-afe: add support for MT8196 audio AFE controller Darren.Ye
2025-06-22  9:43   ` Krzysztof Kozlowski
2025-06-23  6:52     ` Darren Ye (叶飞) [this message]
2025-06-23  7:30       ` Krzysztof Kozlowski
2025-06-20  9:40 ` [PATCH v5 09/10] ASoC: mediatek: mt8196: add machine driver with nau8825 Darren.Ye
2025-06-20  9:40 ` [PATCH v5 10/10] ASoC: dt-bindings: mediatek,mt8196-nau8825: Add audio sound card Darren.Ye
2025-06-22 11:25   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3562cdd32d6f723a35ed063b65560a8e25801255.camel@mediatek.com \
    --to=darren.ye@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox