From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Ian King Subject: Re: [PATCH] pinctrl: paris: fix check on EINT_NA comparison Date: Tue, 25 Sep 2018 16:02:48 +0100 Message-ID: <365f2df0-6c06-a165-59ca-2be0fa798683@canonical.com> References: <20180925132130.27044-1-colin.king@canonical.com> <20180925145821.bwumsuzz4tgsxc4b@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180925145821.bwumsuzz4tgsxc4b@mwanda> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Dan Carpenter Cc: Linus Walleij , Matthias Brugger , Sean Wang , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org On 25/09/18 15:58, Dan Carpenter wrote: > On Tue, Sep 25, 2018 at 02:21:30PM +0100, Colin King wrote: >> From: Colin Ian King >> >> Currently, the check on desc->eint.eint_n == EINT_NA is always false >> because this is comparing a u16 to -1 which can never be true. Fix >> this by casting EINT_NA to u16. >> >> Fixes: fb5fa8dc151b ("pinctrl: mediatek: extend struct mtk_pin_desc to pinctrl-mtk-common-v2.c") >> Signed-off-by: Colin Ian King >> --- >> drivers/pinctrl/mediatek/pinctrl-paris.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c >> index 4cf0fea30b7d..77d380145dfd 100644 >> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c >> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c >> @@ -729,7 +729,7 @@ static int mtk_gpio_to_irq(struct gpio_chip *chip, unsigned int offset) >> >> desc = (const struct mtk_pin_desc *)&hw->soc->pins[offset]; >> >> - if (desc->eint.eint_n == EINT_NA) >> + if (desc->eint.eint_n == (u16)EINT_NA) > > Adding casts is ugly... I reported this earlier and think Sean Wang is > going to send a fix for it. Fair enough. Thanks for letting me know. > > regards, > dan carpenter >