From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6390EC4332F for ; Tue, 18 Oct 2022 12:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZVdCQKWiBBXHEsRPEL3ACgqoSkagQ+GB1TtAZi9uOBU=; b=uEM3zhs3WE+wgTwYoRlsdDHYPG I2/yNaOF+HU868jjho667LxNYUFXU5Z9OptONtQuxEHnj1UMkbhY2N2vmpgPHI6kkjQO/h46UCI8Y Jxf5sPcCNPNrzSPwjHB3k1ywZBPZcunoKwumJWSRP2Wwch5po8S79AjWnrY5Qa+sXd3wbcjBr+Bm0 8bHQjOVMSXpjZlSk5yu1NV247vQE6ElzwrwSX4nkufckiKo/g7AFA7nZtpaJcPruLSEoM56Sbz2vV 0RP5AwQt/ic/Kp2Q2+fm3dJkXaIDLt6zcm5WRSap8ANGumdLC3/sTJ6KSsYVeUunQYCWzh/tLT4TK fxlHR01A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okm4X-006kLQ-HV; Tue, 18 Oct 2022 12:51:53 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okm4I-006kEb-0h for linux-mediatek@lists.infradead.org; Tue, 18 Oct 2022 12:51:41 +0000 Received: by mail-qt1-x82b.google.com with SMTP id s3so9513451qtn.12 for ; Tue, 18 Oct 2022 05:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZVdCQKWiBBXHEsRPEL3ACgqoSkagQ+GB1TtAZi9uOBU=; b=GhCSsLS+B2XDm8XixguHrCvn2HJ5xXyuPFfMlfM2Cebo5naD7VkbQ28SndGB26qRJu 3SrG+8WmXpln/9qYyuZJXUzZ9e7U5TidOtEM6BTIv0gXfn2wg8Yk87SfvZsiCY1EtsOv qNdcE0pbixpJeYpER6xT7rqMBFCclpBdv0l7JmOClnSq59SIsv4vAHmFvd5DilabexcJ N7TLBxHcqXizdF3vBWatAH6FjOQU9k/X3RqNJUQvq+Wwmn6SAji9p0TYLmqabnyUdIgI sK/bmLana3+sQjvENj/rLl+Wta2zM8YlzuK+nAD6Lx8//0RkFEeaE/J46ZjrnDroY3tH eCZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZVdCQKWiBBXHEsRPEL3ACgqoSkagQ+GB1TtAZi9uOBU=; b=cm62syugpWAbkZJ5INLLtkmcGI9crf0PORtAQI3R3pddRgA7tu4DtWBvP71n06zlzi VjqVE3SjziZFUXXKg272pbLoVPCeUWk5XIPJk5OYqxJDKHvwiQqJ6Nt+vbVmiYUb1+0K 9f1i8+emSMZo6riNhD/vG4KEv8ms447WCBNHfbedQexDyIV0+XGYQDG8Eyu36VA2S4kB kBgmEwxU7ppO7bUNIkX+M1efiICSrxsVHBK+1aGjaGh8ufg/fWnved57f3W2hOnV1gFR 9M42JK1aqT1pziT+70v1jIqRADdcUSxLc5ioPlpl7wnBxCJdZ33m5aJmHqxs5xKelfkU fTwA== X-Gm-Message-State: ACrzQf3AH8CBAmtGbKzzTdqXiLGteFUksVog3sSco+1+aiwUHtTwq0an 2Mfl6Oa31yAeVCYSK+4YBiMeAA== X-Google-Smtp-Source: AMsMyM6JGm04MqT0u2iZhlGgCaC8P6JbYf05oWlqJG/gFIDk14T9YYpE5kwvgvJpQLoV1on6yiGaGQ== X-Received: by 2002:ac8:5f84:0:b0:39c:e5a2:6cc4 with SMTP id j4-20020ac85f84000000b0039ce5a26cc4mr1935175qta.40.1666097495962; Tue, 18 Oct 2022 05:51:35 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id g5-20020ac80705000000b00398ed306034sm1818674qth.81.2022.10.18.05.51.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Oct 2022 05:51:35 -0700 (PDT) Message-ID: <37fff2b8-a798-dea3-c010-714a2bac695f@linaro.org> Date: Tue, 18 Oct 2022 08:51:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] arm64: dts: mt8195: Add Ethernet controller Content-Language: en-US To: Biao Huang , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, macpaul.lin@mediatek.com References: <20221017095834.7675-1-biao.huang@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221018_055138_078846_4C40F586 X-CRM114-Status: GOOD ( 22.78 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 18/10/2022 02:37, Biao Huang wrote: > Dear Krzysztof, > Thanks for your comments! > > On Mon, 2022-10-17 at 22:01 -0400, Krzysztof Kozlowski wrote: >> On 17/10/2022 05:58, Biao Huang wrote: >>> Add Ethernet controller node for mt8195. >>> >>> Signed-off-by: Biao Huang >>> --- >>> arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 88 >>> ++++++++++++++++++++ >>> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 87 >>> +++++++++++++++++++ >>> 2 files changed, 175 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>> b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>> index 4fbd99eb496a..02e04f82a4ae 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>> @@ -258,6 +258,72 @@ &mt6359_vsram_others_ldo_reg { >>> }; >>> >>> &pio { >>> + eth_default: eth_default { >> >> No underscores in node names. Please also be sure your patch does not >> bring new warnings with `dtbs_check` (lack of suffix above could mean >> it >> brings...) > OK, I'll fix the underscores issue in next send. > As to "lack of suffix" issue, do you mean I should write it like: > eth-default: eth-default@0 { I don't know whether you should have here suffix or not - please check your bindings. Several pinctrl bindings require suffixes (or prefixes), thus I asked. BTW, In the label you must use underscore. > ... > } > If yes, other nodes in current file don't have such suffix. > e.g. > gpio_keys_pins: gpio-keys-pins > > Should I keep unified style with other nodes? Check what bindings are requiring. >> >>> + txd_pins { >> (...) >>> + >>> + eth: ethernet@11021000 { >>> + compatible = "mediatek,mt8195-gmac", >>> "snps,dwmac-5.10a"; >>> + reg = <0 0x11021000 0 0x4000>; >>> + interrupts = >> 0>; >>> + interrupt-names = "macirq"; >>> + mac-address = [00 55 7b b5 7d f7]; >> >> How is this property of a SoC? Are you saying now that all MT8195 >> SoCs >> have the same MAC address? > The mac-address here is taken as a default mac address in eth driver > rather than a randome one. > Actually, there will be a tool to customize eth mac address (e.g > through "ifconfig eth0 hw ether xx:xx:xx:xx:xx:xx"), so every > MT8195 SoCs will get their specified mac address in real product. So this means this is not one MAC address for all SoCs, so this does not belong to DTSI. Actually it doesn't belong to DTS either. Look how others are doing... Best regards, Krzysztof