Re: [PATCH 5/5] media: platform: mtk-mdp3: Change cmdq_pkt_jump_rel() to cmdq_pkt_jump_rel_temp()

["Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>]

On Tue, 2025-12-09 at 15:47 -0500, Nicolas Dufresne wrote:
> Hi,
> 
> 
> Le samedi 01 novembre 2025 à 00:02 +0800, Jason-JH Lin a écrit :
> > To facilitate the removal of the shift_pa parameter from
> > cmdq_pkt_jump_rel(), current users of cmdq_pkt_jump_rel() need to
> > transition to using cmdq_pkt_jump_rel_temp() before the API change
> > is implemented.
> > 
> > Signed-off-by: Jason-JH Lin <jason-jh.lin@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@collabora.com>
> > ---
> >  drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > index d0b0b072f953..5fc9263ccb78 100644
> > --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
> > @@ -628,7 +628,7 @@ static struct mdp_cmdq_cmd
> > *mdp_cmdq_prepare(struct mdp_dev *mdp,
> >  		goto err_free_path;
> >  	}
> >  	cmdq_pkt_eoc(&cmd->pkt);
> > -	cmdq_pkt_jump_rel(&cmd->pkt, CMDQ_INST_SIZE, mdp-
> > >cmdq_shift_pa[pp_idx]);
> > +	cmdq_pkt_jump_rel_temp(&cmd->pkt, CMDQ_INST_SIZE, mdp-
> > >cmdq_shift_pa[pp_idx]);
> 
> I cannot take that right now in the media tree, as it won't build.
> Can the SoC
> maintainer help me know if I just leave that on hold, or perhaps
> you'd like to
> take it ? (or its in next, and I just have to wait for next udpate?)
> 
> I also doubt patch 4/5 is make much of a difference without the soc
> changes ?
> 

Hi Angelo,

Can you help us? Thanks!

Regards,
Jason-JH Lin

> regards,
> Nicolas