From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36749C433DB for ; Thu, 4 Mar 2021 19:28:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86D6264F60 for ; Thu, 4 Mar 2021 19:28:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86D6264F60 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nbd.name Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o5BRH0kXh99rWevnT1PZ5Me9xyf6nVkVdnrqv7AXbz0=; b=J7OeDEV1M+hjp5gk1JvpBMWbx au1ijd8LMK34GevVx5o+fmhwsr9FvH8OyYLZrOWnnuKTqhPPQ+PYmBA/k9k1LSu4DTiYrWWQjIO1b wMKZiJV+cBf+zl8h8JUwYSr/JxvH+jl9aDIG+5mjEIiQwMXXGGXyX8etmucjsXsdIqFuVyHSVuWkG k+gWbsfEufXJjlartIqll030Yg3V7UnlkgJCEkpd7DQ8Wcen0CR65TZzNsxkYuO9y+XhVzpr6U8rC xGxdzxTAznutnp7lfo2KXFTxvFwr7YMTq/fcULc9nQuMQzaDUljFwtVIRK/If9afKDjiRv5AqCqoW YKtmS5QFQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHte7-009lEA-UO; Thu, 04 Mar 2021 19:28:29 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHte3-009lDG-Vk for linux-mediatek@lists.infradead.org; Thu, 04 Mar 2021 19:28:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7i8BEbXDXEOW8E286D5JURPRm2okvke1VJqD1R/Oop4=; b=oy/Fil/cXzLyBMkS+Zdzw/o5fK 7sS5AzQoGZaDuDZ6D64Xygfw5oTGh4GSRWmF89/lfkxKv/F1hUPpmUGjWIztDX8GAWjzeXLXee6gL o7RhOqlgUOIWMeDKc9nTWMOeIigFxyBXH20skz2mOiAbT7lM/NTykEzfYmWUcubbcLJ8=; Received: from p4ff13c8d.dip0.t-ipconnect.de ([79.241.60.141] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1lHtdy-0003kA-JI; Thu, 04 Mar 2021 20:28:18 +0100 Subject: Re: [PATCH v4] mt76: mt7615: add missing capabilities for DBDC To: Ryder Lee , Lorenzo Bianconi Cc: Shayne Chen , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org References: <0573b06759c90309b5a6a6e2b6b95796e7db60c7.1614843966.git.ryder.lee@mediatek.com> From: Felix Fietkau Message-ID: <384dc2df-60d7-c6bf-040c-d8583af30a98@nbd.name> Date: Thu, 4 Mar 2021 20:28:17 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <0573b06759c90309b5a6a6e2b6b95796e7db60c7.1614843966.git.ryder.lee@mediatek.com> Content-Language: en-US X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 2021-03-04 09:55, Ryder Lee wrote: > This improves performance for second phy. > > Signed-off-by: Ryder Lee I actually prefer v1 of this patch. You can fix the init order issues by simply dropping the if (phy->mt76->cap.has_*) checks, since they are not needed at all. - Felix _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek