From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F074C47088 for ; Wed, 30 Nov 2022 18:38:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FEvJH3kbo6myFPK2mZY5UgEBn/JXDewwu8sZL34vsfE=; b=oRq/H1SoAN3b14LSmRzp6NcZvK VURMqJTZBEsoEIWfNb38aWFAohlfFvqUBCVY5dRImAg8Yxq1YkC1JUu1Tw4DAKQLB/SJ3zU98+Io0 wMuyv39skjGRisDaIoV8H7B9PDPF2yYFsr1Xgl9bx+YjAlsS++rnpM4dwZgYm8Ze15Hog7NvsqO9Z I/xSjQm8ARo/3ZTWf0awO8Sl6vQlFThri9o6AyfxLJHsVIDtZJFw/Atnx4xe9xfqQhh/vEi4dJKbm iHAyzP56sBputhLr+RfHUhdhpJ5RD4hV5rVf5JVAskD7yw5Ab8+lQM4FUfLCZcSLyzsvgdQ1RvH+7 EgCfC2Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0RyS-001fCc-2N; Wed, 30 Nov 2022 18:38:24 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0RxT-001ecQ-Bg; Wed, 30 Nov 2022 18:37:24 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p0Rwv-0003tW-CD; Wed, 30 Nov 2022 19:36:49 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Thierry Reding , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Conor Dooley , Linus Walleij , Bartosz Golaszewski , Douglas Anderson , Pavel Machek , Claudiu Beznea , Nicolas Ferre , Alexandre Belloni , Ray Jui , Scott Branden , Broadcom internal kernel review list , Benson Leung , Guenter Roeck , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , Florian Fainelli , Palmer Dabbelt , Paul Walmsley , Michael Walle , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Hammer Hsieh , Nobuhiro Iwamatsu , Sean Anderson , Michal Simek , Bjorn Andersson , Stephen Boyd , Matthias Kaehlcke , Satya Priya , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code Date: Wed, 30 Nov 2022 19:36:47 +0100 Message-ID: <3943768.iZASKD2KPV@diego> In-Reply-To: <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221130152148.2769768-2-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_103723_488902_F6FA11A9 X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org > diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c > index a5af859217c1..3ec7d1756903 100644 > --- a/drivers/pwm/pwm-rockchip.c > +++ b/drivers/pwm/pwm-rockchip.c > @@ -57,9 +57,9 @@ static inline struct rockchip_pwm_chip *to_rockchip_pwm_chip(struct pwm_chip *c) > return container_of(c, struct rockchip_pwm_chip, chip); > } > > -static void rockchip_pwm_get_state(struct pwm_chip *chip, > - struct pwm_device *pwm, > - struct pwm_state *state) > +static int rockchip_pwm_get_state(struct pwm_chip *chip, > + struct pwm_device *pwm, > + struct pwm_state *state) > { > struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip); > u32 enable_conf = pc->data->enable_conf; > @@ -70,11 +70,11 @@ static void rockchip_pwm_get_state(struct pwm_chip *chip, > > ret = clk_enable(pc->pclk); > if (ret) > - return; > + return 0; > > ret = clk_enable(pc->clk); > if (ret) > - return; > + return 0; > > clk_rate = clk_get_rate(pc->clk); > > @@ -96,6 +96,8 @@ static void rockchip_pwm_get_state(struct pwm_chip *chip, > > clk_disable(pc->clk); > clk_disable(pc->pclk); > + > + return 0; > } for the Rockchip-part: Reviewed-by: Heiko Stuebner