From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB3A7C43458 for ; Thu, 9 Jul 2026 14:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3j1/5iqjr/RGywJZu38YF3LoGUD7Xwgn18+HpJbhRhg=; b=PTr9qxXhncCY1Rk+fSv410J0PN dJzSsLCZOVpWmVtac0m1uS4pI6nY8UZrnKtproBxbdbmYu++0DTJDPORbeFvt3g5VPREOn0jKTueY OEsRMQNr4ok5r0tRNIP15T5FqoulIBnsxsEL99scy7wVWGW8i5OlGov+DZjFWoHcGfBVUpn7C0JuT l9ojULegP9NY0bD+cyO5JIIhNZY5b6jC8Q0sZqmutuXlHl0PMuCZoecyG//U80mQ8YK9JpqHhqCYa 9aScfHGDgMOa0g3N+ZnBICF3ByfdKCKtX3Jv4VHycBiS2jtoqVPLKVnZQGbP2VYfl/yn+Q4kE//tb nZ64/I6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whpNl-00000002htR-0O4I; Thu, 09 Jul 2026 14:05:41 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whpNi-00000002hsO-0u6s; Thu, 09 Jul 2026 14:05:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1783605936; bh=22XW+V5XF0iLnR9+YP/enVD7BjheUREeDzPkDNifOPI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=E2gh5g0kBLcL0tlvGP5nqHnNOU9SxBdqIErJCJ08vhsQe96SukRtXPz0bsZ31RePJ heP8e84zIwb2JQlb79rVImPzBDdiu6WMid3f1JVswovoT0UVHBJsLz5cKuu2mPR3J8 vdQ//iJB/Ewhm7tFUxQTIUHJt1y8BCctSOj+xi6+swIyxdqNOj5iVKDsfE0E7WA4ih 6xXs5SJkWULzDLLjdRtyMDq1reTPelSSTxCaqElhEmaT0j6DOLIfH1caWtr6/yBa65 cqEAblwdhI6KY9XPbbO+UhVkiQTtltwIxsSxaX9BOxMkILfdmYaOolzgtpgKutMal6 R0XunXKcYLiSQ== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 84B4D17E01AC; Thu, 09 Jul 2026 16:05:35 +0200 (CEST) Message-ID: <39ba7e37-bdd7-41ab-b72d-fed0bdbfc3b6@collabora.com> Date: Thu, 9 Jul 2026 16:05:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/18] dt-bindings: clock: mediatek: Add MT8189 clocks To: Louis-Alexis Eyraud , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Chun-Jie Chen , Philipp Zabel , Edward-JW Yang , Richard Cochran Cc: kernel@collabora.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Irving-CH Lin References: <20260709-mt8189-clocks-system-base-v2-0-2926da3db6cf@collabora.com> <20260709-mt8189-clocks-system-base-v2-8-2926da3db6cf@collabora.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20260709-mt8189-clocks-system-base-v2-8-2926da3db6cf@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_070538_406065_32670E46 X-CRM114-Status: UNSURE ( 9.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 7/9/26 15:42, Louis-Alexis Eyraud wrote: > Add dt schema and IDs for the clocks of MediaTek MT8189 SoC. > The MT8189 clock IP provide clock control for main system > (apmixedsys, topcksys and vlpcksys) and subsys (eg. peri, scp, > ufs...). > > Also, add compatible for frequency hopping and spread spectrum clock > functionality and reset controller header file for MT8189 UFS reset > controller support. > > Co-developed-by: Irving-CH Lin > Signed-off-by: Irving-CH Lin > Signed-off-by: Louis-Alexis Eyraud Both the commit description and title are misleading, as in, you're not adding MT8189 clocks, but *both* clocks *and* resets. Fix it please. After which: Reviewed-by: AngeloGioacchino Del Regno > --- > .../bindings/clock/mediatek,mt8186-clock.yaml | 15 + > .../bindings/clock/mediatek,mt8186-fhctl.yaml | 1 + > .../bindings/clock/mediatek,mt8186-sys-clock.yaml | 5 + > include/dt-bindings/clock/mediatek,mt8189-clk.h | 433 +++++++++++++++++++++ > include/dt-bindings/reset/mediatek,mt8189-resets.h | 17 + > 5 files changed, 471 insertions(+) >