From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Conor Dooley <conor@kernel.org>,
Jason-ch Chen <Jason-ch.Chen@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Alexandre Mergnat <amergnat@baylibre.com>,
Bear Wang <bear.wang@mediatek.com>,
Pablo Sun <pablo.sun@mediatek.com>,
Macpaul Lin <macpaul@gmail.com>, Sen Chu <sen.chu@mediatek.com>,
"Chris-qj chen" <chris-qj.chen@mediatek.com>,
MediaTek Chromebook Upstream
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
Chen-Yu Tsai <wenst@chromium.org>
Subject: Re: [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains
Date: Tue, 8 Oct 2024 12:03:37 +0800 [thread overview]
Message-ID: <3a970560-2458-f5f3-87c5-925079fa12a4@mediatek.com> (raw)
In-Reply-To: <20240926-treadmill-purr-b2e3279a14a4@spud>
On 9/27/24 00:25, Conor Dooley wrote:
> On Thu, Sep 26, 2024 at 06:18:04PM +0800, Macpaul Lin wrote:
>> Some platforms requires a dependency for power-domains.
>
> Some, so not all? Why isn't this restricted on a per compatible basis?
After discussion with Chunfeng and double check tphy design in detail.
Chunfeng commented that tphy dose not need to add mtcmos.
It is not necessary to add it, if the power of the phy is turned off,
it will affect other functions.
From the current USB hardware design perspective, even if mtcmos
is added to the phy, it is always on.
>> So we add property 'power-domains' and set 'maxItems: 1' in the
>> DT Schema.
>>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
>> index 423b7c4e62f2..c77fe43c224a 100644
>> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
>> @@ -125,6 +125,9 @@ properties:
>> $ref: /schemas/types.yaml#/definitions/uint32
>> default: 28
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> # Required child node:
>> patternProperties:
>> "^(usb|pcie|sata)-phy@[0-9a-f]+$":
>> --
>> 2.45.2
>>
Please drop this patch and I'll send a new fix to mt8195.dtsi.
Thanks
Macpaul Lin
next prev parent reply other threads:[~2024-10-08 4:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 10:18 [PATCH] dt-bindings: phy: mediatek: tphy: add a property for power-domains Macpaul Lin
2024-09-26 10:20 ` AngeloGioacchino Del Regno
2024-09-26 16:25 ` Conor Dooley
2024-10-08 4:03 ` Macpaul Lin [this message]
2024-10-08 16:31 ` Conor Dooley
2024-10-11 6:56 ` Macpaul Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a970560-2458-f5f3-87c5-925079fa12a4@mediatek.com \
--to=macpaul.lin@mediatek.com \
--cc=Jason-ch.Chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bear.wang@mediatek.com \
--cc=chris-qj.chen@mediatek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=macpaul@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=pablo.sun@mediatek.com \
--cc=robh@kernel.org \
--cc=sen.chu@mediatek.com \
--cc=vkoul@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox