From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Dan Carpenter <error27@gmail.com>,
Julien STEPHAN <jstephan@baylibre.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/mediatek: dsi: fix error codes in mtk_dsi_host_transfer()
Date: Wed, 1 Mar 2023 10:58:18 +0100 [thread overview]
Message-ID: <3bcf01ef-e9af-3216-6cd3-7cc08a5bfedd@collabora.com> (raw)
In-Reply-To: <Y/yBC4yxTs+Po0TG@kili>
Il 27/02/23 11:08, Dan Carpenter ha scritto:
> There is a type bug because the return statement:
>
> return ret < 0 ? ret : recv_cnt;
>
> will not return negatives on 64bit systems. The problem is that the
> function returns ssize_t types, while "ret" is int and "recv_cnt" is a
> u32. The negative values are type promoted to u32 and returned as
> positive values instead of negative error codes.
>
> Fixes: 81cc7e51c4f1 ("drm/mediatek: Allow commands to be sent during video mode")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
prev parent reply other threads:[~2023-03-01 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 10:08 [PATCH] drm/mediatek: dsi: fix error codes in mtk_dsi_host_transfer() Dan Carpenter
2023-03-01 9:53 ` Mattijs Korpershoek
2023-03-01 9:58 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bcf01ef-e9af-3216-6cd3-7cc08a5bfedd@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=error27@gmail.com \
--cc=jstephan@baylibre.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@baylibre.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox