From: Markus Elfring <Markus.Elfring@web.de>
To: Qasim Ijaz <qasdev00@gmail.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Angelo Gioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Bo Jiao <bo.jiao@mediatek.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Felix Fietkau <nbd@nbd.name>,
Johannes Berg <johannes@sipsolutions.net>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Peter Chiu <chui-hao.chiu@mediatek.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Shayne Chen <shayne.chen@mediatek.com>
Subject: Re: [PATCH] wifi: mt76: mt7996: prevent uninit return in mt7996_mac_sta_add_links
Date: Sat, 22 Mar 2025 12:44:51 +0100 [thread overview]
Message-ID: <3bef0804-83ca-44e1-87da-db5b777d68cb@web.de> (raw)
In-Reply-To: <20250320201914.48159-1-qasdev00@gmail.com>
> If link_conf_dereference_protected() or mt7996_vif_link()
> or link_sta_dereference_protected() fail the code jumps to
call failed?
> the error_unlink label and returns ret which is uninitialised.
a value from a local variable
which was not initialised properly?
Can the summary phrase be improved also another bit?
Regards,
Markus
next prev parent reply other threads:[~2025-03-22 11:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 20:19 [PATCH] wifi: mt76: mt7996: prevent uninit return in mt7996_mac_sta_add_links Qasim Ijaz
2025-03-21 16:36 ` Dan Carpenter
2025-03-21 17:14 ` Lorenzo Bianconi
2025-03-21 17:35 ` Dan Carpenter
2025-03-22 10:01 ` Markus Elfring
2025-03-22 10:19 ` Dan Carpenter
2025-03-22 10:20 ` Johannes Berg
2025-03-22 10:43 ` Markus Elfring
2025-03-22 11:44 ` Markus Elfring [this message]
2025-03-22 11:51 ` [PATCH] " Jonas Gorski
2025-03-22 22:51 ` Qasim Ijaz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bef0804-83ca-44e1-87da-db5b777d68cb@web.de \
--to=markus.elfring@web.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bo.jiao@mediatek.com \
--cc=chui-hao.chiu@mediatek.com \
--cc=dan.carpenter@linaro.org \
--cc=johannes@sipsolutions.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=qasdev00@gmail.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox