Re: [PATCH v2 10/14] ASoC: mediatek: mt8195: Fix ETDM MCLK error handling

[Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>]

On 10/5/2026 4:32 PM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Propagate errors from mt8195_afe_enable_clk() when enabling the
> ETDM MCLK instead of always returning success.
> 
> This allows callers to properly handle failures when enabling the
> MCLK.
> 
> Fixes: 1de9a54acafb ("ASoC: mediatek: mt8195: support etdm in platform driver")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

LGTM

Reviewed-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>

> ---
>   sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
> index 1a20adb2cbf5..fba51c552eec 100644
> --- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
> +++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
> @@ -1549,9 +1549,7 @@ static int mtk_dai_etdm_enable_mclk(struct mtk_base_afe *afe, int dai_id)
>   	if (clkdiv_id < 0)
>   		return -EINVAL;
>   
> -	mt8195_afe_enable_clk(afe, afe_priv->clk[clkdiv_id]);
> -
> -	return 0;
> +	return mt8195_afe_enable_clk(afe, afe_priv->clk[clkdiv_id]);
>   }
>   
>   static int mtk_dai_etdm_disable_mclk(struct mtk_base_afe *afe, int dai_id)