From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 336FBC001B0 for ; Mon, 7 Aug 2023 21:24:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HWjV/JZSmI71cSxLYWxl4ml12i1Zx1wvH49xFqSgbTs=; b=g1yTiarLuYH8qzW2zufz9SGMjh skH36lvsbnE8HR9ewTvFFXq8hkx21TOnr3oIAGk+WmS+pHGjY1HnitGKrpFq5u5ZPUwSPAJhFX04t d8eDGEgeySq1+lKq2y5SKTBZNL1V1N8gWm8MtoI1XZRFhQhb7eRZNB4zpuFSO1+ksN6zVEqzhl6Wp ljBvKt/oll7ONWgef5sQYNphZOr5KGqfGTwkAfoVZKgdb4Q2z8ZS5E0ZHpRVv2CFYZQrq4Qzi6078 vGK75iiwcus/05eRz408XoSI50FO9bZ7SQiiIyH3sbRZTgrsLIBbk/1/oz7dlYm9DGV9MjXNXhCTO 1FZFMHyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qT7iK-000l8o-1u; Mon, 07 Aug 2023 21:24:32 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qT7iE-000l6D-38; Mon, 07 Aug 2023 21:24:30 +0000 Received: from nicolas-tpx395.localdomain (unknown [IPv6:2606:6d00:15:bae9::7a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1024066071DC; Mon, 7 Aug 2023 22:24:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1691443458; bh=2uRACLUgOPi/Ps4I+8wopxV7zSDiO02U4+fu8x6OmQw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=JLpxJaIuO5qIfUO7YoSxgJsFRziGAJK3Ta6EcbgsdFZQX919hXwWsIm11iredXmzU efFO97p5KeIZblbnRleCVq6bx44XSszncbcUOAIDkKaaR4pm6gVRBCcFVzflGLm4e3 k2Ns6DVawtnSX2+EA/q8+/Y3wP/wudgYx8wC8IfmSYYqtSrO4J3qzQNn/dWHIlqZat Y1qqPfAYDGHJPkzChFYOp0BXuQc/X/kNWwWrwbZ8g/Hkc3HPEG5IykhaT7mwvvn8Hf idIOnz48ybbz6xCR1csyIYHjl16yzqWhZUxE6o4HQV4RA8MAAkd5VqN64h+2ZbxH2M FVJDBLHM5Acyw== Message-ID: <412d37d5b55d8a17ab0b840ce307281178946b87.camel@collabora.com> Subject: Re: [PATCH 4/5] docs: uapi: media: Add a layout diagram for MT2110T From: Nicolas Dufresne To: Andrzej Pietrasiewicz , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno Cc: kernel@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Date: Mon, 07 Aug 2023 17:24:08 -0400 In-Reply-To: References: <20230804192737.19016-1-nicolas.dufresne@collabora.com> <20230804192737.19016-5-nicolas.dufresne@collabora.com> <2e08b843-d1f3-a095-8e5c-cc4997773040@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_142427_272128_055C582C X-CRM114-Status: GOOD ( 21.05 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Le lundi 07 ao=C3=BBt 2023 =C3=A0 15:29 -0400, Nicolas Dufresne a =C3=A9cri= t=C2=A0: > Le lundi 07 ao=C3=BBt 2023 =C3=A0 20:40 +0200, Andrzej Pietrasiewicz a = =C3=A9crit=C2=A0: > > Hi Nicolas, > >=20 > > W dniu 4.08.2023 o=C2=A021:27, Nicolas Dufresne pisze: > > > This diagram details the partitioning done in each tiles. > >=20 > > If I understand correctly there are 8 partitions in the diagram, each p= artition=20 > > consists of 80 bytes, 64 bytes containing MSB data and 16 bytes contain= ing LSB > > data. The diagram says "MSB 8 bits" and "LSB 2 bits" which might be con= fusing > > because it suggests that the length of the partitions is maybe 8 bits p= lus 2 > > bits. IOW it is not clear that the numbers (8 and 2) refer to the kind = of=20 > > contents rather than lengths. Maybe to the left of the diagram should b= e some=20 > > arrows/curly braces describing the partitions' lengths? >=20 > You mean you'd add the partition height (4) in pixels ? Note, I'm thinkin= g of > using "8 MSB of pixel data", as it seem to translate to a better english = "8 most > significant bits of pixel data". I'm trying to avoid replacing the text, = it only > meant to be a visual support. An alternative, is really to leave the deta= ils in > the text, and label it "MSB of pixel data" and "LSB of pixel data". Any > preference ? Turns out I have also versed the low and high bit order in the doc, will fi= x that in next revision. The low bits partition come first. >=20 > Nicolas >=20 > >=20 > > Regards, > >=20 > > Andrzej > >=20 > > >=20 > > > Signed-off-by: Nicolas Dufresne > > > --- > > > .../userspace-api/media/v4l/mt2110t.svg | 268 +++++++++++++++= +++ > > > 1 file changed, 268 insertions(+) > > > create mode 100644 Documentation/userspace-api/media/v4l/mt2110t.sv= g > > >=20 > > > diff --git a/Documentation/userspace-api/media/v4l/mt2110t.svg b/Docu= mentation/userspace-api/media/v4l/mt2110t.svg > > > new file mode 100644 > > > index 000000000000..d4fc223f5fde > > > --- /dev/null > > > +++ b/Documentation/userspace-api/media/v4l/mt2110t.svg > > > @@ -0,0 +1,268 @@ > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + MSB 8 bits<= /tspan> > > > + > > > + > > > + > > > + > > > + > > > + > > > + LSB 2 bits<= /tspan> > > > + > > > + > > > + > > > + > > > + > > > + > > > + MSB 8 bits<= /tspan> > > > + > > > + > > > + > > > + > > > + > > > + > > > + LSB 2 bits<= /tspan> > > > + > > > + > > > + > > > + > > > + > > > + > > > + MSB 8 bits<= /tspan> > > > + > > > + > > > + > > > + > > > + > > > + > > > + LSB 2 bits<= /tspan> > > > + > > > + > > > + > > > + > > > + > > > + > > > + MSB 8 bits<= /tspan> > > > + > > > + > > > + > > > + > > > + > > > + > > > + LSB 2 bits > > > + > > > + > > > + > > > + > > > + > > > + > > > + MSB 8 bits > > > + > > > + > > > + > > > + > > > + > > > + > > > + LSB 2 bits > > > + > > > + > > > + > > > + > > > + > > > + > > > + MSB 8 bits > > > + > > > + > > > + > > > + > > > + > > > + > > > + LSB 2 bits > > > + > > > + > > > + > > > + > > > + > > > + > > > + MSB 8 bits > > > + > > > + > > > + > > > + > > > + > > > + > > > + LSB 2 bits > > > + > > > + > > > + > > > + > > > + > > > + > > > + MSB 8 bits > > > + > > > + > > > + > > > + > > > + > > > + > > > + LSB 2 bits > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + 16 px > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + 32 px > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > > > + > >=20 >=20