From: Felix Fietkau <nbd@nbd.name>
To: Ryder Lee <ryder.lee@mediatek.com>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Shayne Chen <shayne.chen@mediatek.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mt76: report Rx timestamp
Date: Sat, 27 Mar 2021 20:28:20 +0100 [thread overview]
Message-ID: <41727e36-e165-5b8e-4d76-be96f61bc83e@nbd.name> (raw)
In-Reply-To: <ae8caa3a01d527e464b09b4932d6cca14b1d49a2.1616831454.git.ryder.lee@mediatek.com>
On 2021-03-27 08:55, Ryder Lee wrote:
> Frame reception timestamp (low 32-bits) that indicates the value of the
> local TSF timer value at the time the first bit of the MAC header in the
> received frame (PPDU unit) arriving at the MAC.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> drivers/net/wireless/mediatek/mt76/agg-rx.c | 2 +-
> drivers/net/wireless/mediatek/mt76/mac80211.c | 1 +
> drivers/net/wireless/mediatek/mt76/mt76.h | 3 +-
> .../net/wireless/mediatek/mt76/mt7603/mac.c | 31 ++++++++++--------
> .../wireless/mediatek/mt76/mt7603/mt7603.h | 2 +-
> .../net/wireless/mediatek/mt76/mt7615/mac.c | 32 ++++++++++---------
> .../wireless/mediatek/mt76/mt7615/mt7615.h | 2 +-
> .../net/wireless/mediatek/mt76/mt7915/mac.c | 29 +++++++++--------
> .../wireless/mediatek/mt76/mt7915/mt7915.h | 2 +-
> .../net/wireless/mediatek/mt76/mt7921/mac.c | 29 +++++++++--------
> .../wireless/mediatek/mt76/mt7921/mt7921.h | 2 +-
> 11 files changed, 74 insertions(+), 61 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c
> index 144e8a8910ba..a37b8db979c6 100644
> --- a/drivers/net/wireless/mediatek/mt76/agg-rx.c
> +++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c
> @@ -77,7 +77,7 @@ mt76_rx_aggr_check_release(struct mt76_rx_tid *tid, struct sk_buff_head *frames)
> nframes--;
> status = (struct mt76_rx_status *)skb->cb;
> if (!time_after(jiffies,
> - status->reorder_time +
> + (unsigned long)status->reorder_time +
> mt76_aggr_tid_to_timeo(tid->num)))
> continue;
This doesn't work, you need to replace the time_after with a function
that takes u32 wraparound into account.
- Felix
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2021-03-27 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 7:55 [PATCH] mt76: report Rx timestamp Ryder Lee
2021-03-27 19:28 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41727e36-e165-5b8e-4d76-be96f61bc83e@nbd.name \
--to=nbd@nbd.name \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox