From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40A5AE77197 for ; Tue, 7 Jan 2025 06:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=opSX/QDIs55Wh83Tuv336j0AISiX882YeT5bW8m7/9o=; b=T1Ud9odOCYiI844LbFqFml5Plc HYHD4GkeBX2A2kWkxxl9ajRa2W/cZqt+rYl1cKf4u+wcWJnkCRMYHUqFl1I7TNExS7bLMt+ELnlqm YNMzXD0zoBt25Um8tPl9fyIIVcZHv0Vdw7u2Ny2rJPSLO+Fl5r2eH9z5KFUkvNCTvYSqIlnpSCQt9 hPe1XUklTchD3Se83SZ5eTa7NwtMZfsU+bOnR+P8euvQ/XZpr8+h/OYfacYEGYWDBe3/1Ea2qVmLa iBTTzLzP4Cl4hZx9oqwd+nfh8YFhrIgRhqBdr3Imw9IZSLTqEsU+eK8+Ym2MQ6Dx4DeTc4uggNGhI PzL6xdSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tV2uQ-00000003cYG-1OAa; Tue, 07 Jan 2025 06:17:46 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tV2tD-00000003cRS-29Hv; Tue, 07 Jan 2025 06:16:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AB16F5C5ACD; Tue, 7 Jan 2025 06:15:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90655C4CED6; Tue, 7 Jan 2025 06:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736230590; bh=rbm/HyJrgcyIONekUU1B/CycR6GsFRPZQR8HjkeAhyo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cU3zZcUhaekedmnJfQhGRR7XHeFxhCygwoAFGK1RANe0SFcW5VJlkPe1HwF53dxee v7S64dt76QJatjl2EM647ASIBOBagJDXrmBzTLvkEDDa7s3PpmH/hiNpAr3QfyjrjN cTwBQP9lFi/edM/DgfW4rbFiO36Gs2EWnDacPiDlv3oNjv2BjB57qRk+LVKuuoDsV8 lljnskCPl3XOtnQ37uvoolSkguAd+swO/SpEbbGiMr707cmiwKxUmcHL7/c/pU/8tj lxn6E6o84By92RSiElKr/+iRqT8mq3vglvP6/jl+0ewBjZon03iyI8ULbpcOERkviT nh0RGr2mWB+bA== Message-ID: <420caebd-136f-4015-96cd-5f37b9c3f49b@kernel.org> Date: Tue, 7 Jan 2025 07:16:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/7] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox To: =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= Cc: "robh@kernel.org" , "linux-media@vger.kernel.org" , "simona@ffwll.ch" , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , AngeloGioacchino Del Regno , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group , "conor+dt@kernel.org" , "linux-kernel@vger.kernel.org" , "chunkuang.hu@kernel.org" , "devicetree@vger.kernel.org" , "krzk+dt@kernel.org" , "jassisinghbrar@gmail.com" , =?UTF-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "airlied@gmail.com" , "dri-devel@lists.freedesktop.org" , "matthias.bgg@gmail.com" , =?UTF-8?B?TW91ZHkgSG8gKOS9leWul+WOnyk=?= , =?UTF-8?B?WGF2aWVyIENoYW5nICjlvLXnjbvmlocp?= References: <20241219170800.2957-1-jason-jh.lin@mediatek.com> <20241219170800.2957-2-jason-jh.lin@mediatek.com> <11f168c11b4cea48cf51406c0afaf8f1f53ad90f.camel@mediatek.com> <6adfa5fe-7b68-4f8e-919d-7b7607fe617c@kernel.org> <90b38dd6e093c89a7383814db786321cbd4533f6.camel@mediatek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <90b38dd6e093c89a7383814db786321cbd4533f6.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250106_221631_641675_7CEE3F9C X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 07/01/2025 03:42, Jason-JH Lin (林睿祥) wrote: >> >> Before proceeding with this header further, please answer to above - >> why >> interrupt numbers, MMIO addresses and some other values appearing in >> DTS >> are not used like "binding headers". > > Because interrupt numbers and MMIO addresses are the real numbers of > hardware settings. Their driver can get them directly from their device > node in DTS. They are actual number to be set into their hardware, so > they don't need to be translated in their platform drivers. > > So I think all the definitions in the `mediatek,mt8196-gce.h` are the > same case. They are actual hardware numbers for GCE hardware to use. > It should be drop from the include/dt-bindings/*. I did not inspect all of the defines you have there. Maybe some are used by driver, so I did not provide you definitive answer on entire header. The comment was addressing one specific group of defines which were not used as a binding. > > > BTW, to make these numbers more readable in DTS, can I move > `include/dt-bindings/mailbox/mediatek,mt8196-gce.h` into > `arch/arm64/boot/dts/mediatek/mt8196-gce.h`? Yes, sure. > > Just like the `arch/arm64/boot/dts/mediatek/mt8167-pinfunc.h`. Best regards, Krzysztof