From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Yunfei Dong" <yunfei.dong@mediatek.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Nathan Hebert" <nhebert@chromium.org>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>,
Steve Cho <stevecho@chromium.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v5,07/11] media: mediatek: vcodec: separate struct 'mtk_vcodec_ctx'
Date: Tue, 4 Jul 2023 14:12:54 +0200 [thread overview]
Message-ID: <421d7e5e-e28c-12ef-90ce-c976efd5b37e@collabora.com> (raw)
In-Reply-To: <20230704111327.7140-8-yunfei.dong@mediatek.com>
Il 04/07/23 13:13, Yunfei Dong ha scritto:
> Adding different context struct for encoder and decoder and removing
> struct 'mtk_vcodec_ctx'.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> .../mediatek/vcodec/mtk_vcodec_com_drv.h | 76 +++++
Only one remark. "com" may mean "communication" or "common", but if you rename
this to `mtk_vcodec_cmn_drv.h`, then "cmn" can only mean "common", which would
increase the chances to immediately understand what the header is about.
Unless, of course, anyone else has strong opinions against. Besides....
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2023-07-04 12:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 11:13 [PATCH v5,0/11] media: mediatek: vcodec: separate encoder and decoder Yunfei Dong
2023-07-04 11:13 ` [PATCH v5,01/11] media: mediatek: vcodec: remove unused parameter Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno
2023-07-04 11:13 ` [PATCH v5,02/11] media: mediatek: vcodec: align fw interface Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno
2023-07-04 11:13 ` [PATCH v5,03/11] media: mediatek: vcodec: Removing struct 'mtk_vcodec_ctx/dev' for shared interface Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno
2023-07-04 11:13 ` [PATCH v5,04/11] media: mediatek: vcodec: Removing useless debug log Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno
2023-07-04 11:13 ` [PATCH v5,05/11] media: mediatek: vcodec: remove the dependency of vcodec " Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno
2023-07-04 11:13 ` [PATCH v5,06/11] media: mediatek: vcodec: replace pr_* with dev_* for v4l2 debug message Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno
2023-07-04 11:13 ` [PATCH v5,07/11] media: mediatek: vcodec: separate struct 'mtk_vcodec_ctx' Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno [this message]
2023-07-04 11:13 ` [PATCH v5,08/11] media: mediatek: vcodec: separate struct mtk_vcodec_dev Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno
2023-07-04 11:13 ` [PATCH v5,09/11] media: mediatek: vcodec: fix unreasonable parameter definition and style Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno
2023-07-04 11:13 ` [PATCH v5,10/11] media: mediatek: vcodec: remove unused include header Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno
2023-07-04 11:13 ` [PATCH v5,11/11] media: mediatek: vcodec: separete decoder and encoder Yunfei Dong
2023-07-04 12:12 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421d7e5e-e28c-12ef-90ce-c976efd5b37e@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nfraprado@collabora.com \
--cc=nhebert@chromium.org \
--cc=nicolas.dufresne@collabora.com \
--cc=stevecho@chromium.org \
--cc=wenst@chromium.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox