From: Felix Fietkau <nbd@nbd.name>
To: Shayne Chen <shayne.chen@mediatek.com>
Cc: linux-mediatek <linux-mediatek@lists.infradead.org>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Evelyn Tsai <evelyn.tsai@mediatek.com>
Subject: Re: [PATCH v2 08/10] mt76: mt7915: implement testmode rx support
Date: Mon, 12 Oct 2020 05:35:53 +0200 [thread overview]
Message-ID: <4333ebf5-3d19-3165-3275-6e6fac09abfa@nbd.name> (raw)
In-Reply-To: <20201012032538.21314-8-shayne.chen@mediatek.com>
On 2020-10-12 05:25, Shayne Chen wrote:
> Support testmode rx and display rx statistic by parsing RXV packet
> type, which is currently only enabled in testmode.
>
> Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
> v2: change last_snr to u8
>
> .../net/wireless/mediatek/mt76/mt7915/dma.c | 3 +
> .../net/wireless/mediatek/mt76/mt7915/mac.c | 37 +++++++
> .../net/wireless/mediatek/mt76/mt7915/mac.h | 5 +
> .../net/wireless/mediatek/mt76/mt7915/mcu.h | 1 +
> .../wireless/mediatek/mt76/mt7915/mt7915.h | 7 ++
> .../wireless/mediatek/mt76/mt7915/testmode.c | 97 +++++++++++++++++++
> .../wireless/mediatek/mt76/mt7915/testmode.h | 30 ++++++
> 7 files changed, 180 insertions(+)
>
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c
> @@ -169,12 +209,69 @@ mt7915_tm_set_state(struct mt76_dev *mdev, enum mt76_testmode_state state)
> mt7915_tm_set_tx_frames(dev, false);
> else if (state == MT76_TM_STATE_TX_FRAMES)
> mt7915_tm_set_tx_frames(dev, true);
> + else if (prev_state == MT76_TM_STATE_RX_FRAMES)
> + mt7915_tm_set_rx_frames(dev, false);
> + else if (state == MT76_TM_STATE_RX_FRAMES)
> + mt7915_tm_set_rx_frames(dev, true);
> else if (prev_state == MT76_TM_STATE_OFF || state == MT76_TM_STATE_OFF)
> mt7915_tm_init(dev);
>
> return 0;
> }
>
> +static int
> +mt7915_tm_dump_stats(struct mt76_dev *mdev, struct sk_buff *msg)
> +{
> + struct mt7915_dev *dev = container_of(mdev, struct mt7915_dev, mt76);
> + void *rx, *rssi;
> + int i;
> +
> + rx = nla_nest_start(msg, MT76_TM_STATS_ATTR_LAST_RX);
> + if (!rx)
> + return -ENOMEM;
> +
> + if (nla_put_s32(msg, MT76_TM_RX_ATTR_FREQ_OFFSET, dev->test.last_freq_offset))
> + return -ENOMEM;
> +
> + rssi = nla_nest_start(msg, MT76_TM_RX_ATTR_RCPI);
> + if (!rssi)
> + return -ENOMEM;
> +
> + for (i = 0; i < ARRAY_SIZE(dev->test.last_rcpi); i++)
> + if (nla_put_u8(msg, i, dev->test.last_rcpi[i]))
> + return -ENOMEM;
> +
> + nla_nest_end(msg, rssi);
> +
> + rssi = nla_nest_start(msg, MT76_TM_RX_ATTR_IB_RSSI);
> + if (!rssi)
> + return -ENOMEM;
> +
> + for (i = 0; i < ARRAY_SIZE(dev->test.last_ib_rssi); i++)
> + if (nla_put_s8(msg, i, dev->test.last_ib_rssi[i]))
> + return -ENOMEM;
> +
> + nla_nest_end(msg, rssi);
> +
> + rssi = nla_nest_start(msg, MT76_TM_RX_ATTR_WB_RSSI);
> + if (!rssi)
> + return -ENOMEM;
> +
> + for (i = 0; i < ARRAY_SIZE(dev->test.last_wb_rssi); i++)
> + if (nla_put_s8(msg, i, dev->test.last_wb_rssi[i]))
> + return -ENOMEM;
> +
> + nla_nest_end(msg, rssi);
> +
> + if (nla_put_s32(msg, MT76_TM_RX_ATTR_SNR, dev->test.last_snr))
> + return -ENOMEM;
You updated the comment in the header file, but not this part which
actually generates the attribute.
- Felix
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-10-12 3:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 3:25 [PATCH v2 01/10] mt76: testmode: switch ib and wb rssi to array type for per-antenna report Shayne Chen
2020-10-12 3:25 ` [PATCH v2 02/10] mt76: testmode: add snr attribute in rx statistics Shayne Chen
2020-10-12 3:25 ` [PATCH v2 03/10] mt76: testmode: add tx_rate_stbc parameter Shayne Chen
2020-10-12 3:25 ` [PATCH v2 04/10] mt76: testmode: add support for LTF and GI combinations for HE mode Shayne Chen
2020-10-12 3:25 ` [PATCH v2 05/10] mt76: mt7915: fix tx rate related fields in tx descriptor Shayne Chen
2020-10-12 3:25 ` [PATCH v2 06/10] mt76: testmode: add support for HE rate modes Shayne Chen
2020-10-12 3:25 ` [PATCH v2 07/10] mt76: mt7915: implement testmode tx support Shayne Chen
2020-10-12 3:25 ` [PATCH v2 08/10] mt76: mt7915: implement testmode rx support Shayne Chen
2020-10-12 3:35 ` Felix Fietkau [this message]
2020-10-12 3:25 ` [PATCH v2 09/10] mt76: mt7915: add support to set txpower in testmode Shayne Chen
2020-10-12 3:25 ` [PATCH v2 10/10] mt76: mt7915: add support to set tx frequency offset " Shayne Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4333ebf5-3d19-3165-3275-6e6fac09abfa@nbd.name \
--to=nbd@nbd.name \
--cc=evelyn.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox