From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3BCBC3DA6F for ; Thu, 24 Aug 2023 08:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gUylG3QHD9e6Z2fIY6F04F3ucTSCCpP7MjWAlKyLxwo=; b=o8jSzQFvp0dQPiWDkfIfwKaKag s4ox/uFI2eepvIMBt4GNlMMPNBxx+Q+iAgZMf/az9KYW0xOoa/O4tYBR1Z4eBu5vfzybAhDrgS1qc g5NQqFpUgDeARqRk4q2VfjQQPDJhvg1sbpm1BEYOpy4xUwqbdjkDeXviYJH3vlZ9XWKdNCWXms03o qUMHpfnf8nkZHUI9CqYTO5Y9JKj/a6VNI4I/tx1agpQmEZhGE61sc2pblxjNuR4oHr26OhH0x5oDq NMKRrNaQbDNPGlHkuzUEZ3T2nh5FlLNVPgWvUO/bFgbX/kI9h7EsIen93r5G9PkU0FjOoY8wVrFDv C/X8HEFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZ68S-002dPN-22; Thu, 24 Aug 2023 08:56:12 +0000 Received: from gandalf.ozlabs.org ([150.107.74.76]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZ68O-002dO2-0q; Thu, 24 Aug 2023 08:56:09 +0000 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4RWcPT715Jz4wy7; Thu, 24 Aug 2023 18:55:57 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RWcPD1WXsz4wxn; Thu, 24 Aug 2023 18:55:43 +1000 (AEST) Message-ID: <4450e65b-5de4-e503-ea2e-da95410f4c50@kaod.org> Date: Thu, 24 Aug 2023 10:55:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH -next 03/25] spi: aspeed: Use helper function devm_clk_get_enabled() Content-Language: en-US To: Li Zetao , broonie@kernel.org, chin-ting_kuo@aspeedtech.com, joel@jms.id.au, andrew@aj.id.au, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, fancer.lancer@gmail.com, olteanv@gmail.com, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, conor.dooley@microchip.com, daire.mcnamara@microchip.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, linus.walleij@linaro.org, heiko@sntech.de Cc: linux-spi@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-riscv@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20230822131237.1022815-1-lizetao1@huawei.com> <20230822131237.1022815-4-lizetao1@huawei.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20230822131237.1022815-4-lizetao1@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_015608_466001_C0AC4B30 X-CRM114-Status: UNSURE ( 6.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 8/22/23 15:12, Li Zetao wrote: > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared > and enabled clocks"), devm_clk_get() and clk_prepare_enable() can now be > replaced by devm_clk_get_enabled() when driver enables (and possibly > prepares) the clocks for the whole lifetime of the device. Moreover, it is > no longer necessary to unprepare and disable the clocks explicitly. > > Signed-off-by: Li Zetao Reviewed-by: Cédric Le Goater Thanks, C.