From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A28C3C05027 for ; Wed, 8 Feb 2023 09:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JAl05l/z0C1SvwhC/oACL1+X0RqSpt+10bBk4XcYT6Y=; b=i56v79TcGgUGNIJ6yRIeHs2MX3 DOP9EEr8ibxGMx7mfeRY0N5N76ug7uHitmMRPjwIBL3LBv3pCNos0DtJt8czGcYhIM4asXxNN5KGD gem/pZjXQ2GQjsyTiUECTWKeSNGHyzqDcQ8nxwknONBMdstB98bopvlV8XtSWTcAWB2ijGLmrtDZj mn4TIg/fRV4kJa8y3wzrq1fmOqYeokv5/RRVGyum5j9J3bHeGnl7Nx1Vl07PR89rBcyu8dRLq40Co UyMJRPguEcDlQlmSPmCYKJXyLjY60OwHk1QgNk9iPpvHFJy7IP6aeoH8l0cctkP+aFqrUxJlvphaK kKxwE86Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPgJO-00EfRa-12; Wed, 08 Feb 2023 09:00:18 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPgJC-00EfP9-PU; Wed, 08 Feb 2023 09:00:08 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 79BC5660208E; Wed, 8 Feb 2023 09:00:00 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1675846801; bh=11ktIaV2fDGiz0UeBz/ISfzVWABGbiyyfbya63PwGMs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=T9RV5qmD60LiRDwyUp39R43ZgRCBtA6FigFe30IE9fUCoDKiE1RRPyeOlOJRAjOCR 0xXLDap3/7wiCWeks9aHIsRWxfCTmSUG95o/RC6bvlHUAZQu4LXULvsQXdgY330NoR /4sMdFT3+vfrtGAPYTpCzM5FGtzz0nUhegRqPC79DirjtyJfsPp1Qf/pC5WJvrai54 O/4vWOarHvZ/fCosB1Ej9uBoam2d8OSEPk4R+CHOkdEbqQ1P+EHw1dJlp7flivDUny M19DaQL6g/+gdGiZnIRpyDakEE7YtCwgz5FJJiO3NHNt33Nqi/nC/gBu0i3qgfKTDm Ff95/Pqy2FIsA== Message-ID: <45f8e284-8d56-898b-0897-94c576e09c2c@collabora.com> Date: Wed, 8 Feb 2023 09:59:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 35/45] clk: mediatek: Split MT8195 clock drivers and allow module build To: Chen-Yu Tsai Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, johnson.wang@mediatek.com, miles.chen@mediatek.com, chun-jie.chen@mediatek.com, daniel@makrotopia.org, fparent@baylibre.com, msp@baylibre.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, zhaojh329@gmail.com, sam.shih@mediatek.com, edward-jw.yang@mediatek.com, yangyingliang@huawei.com, granquet@baylibre.com, pablo.sun@mediatek.com, sean.wang@mediatek.com, chen.zhong@mediatek.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230206152928.918562-1-angelogioacchino.delregno@collabora.com> <20230206152928.918562-36-angelogioacchino.delregno@collabora.com> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230208_010007_163135_22E7B6BA X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 08/02/23 09:28, Chen-Yu Tsai ha scritto: > On Mon, Feb 6, 2023 at 11:30 PM AngeloGioacchino Del Regno > wrote: >> >> MT8195 clock drivers were encapsulated in one single (and big) Kconfig >> option: there's no reason to do that, as it is totally unnecessary to >> build in all or none of them. >> >> Split them out: keep boot-critical clocks as bool and allow choosing >> non critical clocks as tristate. > > The power domain controller references vppsys*, vdecsys*, vdosys*, wpesys, > imgsys and camsys. I'd argue that this makes these clock drivers > semi-boot-critical. Maybe mfgcfg as well when we add the GPU? You don't need to power on additional power domains if you want to load modules from a ramdisk! :-) Besides, you caught me: mtk-pm-domains will be my next target after clocks... I don't like how it behaves in regard to probe deferrals. Specifically, I dislike the fact that you either register *all domains* or *none at all* (unless instantiating two different driver instances and that's ugly). Angelo > > They should be bundled together at the very least. The power domain > controller not probing disables all display and multimedia capabilities. > > Also wondering if we should have "default COMMON_CLK_MT8195" ... > > I suppose the same questions apply to other SoCs. > > ChenYu