From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBA01C02183 for ; Thu, 16 Jan 2025 14:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oe+dztQDOuMvnMICfl+B+KkAhLl67BENjk4vGTljxO0=; b=dVLtnSLq6el/bskeqr1ZEGopeQ Kgg81CjoZRbNwZNCIK0IGxl6vxYIt1i3IolGnvNkKqYeGDUEokegxZhtaGO+SXT7794MGUek7T8pm x+DvJ2gMFxQ2vcIawCiBYsPREPQBqkLtwQdrQxkIdjhyQ9ut5jp9tsXyJ967ezr6vdMEGpLEGF/rS L7YAxIztiQpZCQg8Zv2+jfBVLtMFhk0Vye1RvTxLbRWpNFZnNA44Kattb1e42856jHNJhFMBQVzwf CdV9LzWOTKfP8X3rtLeVbUayJ7M3AkmWG5LrRYF1G+KD5L/Mr0lkQVVJ4u4PQ7usW2n5ZLiVTh/+/ V3bLeWZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYRIy-0000000FGM8-06yg; Thu, 16 Jan 2025 14:57:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tYRCM-0000000FEdq-1uq3; Thu, 16 Jan 2025 14:50:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 294CE339; Thu, 16 Jan 2025 06:50:44 -0800 (PST) Received: from [10.1.37.67] (e122027.cambridge.arm.com [10.1.37.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3606B3F673; Thu, 16 Jan 2025 06:50:12 -0800 (PST) Message-ID: <460e6ee5-a6d1-4d93-9720-d6a5589a2434@arm.com> Date: Thu, 16 Jan 2025 14:50:10 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] drm/panfrost: Add support for Mali on the MT8370 SoC To: Louis-Alexis Eyraud , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Boris Brezillon Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20250116-mt8370-enable-gpu-v1-0-0a6b78e925c8@collabora.com> <20250116-mt8370-enable-gpu-v1-2-0a6b78e925c8@collabora.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20250116-mt8370-enable-gpu-v1-2-0a6b78e925c8@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250116_065018_533662_74B76734 X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 16/01/2025 14:25, Louis-Alexis Eyraud wrote: > This commit adds a compatible for the MediaTek MT8370 SoC, with an > integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core), and adds > platform data using the same supplies and the same power domain lists > as MT8186 (one regulator, two power domains). > > Signed-off-by: Louis-Alexis Eyraud Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 0f3935556ac761adcd80197d87e8e478df436fd5..1d51b64ed0f0660cc95263a289d5dad204540cfd 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -837,6 +837,15 @@ static const struct panfrost_compatible mediatek_mt8192_data = { > .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF), > }; > > +/* MT8370 uses the same power domains and power supplies as MT8186 */ > +static const struct panfrost_compatible mediatek_mt8370_data = { > + .num_supplies = ARRAY_SIZE(mediatek_mt8183_b_supplies) - 1, > + .supply_names = mediatek_mt8183_b_supplies, > + .num_pm_domains = ARRAY_SIZE(mediatek_mt8186_pm_domains), > + .pm_domain_names = mediatek_mt8186_pm_domains, > + .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF), > +}; > + > static const struct of_device_id dt_match[] = { > /* Set first to probe before the generic compatibles */ > { .compatible = "amlogic,meson-gxm-mali", > @@ -859,6 +868,7 @@ static const struct of_device_id dt_match[] = { > { .compatible = "mediatek,mt8186-mali", .data = &mediatek_mt8186_data }, > { .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data }, > { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data }, > + { .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8370_data }, > {} > }; > MODULE_DEVICE_TABLE(of, dt_match); >