From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38B70C4345F for ; Fri, 19 Apr 2024 07:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+Lci1CEq9GkI0dzlpkcin0yHRX6RDXD/ps07Wz6E6U4=; b=iPiJKSFzjUF52w4YyRfOIlIVj8 za8ZFClI2tCRcpW02+d10EV/FB5GOdOfx6SS5CxPG8wNoOd5XFSP6uOPpPg4lXjSQ6X1LLsXeP5os 3Ggh8cdAcN+R9S909MTmoJT9JW3CKT/NvafHddE7NoVumbeakMJQ37UAFJ0Sj97BvVeoBkhrDk4x3 jFdrwi37fhavgbstdT4gqJ0hNevJJUcZ8Xfu4gDWOuFVPE1JBXJ2kpumFfYvZnFmINVeVR+5G5rkD GoKs6Cm6k1W0pJ67ZYF8C0/Egi8RR8wyvI9lf+fTr22U0MH29zLCKpNrLRJya6/na3kOvYTNglk72 k3vxi7/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxilt-00000004nWe-3CX5; Fri, 19 Apr 2024 07:34:57 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxilp-00000004nVO-3BZJ; Fri, 19 Apr 2024 07:34:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713512092; bh=DyISyQg7WS1Y2u3RPJgVFUSFFcKg59nL1uyitoy15Lc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HMBWiD7oXdDRH9iC8ExLKlQq5mc7XNH3+hVD1yFkSG3rGi92pQAxlxV0ccasgXLnp SrBwxTUPSiRQNmJAfGlnnJuxOK3kcnZTIm+NuKq8cJa4NQq/6NZjBBpns1SEKdc8uj 2OYNu64SxBUgcE6Hd8FNDHyZcAR4vKVghsHONTo7AS9C/3vkMxJ8gbWS8s15x+Go2a HLdSyhWI7bcxmUeqq+OeCTSuQo/hvWZP0r5dN+fJ2gKB6sLkIJ8n7N+OLM54UQkih1 OOM1iqEEfSv3pQeCDQuV0ospWe4XU8Bkkp1XR7VuHlmNwtPKv93G8x72S9dpq3XqCx RIJlidE3jCP7A== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 867053781104; Fri, 19 Apr 2024 07:34:50 +0000 (UTC) Message-ID: <46549dca-95c0-48f0-acd7-e4a7725437bc@collabora.com> Date: Fri, 19 Apr 2024 09:34:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/17] clk: mediatek: mt8365-mm: fix DPI0 parent To: Alexandre Mergnat , Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Jitao Shi , CK Hu , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Michael Turquette , Stephen Boyd , Fabien Parent , Markus Schneider-Pargmann , Catalin Marinas , Will Deacon Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-clk@vger.kernel.org References: <20231023-display-support-v3-0-53388f3ed34b@baylibre.com> <20231023-display-support-v3-12-53388f3ed34b@baylibre.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20231023-display-support-v3-12-53388f3ed34b@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_003453_982317_2D917415 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 18/04/24 16:17, Alexandre Mergnat ha scritto: > To have a working display through DPI, a workaround has been > implemented downstream to add "mm_dpi0_dpi0" and "dpi0_sel" to > the DPI node. Shortly, that add an extra clock. > > It seems consistent to have the "dpi0_sel" as parent. > Additionnaly, "vpll_dpix" isn't used/managed. > > Then, set the "mm_dpi0_dpi0" parent clock to "dpi0_sel". > > The new clock tree is: > > clk26m > lvdspll > lvdspll_X (2, 4, 8, 16) > dpi0_sel > mm_dpi0_dpi0 > > Fixes: d46adccb7966 ("clk: mediatek: add driver for MT8365 SoC") > Signed-off-by: Alexandre Mergnat I wonder what CLK_TOP_VPLL_DPIX_EN is for, but since you've ruled it out by removing the dependency, this clock is 100% being disabled because unused and the DPI interface clearly still works. I also wonder if that clock is getting en/disabled by HW control mechanism... ...because that'd make sense, as this is .. well, a DPI clock. That's just out of curiosity though, as I'd really like to understand whenwhatwhy for stuff.... In any case, whether you have an answer or not, this commit is: Reviewed-by: AngeloGioacchino Del Regno Cheers!