From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01387C76188 for ; Wed, 5 Apr 2023 13:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DPNYGvD9ecGreX0PVmpRlH15Pei/+SNAv596EloBSvk=; b=Yh2AgXZsqX/C65mV6DsOUTRi3B vyXcOqfYs1HadndE4jxwM+clfmvyLmwG+XH9KCjgrwa8MeVimeNmrSOaEabErWpHqDxqG2KtJLOch vKSMoA0cQ86hEVI8Cl8oH19HarttmRcda5sq+NhtAvguVhS6hXDVut6XIvg6TCmAj2IP7PWJpwN8P nN4CH7B3z3t53hE5QLacb6NpvRlZvhHE3g9wNd9EI4SUZM/7jDyeR1uCigJ82btiyElb1R6s3V6Ue OGSmirobr03A8tpPE1MFmLM455EkCly6S5XNc8DLsm5+vgp0PembIfytJ/OfMWiDHf0HidnkHCH77 jAKnubtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pk2mD-004Sq8-30; Wed, 05 Apr 2023 13:02:13 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pk2m9-004Sow-2E; Wed, 05 Apr 2023 13:02:10 +0000 Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pk2lE-0006xn-Nr; Wed, 05 Apr 2023 15:01:12 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Srinivas Kandagatla , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Hector Martin , Sven Peter , Alyssa Rosenzweig , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Claudiu Beznea , Matthias Brugger , AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Vincent Shih , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Kunihiko Hayashi , Masami Hiramatsu , Michal Simek , Alessandro Zummo , Alexandre Belloni , Evgeniy Polyakov , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-rtc@vger.kernel.org, Michael Walle , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V4] nvmem: add explicit config option to read old syntax fixed OF cells Date: Wed, 05 Apr 2023 15:01:10 +0200 Message-ID: <4767237.ejJDZkT8p0@diego> In-Reply-To: <20230403225540.1931-1-zajec5@gmail.com> References: <20230403225540.1931-1-zajec5@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230405_060209_746537_D9CE8E2C X-CRM114-Status: GOOD ( 18.74 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Am Dienstag, 4. April 2023, 00:55:40 CEST schrieb Rafa=C5=82 Mi=C5=82ecki: > From: Rafa=C5=82 Mi=C5=82ecki >=20 > Binding for fixed NVMEM cells defined directly as NVMEM device subnodes > has been deprecated. It has been replaced by the "fixed-layout" NVMEM > layout binding. >=20 > New syntax is meant to be clearer and should help avoiding imprecise > bindings. >=20 > NVMEM subsystem already supports the new binding. It should be a good > idea to limit support for old syntax to existing drivers that actually > support & use it (we can't break backward compatibility!). That way we > additionally encourage new bindings & drivers to ignore deprecated > binding. >=20 > It wasn't clear (to me) if rtc and w1 code actually uses old syntax > fixed cells. I enabled them to don't risk any breakage. >=20 > Signed-off-by: Rafa=C5=82 Mi=C5=82ecki > [for meson-{efuse,mx-efuse}.c] > Acked-by: Martin Blumenstingl > [for mtk-efuse.c, nvmem/core.c, nvmem-provider.h] > Reviewed-by: AngeloGioacchino Del Regno > [MT8192, MT8195 Chromebooks] > Tested-by: AngeloGioacchino Del Regno > [for microchip-otpc.c] > Reviewed-by: Claudiu Beznea > [SAMA7G5-EK] > Tested-by: Claudiu Beznea > diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efus= e.c > index e4579de5d014..adc8bc70cffa 100644 > --- a/drivers/nvmem/rockchip-efuse.c > +++ b/drivers/nvmem/rockchip-efuse.c > @@ -205,6 +205,7 @@ static int rockchip_rk3399_efuse_read(void *context, = unsigned int offset, > =20 > static struct nvmem_config econfig =3D { > .name =3D "rockchip-efuse", > + .add_legacy_fixed_of_cells =3D true, > .stride =3D 1, > .word_size =3D 1, > .read_only =3D true, for rockchip-efuse.c Reviewed-by: Heiko Stuebner