From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D67B0C433E0 for ; Sun, 14 Jun 2020 20:42:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A35862065C for ; Sun, 14 Jun 2020 20:42:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pzlcPUCn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A35862065C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cryz0Ujr+4qAyhSn5BGJiJDPB4Pkdoqi3lXMTYRZMlk=; b=pzlcPUCno8V2jh vVXhR6RRMRPxPjYeTxutmL2ONiOprf7BaFPtca+G8ad8Qih13AUNLuNUqcfut1kyPi6yNi9c2vDI4 e+FSOhi/sraCwEtBa4NTCc6ykuZQ0mxD+5hhAdVFwuilrwlkM2vTLFA1YdIOTDPPvcrQKklMvkRnA YnsoPOyNM5W6WofNvUdDZnDqoUT1Bls26tfuFebwbG2Bl+3skOeczf2LlddjmxjwuTYlVxXsH20pv 3ekSnKcX0J+PI2x+gCMc2uGc5lFPAAvKb+hc/wYiVfQKHUe1eEVFgIVc8DohX+3AW1nCpCSG3ByQx c7abBV4mn0Lq3rr/0vBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkZS5-0002P8-5L; Sun, 14 Jun 2020 20:42:01 +0000 Received: from smtprelay0068.hostedemail.com ([216.40.44.68] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkZRw-0002IT-Cn; Sun, 14 Jun 2020 20:41:53 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 79E4F15E7; Sun, 14 Jun 2020 20:41:44 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: error76_4e1659226df0 X-Filterd-Recvd-Size: 1906 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Sun, 14 Jun 2020 20:41:42 +0000 (UTC) Message-ID: <48891eaf60c5e0c449e573a906894db2c3a7b72c.camel@perches.com> Subject: Re: [PATCH] drm/mediatek: remove unnecessary conversion to bool From: Joe Perches To: Bernard Zhao , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Date: Sun, 14 Jun 2020 13:41:41 -0700 In-Reply-To: <20200612124007.4990-1-bernard@vivo.com> References: <20200612124007.4990-1-bernard@vivo.com> User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200614_134152_495063_0060FB34 X-CRM114-Status: UNSURE ( 7.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: opensource.kernel@vivo.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2020-06-12 at 20:40 +0800, Bernard Zhao wrote: > In function mtk_dsi_clk_hs_state, remove unnecessary conversion > to bool return, this change is to make the code a bit readable. [] > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c [] > @@ -319,7 +319,7 @@ static bool mtk_dsi_clk_hs_state(struct mtk_dsi *dsi) > u32 tmp_reg1; > > tmp_reg1 = readl(dsi->regs + DSI_PHY_LCCON); > - return ((tmp_reg1 & LC_HS_TX_EN) == 1) ? true : false; > + return ((tmp_reg1 & LC_HS_TX_EN) == 1); Given: drivers/gpu/drm/mediatek/mtk_dsi.c:#define LC_HS_TX_EN BIT(0) This is likely clearer as return tmp_reg1 & LC_HS_TX_EN; or even static bool mtk_dsi_clk_hs_state(struct mtk_dsi *dsi) { return readl(dsi->regs + DSI_PHY_LCCON) & LC_HS_TX_EN; } _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek