From: Matthias Brugger <matthias.bgg@gmail.com>
To: Zhiyong Tao <zhiyong.tao@mediatek.com>,
robh+dt@kernel.org, jic23@kernel.org, knaack.h@gmx.de,
lars@metafoo.de, pmeerw@pmeerw.net
Cc: srv_heupstream@mediatek.com, hui.liu@mediatek.com,
yingjoe.chen@mediatek.com, sean.wang@mediatek.com,
erin.lo@mediatek.com, eddie.huang@mediatek.com,
s.hauer@pengutronix.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: adc: mt8183: add binding document
Date: Tue, 23 Apr 2019 16:35:49 +0200 [thread overview]
Message-ID: <4c7f244f-4111-9e28-5134-8f108b1dbafa@gmail.com> (raw)
In-Reply-To: <20190422115417.16751-2-zhiyong.tao@mediatek.com>
On 22/04/2019 13:54, Zhiyong Tao wrote:
> The commit adds mt8183 compatible node in binding document.
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> ---
> Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> index 0df9befdaecc..05bc79d8483c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt
> @@ -15,6 +15,7 @@ Required properties:
> - "mediatek,mt2712-auxadc": For MT2712 family of SoCs
> - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
> - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
> + - "mediatek,mt8183-auxadc": For MT8183 family of SoCs
> - reg: Address range of the AUXADC unit.
> - clocks: Should contain a clock specifier for each entry in clock-names
> - clock-names: Should contain "main".
>
You are missing the logic in the driver to bind against this compatible.
If there is nothing different from other SoCs then you could add a compatible
with a fallback, like:
"mediatek,mt8183-auxadc", "mediatek,mt7622-auxadc": For MT8183 family of SoCs
Regards,
Matthias
next prev parent reply other threads:[~2019-04-23 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 11:54 [PATCH 0/1] AUXADC: Mediatek auxadc driver on MT8183 Zhiyong Tao
2019-04-22 11:54 ` [PATCH 1/2] dt-bindings: adc: mt8183: add binding document Zhiyong Tao
2019-04-23 14:35 ` Matthias Brugger [this message]
2019-04-24 0:51 ` Zhiyong Tao
2019-04-22 11:54 ` [PATCH 2/2] arm64: dts: mt8183: Add auxadc device node Zhiyong Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c7f244f-4111-9e28-5134-8f108b1dbafa@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=erin.lo@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sean.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox