From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tero Kristo Subject: Re: [PATCH] arm64: dts: Remove inconsistent use of 'arm,armv8' compatible string Date: Thu, 10 Jan 2019 14:02:12 +0200 Message-ID: <4c934f57-5e99-1224-ae25-8384f8d5eb27@ti.com> References: <20190109202934.29304-1-robh@kernel.org> <20190110022709.kh5vlave65jn7m4g@kahuna> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190110022709.kh5vlave65jn7m4g@kahuna> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Nishanth Menon , Rob Herring Cc: Mark Rutland , Andrew Lunn , Heiko Stuebner , Maxime Ripard , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liviu Dudau , David Brown , Thierry Reding , Wei Xu , Manivannan Sadhasivam , Lorenzo Pieralisi , arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kevin Hilman , Gregory Clement , Magnus Damm , Michal Simek , Krzysztof Kozlowski , Jonathan Hunter , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Chen-Yu Tsai , Kukjin Kim , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Baolin Wang List-Id: linux-mediatek@lists.infradead.org On 10/01/2019 04:27, Nishanth Menon wrote: > On 14:29-20190109, Rob Herring wrote: >> The 'arm,armv8' compatible string is only for software models. It adds >> little value otherwise and is inconsistently used as a fallback on some >> platforms. Remove it from those platforms. >> >> This fixes warnings generated by the DT schema. >> >> Reported-by: Michal Simek >> Cc: Mark Rutland >> Cc: Will Deacon >> Signed-off-by: Rob Herring >> --- > [...] > > ARM SoC maintainers, At least on a quick look (I could be wrong), I > think we don't have any explicit processor bindings documentation. > > However, most of SoC folks seem to key off matches else where I > guess.. > > Not sure, while at this, you if you are planning on fixing up > Documentation/devicetree/bindings/arm/arm-boards: > compatible = "arm,cortex-a53","arm,armv8"; > Documentation/devicetree/bindings/arm/cpu-capacity.txt: > compatible = "arm,cortex-a53","arm,armv8"; > > Anyways, for TI SoC: > >> arch/arm64/boot/dts/ti/k3-am654.dtsi | 8 +- >> diff --git a/arch/arm64/boot/dts/ti/k3-am654.dtsi b/arch/arm64/boot/dts/ti/k3-am654.dtsi >> index 2affa6f6617e..b221abf43ac2 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am654.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am654.dtsi >> @@ -34,7 +34,7 @@ >> }; >> >> cpu0: cpu@0 { >> - compatible = "arm,cortex-a53", "arm,armv8"; >> + compatible = "arm,cortex-a53"; >> reg = <0x000>; >> device_type = "cpu"; >> enable-method = "psci"; >> @@ -48,7 +48,7 @@ >> }; >> >> cpu1: cpu@1 { >> - compatible = "arm,cortex-a53", "arm,armv8"; >> + compatible = "arm,cortex-a53"; >> reg = <0x001>; >> device_type = "cpu"; >> enable-method = "psci"; >> @@ -62,7 +62,7 @@ >> }; >> >> cpu2: cpu@100 { >> - compatible = "arm,cortex-a53", "arm,armv8"; >> + compatible = "arm,cortex-a53"; >> reg = <0x100>; >> device_type = "cpu"; >> enable-method = "psci"; >> @@ -76,7 +76,7 @@ >> }; >> >> cpu3: cpu@101 { >> - compatible = "arm,cortex-a53", "arm,armv8"; >> + compatible = "arm,cortex-a53"; >> reg = <0x101>; >> device_type = "cpu"; >> enable-method = "psci"; > > Acked-by: Nishanth Menon > TI portion looks fine to me also, so: Acked-by: Tero Kristo -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki