Re: [PATCH] dt-bindings: mailbox: mediatek,gce-mailbox: Add support for MT6893

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 21/04/25 23:38, Rob Herring ha scritto:
> On Wed, Apr 16, 2025 at 02:02:30PM +0200, AngeloGioacchino Del Regno wrote:
>> Add a compatible string for the MediaTek Dimensity 1200 (MT6893)
>> SoC using MT8195 as a fallback, and add a header for the GCE
>> mailbox found in MT6893.
>>
>> Similarly to MT8195, this SoC has two GCE hardware instances, but
>> the event values are different (hence requiring its own header).
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   .../mailbox/mediatek,gce-mailbox.yaml         |   4 +
>>   include/dt-bindings/gce/mediatek,mt6893-gce.h | 312 ++++++++++++++++++
>>   2 files changed, 316 insertions(+)
>>   create mode 100644 include/dt-bindings/gce/mediatek,mt6893-gce.h
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
>> index 73d6db34d64a..277d290d852b 100644
>> --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
>> @@ -19,6 +19,7 @@ properties:
>>       oneOf:
>>         - enum:
>>             - mediatek,mt6779-gce
>> +          - mediatek,mt6893-gce
>>             - mediatek,mt8173-gce
>>             - mediatek,mt8183-gce
>>             - mediatek,mt8186-gce
>> @@ -29,6 +30,9 @@ properties:
>>         - items:
>>             - const: mediatek,mt6795-gce
>>             - const: mediatek,mt8173-gce
>> +      - items:
>> +          - const: mediatek,mt6893-gce
>> +          - const: mediatek,mt8195-gce
> 
> You shouldn't have with and without a fallback.
> 

OOOPS! Sorry, that wasn't intentional - I was meaning to add mt6893-gce to the
enum only, without that mt8195 fallback.

Will send a v2, thanks for pointing out!

Cheers,
Angelo

>>   
>>     "#mbox-cells":
>>       const: 2